mirror of https://github.com/ansible/ansible.git
Removes deprecated "append" param from snat pool (#32953)
This param was deprecated in 2.4 and slated for removal in 2.5. This patch removes it.pull/32881/head
parent
aeb896375d
commit
3f3c526026
@ -0,0 +1,20 @@
|
|||||||
|
{
|
||||||
|
"kind": "tm:ltm:snatpool:snatpoolstate",
|
||||||
|
"name": "asdasd",
|
||||||
|
"partition": "Common",
|
||||||
|
"fullPath": "/Common/asdasd",
|
||||||
|
"generation": 40,
|
||||||
|
"selfLink": "https://localhost/mgmt/tm/ltm/snatpool/~Common~asdasd?ver=12.1.2",
|
||||||
|
"members": [
|
||||||
|
"/Common/1.1.1.1",
|
||||||
|
"/Common/2.2.2.2"
|
||||||
|
],
|
||||||
|
"membersReference": [
|
||||||
|
{
|
||||||
|
"link": "https://localhost/mgmt/tm/ltm/snat-translation/~Common~1.1.1.1?ver=12.1.2"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"link": "https://localhost/mgmt/tm/ltm/snat-translation/~Common~2.2.2.2?ver=12.1.2"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
@ -0,0 +1,180 @@
|
|||||||
|
# -*- coding: utf-8 -*-
|
||||||
|
#
|
||||||
|
# Copyright (c) 2017 F5 Networks Inc.
|
||||||
|
# GNU General Public License v3.0 (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
||||||
|
|
||||||
|
from __future__ import (absolute_import, division, print_function)
|
||||||
|
__metaclass__ = type
|
||||||
|
|
||||||
|
import os
|
||||||
|
import json
|
||||||
|
import sys
|
||||||
|
|
||||||
|
from nose.plugins.skip import SkipTest
|
||||||
|
if sys.version_info < (2, 7):
|
||||||
|
raise SkipTest("F5 Ansible modules require Python >= 2.7")
|
||||||
|
|
||||||
|
from ansible.compat.tests import unittest
|
||||||
|
from ansible.compat.tests.mock import patch, Mock
|
||||||
|
from ansible.module_utils import basic
|
||||||
|
from ansible.module_utils._text import to_bytes
|
||||||
|
from ansible.module_utils.f5_utils import AnsibleF5Client
|
||||||
|
|
||||||
|
try:
|
||||||
|
from library.bigip_snat_pool import Parameters
|
||||||
|
from library.bigip_snat_pool import ModuleManager
|
||||||
|
from library.bigip_snat_pool import ArgumentSpec
|
||||||
|
from ansible.module_utils.f5_utils import iControlUnexpectedHTTPError
|
||||||
|
except ImportError:
|
||||||
|
try:
|
||||||
|
from ansible.modules.network.f5.bigip_snat_pool import Parameters
|
||||||
|
from ansible.modules.network.f5.bigip_snat_pool import ModuleManager
|
||||||
|
from ansible.modules.network.f5.bigip_snat_pool import ArgumentSpec
|
||||||
|
from ansible.module_utils.f5_utils import iControlUnexpectedHTTPError
|
||||||
|
except ImportError:
|
||||||
|
raise SkipTest("F5 Ansible modules require the f5-sdk Python library")
|
||||||
|
|
||||||
|
fixture_path = os.path.join(os.path.dirname(__file__), 'fixtures')
|
||||||
|
fixture_data = {}
|
||||||
|
|
||||||
|
|
||||||
|
def set_module_args(args):
|
||||||
|
args = json.dumps({'ANSIBLE_MODULE_ARGS': args})
|
||||||
|
basic._ANSIBLE_ARGS = to_bytes(args)
|
||||||
|
|
||||||
|
|
||||||
|
def load_fixture(name):
|
||||||
|
path = os.path.join(fixture_path, name)
|
||||||
|
|
||||||
|
if path in fixture_data:
|
||||||
|
return fixture_data[path]
|
||||||
|
|
||||||
|
with open(path) as f:
|
||||||
|
data = f.read()
|
||||||
|
|
||||||
|
try:
|
||||||
|
data = json.loads(data)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
|
||||||
|
fixture_data[path] = data
|
||||||
|
return data
|
||||||
|
|
||||||
|
|
||||||
|
class TestParameters(unittest.TestCase):
|
||||||
|
def test_module_parameters(self):
|
||||||
|
args = dict(
|
||||||
|
name='my-snat-pool',
|
||||||
|
state='present',
|
||||||
|
members=['10.10.10.10', '20.20.20.20'],
|
||||||
|
partition='Common'
|
||||||
|
)
|
||||||
|
p = Parameters(args)
|
||||||
|
assert p.name == 'my-snat-pool'
|
||||||
|
assert p.state == 'present'
|
||||||
|
assert len(p.members) == 2
|
||||||
|
assert '/Common/10.10.10.10' in p.members
|
||||||
|
assert '/Common/20.20.20.20' in p.members
|
||||||
|
|
||||||
|
def test_api_parameters(self):
|
||||||
|
args = dict(
|
||||||
|
members=['/Common/10.10.10.10', '/foo/20.20.20.20']
|
||||||
|
)
|
||||||
|
p = Parameters(args)
|
||||||
|
assert len(p.members) == 2
|
||||||
|
assert '/Common/10.10.10.10' in p.members
|
||||||
|
assert '/Common/20.20.20.20' in p.members
|
||||||
|
|
||||||
|
|
||||||
|
@patch('ansible.module_utils.f5_utils.AnsibleF5Client._get_mgmt_root',
|
||||||
|
return_value=True)
|
||||||
|
class TestManager(unittest.TestCase):
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
self.spec = ArgumentSpec()
|
||||||
|
|
||||||
|
def test_create_snat_pool(self, *args):
|
||||||
|
set_module_args(dict(
|
||||||
|
name='my-snat-pool',
|
||||||
|
state='present',
|
||||||
|
members=['10.10.10.10', '20.20.20.20'],
|
||||||
|
password='passsword',
|
||||||
|
server='localhost',
|
||||||
|
user='admin'
|
||||||
|
))
|
||||||
|
|
||||||
|
client = AnsibleF5Client(
|
||||||
|
argument_spec=self.spec.argument_spec,
|
||||||
|
supports_check_mode=self.spec.supports_check_mode,
|
||||||
|
f5_product_name=self.spec.f5_product_name
|
||||||
|
)
|
||||||
|
mm = ModuleManager(client)
|
||||||
|
|
||||||
|
# Override methods to force specific logic in the module to happen
|
||||||
|
mm.exists = Mock(side_effect=[False, True])
|
||||||
|
mm.create_on_device = Mock(return_value=True)
|
||||||
|
|
||||||
|
results = mm.exec_module()
|
||||||
|
|
||||||
|
assert results['changed'] is True
|
||||||
|
assert len(results['members']) == 2
|
||||||
|
assert '/Common/10.10.10.10' in results['members']
|
||||||
|
assert '/Common/20.20.20.20' in results['members']
|
||||||
|
|
||||||
|
def test_create_snat_pool_idempotent(self, *args):
|
||||||
|
set_module_args(dict(
|
||||||
|
name='asdasd',
|
||||||
|
state='present',
|
||||||
|
members=['1.1.1.1', '2.2.2.2'],
|
||||||
|
password='passsword',
|
||||||
|
server='localhost',
|
||||||
|
user='admin'
|
||||||
|
))
|
||||||
|
|
||||||
|
current = Parameters(load_fixture('load_ltm_snatpool.json'))
|
||||||
|
|
||||||
|
client = AnsibleF5Client(
|
||||||
|
argument_spec=self.spec.argument_spec,
|
||||||
|
supports_check_mode=self.spec.supports_check_mode,
|
||||||
|
f5_product_name=self.spec.f5_product_name
|
||||||
|
)
|
||||||
|
mm = ModuleManager(client)
|
||||||
|
|
||||||
|
# Override methods to force specific logic in the module to happen
|
||||||
|
mm.exists = Mock(side_effect=[True, True])
|
||||||
|
mm.read_current_from_device = Mock(return_value=current)
|
||||||
|
|
||||||
|
results = mm.exec_module()
|
||||||
|
|
||||||
|
assert results['changed'] is False
|
||||||
|
|
||||||
|
def test_update_snat_pool(self, *args):
|
||||||
|
set_module_args(dict(
|
||||||
|
name='asdasd',
|
||||||
|
state='present',
|
||||||
|
members=['30.30.30.30'],
|
||||||
|
password='passsword',
|
||||||
|
server='localhost',
|
||||||
|
user='admin'
|
||||||
|
))
|
||||||
|
|
||||||
|
current = Parameters(load_fixture('load_ltm_snatpool.json'))
|
||||||
|
|
||||||
|
client = AnsibleF5Client(
|
||||||
|
argument_spec=self.spec.argument_spec,
|
||||||
|
supports_check_mode=self.spec.supports_check_mode,
|
||||||
|
f5_product_name=self.spec.f5_product_name
|
||||||
|
)
|
||||||
|
mm = ModuleManager(client)
|
||||||
|
|
||||||
|
# Override methods to force specific logic in the module to happen
|
||||||
|
mm.read_current_from_device = Mock(return_value=current)
|
||||||
|
mm.update_on_device = Mock(return_value=True)
|
||||||
|
mm.exists = Mock(return_value=True)
|
||||||
|
mm.create_on_device = Mock(return_value=True)
|
||||||
|
|
||||||
|
results = mm.exec_module()
|
||||||
|
|
||||||
|
assert results['changed'] is True
|
||||||
|
assert len(results['members']) == 1
|
||||||
|
assert '/Common/30.30.30.30' in results['members']
|
Loading…
Reference in New Issue