Remove incidental_win_ping test. (#76031)

It no longer provides any unique test coverage.

ci_complete
ci_coverage

test/integration/targets/incidental_win_ping/aliases

@@ -1,2 +0,0 @@
-shippable/windows/incidental
-windows

test/integration/targets/incidental_win_ping/library/win_ping_set_attr.ps1

@@ -1,31 +0,0 @@
-#!powershell
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-# POWERSHELL_COMMON
-
-$params = Parse-Args $args $true;
-
-$data = Get-Attr $params "data" "pong";
-
-$result = @{
-    changed = $false
-    ping = "pong"
-};
-
-# Test that Set-Attr will replace an existing attribute.
-Set-Attr $result "ping" $data
-
-Exit-Json $result;

test/integration/targets/incidental_win_ping/library/win_ping_strict_mode_error.ps1

@@ -1,30 +0,0 @@
-#!powershell
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-# POWERSHELL_COMMON
-
-$params = Parse-Args $args $true;
-
-$params.thisPropertyDoesNotExist
-
-$data = Get-Attr $params "data" "pong";
-
-$result = @{
-    changed = $false
-    ping = $data
-};
-
-Exit-Json $result;

test/integration/targets/incidental_win_ping/library/win_ping_syntax_error.ps1

@@ -1,30 +0,0 @@
-#!powershell
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-# POWERSHELL_COMMON
-
-$blah = 'I can't quote my strings correctly.'
-
-$params = Parse-Args $args $true;
-
-$data = Get-Attr $params "data" "pong";
-
-$result = @{
-    changed = $false
-    ping = $data
-};
-
-Exit-Json $result;

test/integration/targets/incidental_win_ping/library/win_ping_throw.ps1

@@ -1,30 +0,0 @@
-#!powershell
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-# POWERSHELL_COMMON
-
-throw
-
-$params = Parse-Args $args $true;
-
-$data = Get-Attr $params "data" "pong";
-
-$result = @{
-    changed = $false
-    ping = $data
-};
-
-Exit-Json $result;

test/integration/targets/incidental_win_ping/library/win_ping_throw_string.ps1

@@ -1,30 +0,0 @@
-#!powershell
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-# POWERSHELL_COMMON
-
-throw "no ping for you"
-
-$params = Parse-Args $args $true;
-
-$data = Get-Attr $params "data" "pong";
-
-$result = @{
-    changed = $false
-    ping = $data
-};
-
-Exit-Json $result;

test/integration/targets/incidental_win_ping/tasks/main.yml

@@ -1,67 +0,0 @@
-# test code for the win_ping module
-# (c) 2014, Chris Church <chris@ninemoreminutes.com>
-
-# This file is part of Ansible
-#
-# Ansible is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# Ansible is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
-
-- name: test win_ping
-  action: win_ping
-  register: win_ping_result
-
-- name: check win_ping result
-  assert:
-    that:
-      - win_ping_result is not failed
-      - win_ping_result is not changed
-      - win_ping_result.ping == 'pong'
-
-- name: test win_ping with data
-  win_ping:
-    data: ☠
-  register: win_ping_with_data_result
-
-- name: check win_ping result with data
-  assert:
-    that:
-      - win_ping_with_data_result is not failed
-      - win_ping_with_data_result is not changed
-      - win_ping_with_data_result.ping == '☠'
-
-- name: test win_ping.ps1 with data as complex args
-  # win_ping.ps1: # TODO: do we want to actually support this? no other tests that I can see...
-  win_ping:
-    data: bleep
-  register: win_ping_ps1_result
-
-- name: check win_ping.ps1 result with data
-  assert:
-    that:
-      - win_ping_ps1_result is not failed
-      - win_ping_ps1_result is not changed
-      - win_ping_ps1_result.ping == 'bleep'
-
-- name: test win_ping using data=crash so that it throws an exception
-  win_ping:
-    data: crash
-  register: win_ping_crash_result
-  ignore_errors: yes
-
-- name: check win_ping_crash result
-  assert:
-    that:
-      - win_ping_crash_result is failed
-      - win_ping_crash_result is not changed
-      - 'win_ping_crash_result.msg == "Unhandled exception while executing module: boom"'
-      - '"throw \"boom\"" in win_ping_crash_result.exception'

test/sanity/ignore.txt

@@ -149,7 +149,6 @@ test/integration/targets/incidental_win_dsc/files/xTestDsc/1.0.0/DSCResources/AN
 test/integration/targets/incidental_win_dsc/files/xTestDsc/1.0.0/xTestDsc.psd1 pslint!skip
 test/integration/targets/incidental_win_dsc/files/xTestDsc/1.0.1/DSCResources/ANSIBLE_xTestResource/ANSIBLE_xTestResource.psm1 pslint!skip
 test/integration/targets/incidental_win_dsc/files/xTestDsc/1.0.1/xTestDsc.psd1 pslint!skip
-test/integration/targets/incidental_win_ping/library/win_ping_syntax_error.ps1 pslint!skip
 test/integration/targets/incidental_win_reboot/templates/post_reboot.ps1 pslint!skip
 test/integration/targets/json_cleanup/library/bad_json shebang
 test/integration/targets/lookup_csvfile/files/crlf.csv line-endings

test/utils/shippable/incidental/windows.sh

@@ -12,10 +12,6 @@ target="shippable/windows/incidental/"
 stage="${S:-prod}"
 provider="${P:-default}"
 
-# python versions to test in order
-IFS=' ' read -r -a python_versions <<< \
-    "$(PYTHONPATH="${PWD}/test/lib" python -c 'from ansible_test._internal import constants; print(" ".join(constants.CONTROLLER_PYTHON_VERSIONS))')"
-
 # python version to run full tests on while other versions run minimal tests
 python_default="$(PYTHONPATH="${PWD}/test/lib" python -c 'from ansible_test._internal import constants; print(constants.CONTROLLER_MIN_PYTHON_VERSION)')"
 
@@ -49,25 +45,8 @@ else
     )
 fi
 
-for version in "${python_versions[@]}"; do
+# shellcheck disable=SC2086
-    if [ "${version}" == "${python_default}" ]; then
+ansible-test windows-integration --color -v --retry-on-error "${target}" ${COVERAGE:+"$COVERAGE"} ${CHANGED:+"$CHANGED"} ${UNSTABLE:+"$UNSTABLE"} \
-        # full tests
-        ci="${target}"
-    else
-        # minimal tests for other python versions
-        ci="incidental_win_ping"
-    fi
-
-    # terminate remote instances on the final python version tested
-    if [ "${version}" = "${python_versions[-1]}" ]; then
-        terminate="always"
-    else
-        terminate="never"
-    fi
-
-    # shellcheck disable=SC2086
-    ansible-test windows-integration --color -v --retry-on-error "${ci}" ${COVERAGE:+"$COVERAGE"} ${CHANGED:+"$CHANGED"} ${UNSTABLE:+"$UNSTABLE"} \
     "${platforms[@]}" \
-        --docker default --python "${version}" \
+    --docker default --python "${python_default}" \
-        --remote-terminate "${terminate}" --remote-stage "${stage}" --remote-provider "${provider}"
+    --remote-terminate always --remote-stage "${stage}" --remote-provider "${provider}"
-done