Use unittest.mock instead of mock. (#77883)

This can only be done for controller tests.
pull/77886/head
Matt Clay 4 years ago committed by GitHub
parent 1eb7f71f0e
commit 3a9a23fb1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -9,7 +9,7 @@ import pkgutil
import pytest import pytest
import sys import sys
from mock import MagicMock, NonCallableMagicMock, patch from unittest.mock import MagicMock, NonCallableMagicMock, patch
def reset_internal_vendor_package(): def reset_internal_vendor_package():

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from units.mock.loader import DictDataLoader from units.mock.loader import DictDataLoader

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch from unittest.mock import patch
from ansible.cli.console import ConsoleCLI from ansible.cli.console import ConsoleCLI

@ -41,7 +41,7 @@ from ansible.module_utils._text import to_bytes, to_native, to_text
from ansible.utils import context_objects as co from ansible.utils import context_objects as co
from ansible.utils.display import Display from ansible.utils.display import Display
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
@pytest.fixture(autouse='function') @pytest.fixture(autouse='function')

@ -24,7 +24,7 @@ import os
import pytest import pytest
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from units.mock.vault_helper import TextVaultSecret from units.mock.vault_helper import TextVaultSecret
from ansible import context, errors from ansible import context, errors

@ -21,7 +21,7 @@ __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import mock_open, patch from unittest.mock import mock_open, patch
from ansible.errors import AnsibleError from ansible.errors import AnsibleError
from ansible.parsing.yaml.objects import AnsibleBaseYAMLObject from ansible.parsing.yaml.objects import AnsibleBaseYAMLObject

@ -6,7 +6,7 @@
from __future__ import (absolute_import, division, print_function) from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from mock import MagicMock from unittest.mock import MagicMock
from ansible.executor.interpreter_discovery import discover_interpreter from ansible.executor.interpreter_discovery import discover_interpreter
from ansible.module_utils._text import to_text from ansible.module_utils._text import to_text

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.executor.play_iterator import HostState, PlayIterator, IteratingStates, FailedStates from ansible.executor.play_iterator import HostState, PlayIterator, IteratingStates, FailedStates
from ansible.playbook import Playbook from ansible.playbook import Playbook

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import MagicMock from unittest.mock import MagicMock
from ansible.executor.playbook_executor import PlaybookExecutor from ansible.executor.playbook_executor import PlaybookExecutor
from ansible.playbook import Playbook from ansible.playbook import Playbook

@ -19,10 +19,10 @@
from __future__ import (absolute_import, division, print_function) from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
import mock from unittest import mock
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.errors import AnsibleError from ansible.errors import AnsibleError
from ansible.executor.task_executor import TaskExecutor, remove_omit from ansible.executor.task_executor import TaskExecutor, remove_omit
from ansible.plugins.loader import action_loader, lookup_loader from ansible.plugins.loader import action_loader, lookup_loader

@ -19,7 +19,7 @@
from __future__ import (absolute_import, division, print_function) from __future__ import (absolute_import, division, print_function)
from units.compat import unittest from units.compat import unittest
from mock import MagicMock from unittest.mock import MagicMock
from ansible.executor.task_queue_manager import TaskQueueManager from ansible.executor.task_queue_manager import TaskQueueManager
from ansible.playbook import Playbook from ansible.playbook import Playbook

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.executor.task_result import TaskResult from ansible.executor.task_result import TaskResult

@ -16,7 +16,7 @@ import tempfile
import time import time
from io import BytesIO, StringIO from io import BytesIO, StringIO
from mock import MagicMock from unittest.mock import MagicMock
import ansible.constants as C import ansible.constants as C
from ansible import context from ansible import context

@ -16,7 +16,7 @@ import uuid
from hashlib import sha256 from hashlib import sha256
from io import BytesIO from io import BytesIO
from mock import MagicMock, mock_open, patch from unittest.mock import MagicMock, mock_open, patch
import ansible.constants as C import ansible.constants as C
from ansible import context from ansible import context

@ -17,7 +17,7 @@ import tarfile
import yaml import yaml
from io import BytesIO, StringIO from io import BytesIO, StringIO
from mock import MagicMock, patch from unittest.mock import MagicMock, patch
from unittest import mock from unittest import mock
import ansible.module_utils.six.moves.urllib.error as urllib_error import ansible.module_utils.six.moves.urllib.error as urllib_error

@ -8,7 +8,7 @@ __metaclass__ = type
import os import os
import pytest import pytest
from mock import MagicMock from unittest.mock import MagicMock
import ansible.constants as C import ansible.constants as C
from ansible.cli.galaxy import GalaxyCLI, SERVER_DEF from ansible.cli.galaxy import GalaxyCLI, SERVER_DEF

@ -1,7 +1,7 @@
from __future__ import (absolute_import, division, print_function) from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from mock import MagicMock from unittest.mock import MagicMock
from ansible.utils.path import unfrackpath from ansible.utils.path import unfrackpath

@ -22,7 +22,7 @@ __metaclass__ = type
import os import os
from units.compat import unittest from units.compat import unittest
from mock import patch, mock_open from unittest.mock import patch, mock_open
from ansible.errors import AnsibleParserError, yaml_strings, AnsibleFileNotFound from ansible.errors import AnsibleParserError, yaml_strings, AnsibleFileNotFound
from ansible.parsing.vault import AnsibleVaultError from ansible.parsing.vault import AnsibleVaultError
from ansible.module_utils._text import to_text from ansible.module_utils._text import to_text

@ -30,7 +30,7 @@ from binascii import hexlify
import pytest import pytest
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible import errors from ansible import errors
from ansible.module_utils import six from ansible.module_utils import six

@ -27,7 +27,7 @@ from io import BytesIO, StringIO
import pytest import pytest
from units.compat import unittest from units.compat import unittest
from mock import patch from unittest.mock import patch
from ansible import errors from ansible import errors
from ansible.parsing import vault from ansible.parsing import vault

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch from unittest.mock import patch
from ansible.playbook import Play from ansible.playbook import Play
from ansible.playbook.role_include import IncludeRole from ansible.playbook.role_include import IncludeRole

@ -22,7 +22,7 @@ __metaclass__ = type
from collections.abc import Container from collections.abc import Container
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.errors import AnsibleError, AnsibleParserError from ansible.errors import AnsibleError, AnsibleParserError
from ansible.playbook.block import Block from ansible.playbook.block import Block

@ -3,7 +3,7 @@ __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from units.mock.loader import DictDataLoader from units.mock.loader import DictDataLoader
from mock import MagicMock from unittest.mock import MagicMock
from ansible.template import Templar from ansible.template import Templar
from ansible import errors from ansible import errors

@ -22,7 +22,7 @@ __metaclass__ = type
import os import os
from units.compat import unittest from units.compat import unittest
from mock import MagicMock from unittest.mock import MagicMock
from units.mock.loader import DictDataLoader from units.mock.loader import DictDataLoader
from ansible import errors from ansible import errors

@ -23,7 +23,7 @@ import os
import pytest import pytest
from mock import MagicMock from unittest.mock import MagicMock
from units.mock.loader import DictDataLoader from units.mock.loader import DictDataLoader
from ansible.playbook.block import Block from ansible.playbook.block import Block

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch from unittest.mock import patch
from ansible.playbook.task import Task from ansible.playbook.task import Task
from ansible.parsing.yaml import objects from ansible.parsing.yaml import objects
from ansible import errors from ansible import errors

@ -25,7 +25,7 @@ import re
from ansible import constants as C from ansible import constants as C
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock, mock_open from unittest.mock import patch, MagicMock, mock_open
from ansible.errors import AnsibleError, AnsibleAuthenticationFailure from ansible.errors import AnsibleError, AnsibleAuthenticationFailure
from ansible.module_utils.six import text_type from ansible.module_utils.six import text_type

@ -19,7 +19,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import MagicMock, patch from unittest.mock import MagicMock, patch
from ansible import constants as C from ansible import constants as C
from ansible.playbook.task import Task from ansible.playbook.task import Task

@ -22,7 +22,7 @@ import os
from ansible.errors import AnsibleActionFail from ansible.errors import AnsibleActionFail
from units.compat import unittest from units.compat import unittest
from mock import MagicMock, Mock from unittest.mock import MagicMock, Mock
from ansible.plugins.action.raw import ActionModule from ansible.plugins.action.raw import ActionModule
from ansible.playbook.task import Task from ansible.playbook.task import Task
from ansible.plugins.loader import connection_loader from ansible.plugins.loader import connection_loader

@ -23,7 +23,7 @@ import os
import shutil import shutil
import tempfile import tempfile
import mock from unittest import mock
from units.compat import unittest from units.compat import unittest
from ansible.errors import AnsibleError from ansible.errors import AnsibleError

@ -25,7 +25,7 @@ import textwrap
import types import types
from units.compat import unittest from units.compat import unittest
from mock import MagicMock from unittest.mock import MagicMock
from ansible.executor.task_result import TaskResult from ansible.executor.task_result import TaskResult
from ansible.inventory.host import Host from ansible.inventory.host import Host

@ -10,7 +10,7 @@ import pytest
import sys import sys
from io import StringIO from io import StringIO
from mock import MagicMock from unittest.mock import MagicMock
from ansible.playbook.play_context import PlayContext from ansible.playbook.play_context import PlayContext
from ansible.plugins.loader import connection_loader from ansible.plugins.loader import connection_loader

@ -27,7 +27,7 @@ import pytest
from ansible import constants as C from ansible import constants as C
from ansible.errors import AnsibleAuthenticationFailure from ansible.errors import AnsibleAuthenticationFailure
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock, PropertyMock from unittest.mock import patch, MagicMock, PropertyMock
from ansible.errors import AnsibleError, AnsibleConnectionFailure, AnsibleFileNotFound from ansible.errors import AnsibleError, AnsibleConnectionFailure, AnsibleFileNotFound
from ansible.module_utils.compat.selectors import SelectorKey, EVENT_READ from ansible.module_utils.compat.selectors import SelectorKey, EVENT_READ
from ansible.module_utils.six.moves import shlex_quote from ansible.module_utils.six.moves import shlex_quote

@ -12,7 +12,7 @@ import pytest
from io import StringIO from io import StringIO
from mock import MagicMock from unittest.mock import MagicMock
from ansible.errors import AnsibleConnectionFailure from ansible.errors import AnsibleConnectionFailure
from ansible.module_utils._text import to_bytes from ansible.module_utils._text import to_bytes
from ansible.playbook.play_context import PlayContext from ansible.playbook.play_context import PlayContext

@ -22,7 +22,7 @@ __metaclass__ = type
import string import string
import textwrap import textwrap
import mock from unittest import mock
from ansible import constants as C from ansible import constants as C
from units.compat import unittest from units.compat import unittest

@ -22,7 +22,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
import pytest import pytest
import mock from unittest import mock
from ansible import constants as C from ansible import constants as C
from ansible.errors import AnsibleError from ansible.errors import AnsibleError

@ -32,7 +32,7 @@ import pytest
from units.mock.loader import DictDataLoader from units.mock.loader import DictDataLoader
from units.compat import unittest from units.compat import unittest
from mock import mock_open, patch from unittest.mock import mock_open, patch
from ansible.errors import AnsibleError from ansible.errors import AnsibleError
from ansible.module_utils.six import text_type from ansible.module_utils.six import text_type
from ansible.module_utils.six.moves import builtins from ansible.module_utils.six.moves import builtins

@ -7,7 +7,7 @@ __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.executor.play_iterator import PlayIterator from ansible.executor.play_iterator import PlayIterator
from ansible.playbook import Playbook from ansible.playbook import Playbook

@ -23,7 +23,7 @@ from units.mock.loader import DictDataLoader
import uuid import uuid
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.executor.process.worker import WorkerProcess from ansible.executor.process.worker import WorkerProcess
from ansible.executor.task_queue_manager import TaskQueueManager from ansible.executor.task_queue_manager import TaskQueueManager
from ansible.executor.task_result import TaskResult from ansible.executor.task_result import TaskResult

@ -23,7 +23,7 @@ __metaclass__ = type
import os import os
from units.compat import unittest from units.compat import unittest
from mock import patch, MagicMock from unittest.mock import patch, MagicMock
from ansible.plugins.loader import PluginLoader, PluginPathContext from ansible.plugins.loader import PluginLoader, PluginPathContext

@ -22,7 +22,7 @@ __metaclass__ = type
from jinja2.runtime import Context from jinja2.runtime import Context
from units.compat import unittest from units.compat import unittest
from mock import patch from unittest.mock import patch
from ansible import constants as C from ansible import constants as C
from ansible.errors import AnsibleError, AnsibleUndefinedVariable from ansible.errors import AnsibleError, AnsibleUndefinedVariable

@ -20,7 +20,7 @@ from __future__ import (absolute_import, division, print_function)
__metaclass__ = type __metaclass__ = type
from units.compat import unittest from units.compat import unittest
from mock import MagicMock from unittest.mock import MagicMock
from ansible.template.vars import AnsibleJ2Vars from ansible.template.vars import AnsibleJ2Vars

@ -17,7 +17,7 @@ from ansible.utils.collection_loader._collection_finder import (
_get_collection_name_from_path, _get_collection_role_path, _get_collection_metadata, _iter_modules_impl _get_collection_name_from_path, _get_collection_role_path, _get_collection_metadata, _iter_modules_impl
) )
from ansible.utils.collection_loader._collection_config import _EventSource from ansible.utils.collection_loader._collection_config import _EventSource
from mock import MagicMock, NonCallableMagicMock, patch from unittest.mock import MagicMock, NonCallableMagicMock, patch
# fixture to ensure we always clean up the import stuff when we're done # fixture to ensure we always clean up the import stuff when we're done

@ -8,7 +8,7 @@ __metaclass__ = type
from ansible.utils.display import Display from ansible.utils.display import Display
from mock import MagicMock from unittest.mock import MagicMock
def test_display_with_fake_cowsay_binary(capsys, mocker): def test_display_with_fake_cowsay_binary(capsys, mocker):

@ -5,7 +5,7 @@
from __future__ import absolute_import, division, print_function from __future__ import absolute_import, division, print_function
__metaclass__ = type __metaclass__ = type
from mock import MagicMock from unittest.mock import MagicMock
import pytest import pytest

@ -22,7 +22,7 @@ __metaclass__ = type
from collections import defaultdict from collections import defaultdict
import mock from unittest import mock
from units.compat import unittest from units.compat import unittest
from ansible.errors import AnsibleError from ansible.errors import AnsibleError

@ -22,7 +22,7 @@ __metaclass__ = type
import os import os
from units.compat import unittest from units.compat import unittest
from mock import MagicMock, patch from unittest.mock import MagicMock, patch
from ansible.inventory.manager import InventoryManager from ansible.inventory.manager import InventoryManager
from ansible.module_utils.six import iteritems from ansible.module_utils.six import iteritems
from ansible.playbook.play import Play from ansible.playbook.play import Play

Loading…
Cancel
Save