Fix aws_s3 connection exception handling (#30955)

`ProfileNotFound` does not have a `response` attribute, and
`NoCredentialsError` does not occur at connection creation time.
pull/31061/merge
Will Thames 7 years ago committed by Sloane Hertel
parent 90dd698b86
commit 371c6dba8b

@ -609,9 +609,8 @@ def main():
aws_connect_kwargs.pop(key, None) aws_connect_kwargs.pop(key, None)
try: try:
s3 = get_s3_connection(module, aws_connect_kwargs, location, rgw, s3_url) s3 = get_s3_connection(module, aws_connect_kwargs, location, rgw, s3_url)
except (botocore.exceptions.NoCredentialsError, botocore.exceptions.ProfileNotFound) as e: except botocore.exceptions.ProfileNotFound as e:
module.fail_json(msg="Can't authorize connection. Check your credentials and profile.", module.fail_json(msg=to_native(e))
exceptions=traceback.format_exc(), **camel_dict_to_snake_dict(e.response))
validate = not ignore_nonexistent_bucket validate = not ignore_nonexistent_bucket

Loading…
Cancel
Save