Some more run_command updates.

reviewable/pr18780/r1
Michael DeHaan 11 years ago
parent d4d87c420f
commit 349063743f

@ -71,7 +71,7 @@ def query_package(module, name):
if pkg_info_path: if pkg_info_path:
pkgng = False pkgng = False
pkg_glob_path = module.get_bin_path('pkg_glob', True) pkg_glob_path = module.get_bin_path('pkg_glob', True)
rc, out, err = module.run_command("%s -e `pkg_glob %s`" % (pkg_info_path, name)) rc, out, err = module.run_command("%s -e `pkg_glob %s`" % (pkg_info_path, pipes.quote(name), use_unsafe_shell=True)
else: else:
pkgng = True pkgng = True
pkg_info_path = module.get_bin_path('pkg', True) pkg_info_path = module.get_bin_path('pkg', True)
@ -128,11 +128,11 @@ def remove_packages(module, packages):
if not query_package(module, package): if not query_package(module, package):
continue continue
rc, out, err = module.run_command("%s `%s %s`" % (pkg_delete_path, pkg_glob_path, package)) rc, out, err = module.run_command("%s `%s %s`" % (pkg_delete_path, pkg_glob_path, pipes.quote(package)), use_unsafe_shell=True)
if query_package(module, package): if query_package(module, package):
name_without_digits = re.sub('[0-9]', '', package) name_without_digits = re.sub('[0-9]', '', package)
rc, out, err = module.run_command("%s `%s %s`" % (pkg_delete_path, pkg_glob_path, name_without_digits)) rc, out, err = module.run_command("%s `%s %s`" % (pkg_delete_path, pkg_glob_path, pipes.quote(lame_without_digits)),use_unsafe_shell=True)
if query_package(module, package): if query_package(module, package):
module.fail_json(msg="failed to remove %s: %s" % (package, out)) module.fail_json(msg="failed to remove %s: %s" % (package, out))

@ -76,8 +76,7 @@ class Bzr(object):
self.bzr_path = bzr_path self.bzr_path = bzr_path
def _command(self, args_list, cwd=None, **kwargs): def _command(self, args_list, cwd=None, **kwargs):
(rc, out, err) = self.module.run_command( (rc, out, err) = self.module.run_command([self.bzr_path] + args_list, cwd=cwd, **kwargs)
[self.bzr_path] + args_list, cwd=cwd, **kwargs)
return (rc, out, err) return (rc, out, err)
def get_version(self): def get_version(self):

Loading…
Cancel
Save