win_group_membership - fix random issue with CI on 2012 R2 (#45462)

pull/45057/merge
Jordan Borean 6 years ago committed by GitHub
parent 881f3a599c
commit 3371a779b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -0,0 +1,2 @@
bugfixes:
- win_group_membership - fix intermittent issue where it failed to convert the ADSI object to the .NET object after using it once

@ -46,16 +46,24 @@ function Get-GroupMember {
[System.DirectoryServices.DirectoryEntry]$Group
)
$members = @()
$current_members = $Group.psbase.Invoke("Members") | ForEach-Object {
$bytes = ([ADSI]$_).InvokeGet("objectSID")
$sid = New-Object -TypeName Security.Principal.SecurityIdentifier -ArgumentList $bytes, 0
$adspath = ([ADSI]$_).InvokeGet("ADsPath")
@{sid = $sid; adspath = $adspath} | Write-Output
# instead of using ForEach pipeline we use a standard loop and cast the
# object to the ADSI adapter type before using it to get the SID and path
# this solves an random issue where multiple casts could fail once the raw
# object is invoked at least once
$raw_members = $Group.psbase.Invoke("Members")
$current_members = [System.Collections.ArrayList]@()
foreach ($raw_member in $raw_members) {
$raw_member = [ADSI]$raw_member
$sid_bytes = $raw_member.InvokeGet("objectSID")
$ads_path = $raw_member.InvokeGet("ADsPath")
$member_info = @{
sid = New-Object -TypeName System.Security.Principal.SecurityIdentifier -ArgumentList $sid_bytes, 0
adspath = $ads_path
}
$current_members.Add($member_info) > $null
}
$members = @()
foreach ($current_member in $current_members) {
$parsed_member = @{
sid = $current_member.sid

Loading…
Cancel
Save