Document and return an error if httplib2 >= 0.7 is not present. We

can't use httplib2 0.6.x and below because they do not verify TLS
certificates and thus are insecure.

Fixes #1875
reviewable/pr18780/r1
Toshio Kuratomi 9 years ago
parent 45a9f0b453
commit 22c2789b72

@ -25,6 +25,8 @@ import shutil
import tempfile import tempfile
import base64 import base64
import datetime import datetime
from distutils.version import LooseVersion
try: try:
import json import json
except ImportError: except ImportError:
@ -143,7 +145,8 @@ options:
version_added: '1.9.2' version_added: '1.9.2'
# informational: requirements for nodes # informational: requirements for nodes
requirements: [ urlparse, httplib2 ] requirements:
- httplib2 >= 0.7.0
author: "Romeo Theriault (@romeotheriault)" author: "Romeo Theriault (@romeotheriault)"
''' '''
@ -198,11 +201,15 @@ EXAMPLES = '''
''' '''
HAS_HTTPLIB2 = True HAS_HTTPLIB2 = False
try: try:
import httplib2 import httplib2
except ImportError: if LooseVersion(httplib2.__version__) >= LooseVersion('0.7'):
HAS_HTTPLIB2 = False HAS_HTTPLIB2 = True
except ImportError, AttributeError:
# AttributeError if __version__ is not present
pass
HAS_URLPARSE = True HAS_URLPARSE = True
@ -382,7 +389,7 @@ def main():
) )
if not HAS_HTTPLIB2: if not HAS_HTTPLIB2:
module.fail_json(msg="httplib2 is not installed") module.fail_json(msg="httplib2 >= 0.7 is not installed")
if not HAS_URLPARSE: if not HAS_URLPARSE:
module.fail_json(msg="urlparse is not installed") module.fail_json(msg="urlparse is not installed")

Loading…
Cancel
Save