[2.10] Handle post_validate templating errors and fix tests (#70240) (#70389)

* Handle post_validate templating errors and fix tests (#70240)

* Handle unexpected templating errors

* Fixes #70050

Fix up tests that weren't running and add tests for graceful templating error handling

(cherry picked from commit 30e70f4b63)

* changelog

ci_complete

changelogs/fragments/70240-fix-fatal-post_validate-error.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - TaskExecutor - Handle unexpected errors as failed while post validating loops (https://github.com/ansible/ansible/issues/70050).

lib/ansible/executor/task_executor.py

@@ -575,7 +575,12 @@ class TaskExecutor:
             return dict(include_args=include_args)
 
         # Now we do final validation on the task, which sets all fields to their final values.
+        try:
             self._task.post_validate(templar=templar)
+        except AnsibleError:
+            raise
+        except Exception:
+            return dict(changed=False, failed=True, _ansible_no_log=self._play_context.no_log, exception=to_text(traceback.format_exc()))
         if '_variable_params' in self._task.args:
             variable_params = self._task.args.pop('_variable_params')
             if isinstance(variable_params, dict):

test/integration/targets/templating_lookups/runme.sh

@@ -2,7 +2,7 @@
 
 set -eux
 
-ANSIBLE_ROLES_PATH=../ UNICODE_VAR=café ansible-playbook runme.yml "$@"
+ANSIBLE_ROLES_PATH=./ UNICODE_VAR=café ansible-playbook runme.yml "$@"
 
 ansible-playbook template_lookup_vaulted/playbook.yml --vault-password-file template_lookup_vaulted/test_vault_pass "$@"
 

test/integration/targets/templating_lookups/runme.yml

@@ -1,4 +1,4 @@
 - hosts: localhost
   gather_facts: no
   roles:
-    - { role: templating_lookups }
+    - { role: template_lookups }

test/integration/targets/templating_lookups/template_lookups/tasks/errors.yml

@@ -0,0 +1,31 @@
+- name: Task that fails due to templating error for plugin option
+  debug: msg="{{ 5 / 0 | int }}"
+  ignore_errors: true
+  register: result
+
+- assert:
+    that:
+      - result.failed
+      - result.exception
+
+- name: Loop that fails due to templating error in first entry and ignores errors
+  debug: msg="{{ 5 / item }}"
+  ignore_errors: true
+  register: result
+  loop: [0, 0, 1]
+
+- debug: var=result
+
+- assert:
+    that:
+      - result.results[0].failed
+      - result.results[0].exception
+      - result.results[0].item == 0
+
+      - result.results[1].failed
+      - result.results[1].exception
+      - result.results[1].item == 0
+
+      - not result.results[2].failed
+      - result.results[2].exception is undefined
+      - result.results[2].item == 1

test/integration/targets/templating_lookups/template_lookups/tasks/main.yml

@@ -86,3 +86,5 @@
   assert:
     that:
       - password1 != password2
+
+- include_tasks: ./errors.yml