Merge pull request #17943 from chouseknecht/galaxy_type_warning

Add warnings when installing container type roles

lib/ansible/galaxy/api.py

@@ -91,7 +91,8 @@ class GalaxyAPI(object):
             headers = self.__auth_header()
         try:
             display.vvv(url)
-            resp = open_url(url, data=args, validate_certs=self._validate_certs, headers=headers, method=method)
+            resp = open_url(url, data=args, validate_certs=self._validate_certs, headers=headers, method=method,
+                            timeout=20)
             data = json.load(resp)
         except HTTPError as e:
             res = json.load(e)

lib/ansible/galaxy/data/metadata_template.j2

@@ -18,18 +18,21 @@ galaxy_info:
 
   min_ansible_version: {{ min_ansible_version }}
 
+  # If this a Container Enabled role, provide the minimum Ansible Container version.
+  # min_ansible_container_version:
+
   # Optionally specify the branch Galaxy will use when accessing the GitHub
   # repo for this role. During role install, if no tags are available,
   # Galaxy will use this branch. During import Galaxy will access files on
-  # this branch. If travis integration is cofigured, only notification for this
+  # this branch. If Travis integration is configured, only notifications for this
   # branch will be accepted. Otherwise, in all cases, the repo's default branch
   # (usually master) will be used.
   #github_branch:
 
   #
-  # Below are all platforms currently available. Just uncomment
+  # Below are all platforms currently available. Just uncomment the ones that apply
-  # the ones that apply to your role. If you don't see your
+  # to your role. If you don't see your platform on this list, let us know,
-  # platform on this list, let us know and we'll get it added!
+  # and we'll get it added!
   #
   #platforms:
   {%- for platform,versions in platforms.items() %}
@@ -42,18 +45,16 @@ galaxy_info:
   {%- endfor %}
 
   galaxy_tags: []
-    # List tags for your role here, one per line. A tag is
+    # List tags for your role here, one per line. A tag is a keyword that describes
-    # a keyword that describes and categorizes the role.
+    # and categorizes the role. Users find roles by searching for tags. Be sure to
-    # Users find roles by searching for tags. Be sure to
+    # remove the '[]' above, if you add tags to this list.
-    # remove the '[]' above if you add tags to this list.
     #
-    # NOTE: A tag is limited to a single word comprised of
+    # NOTE: A tag is limited to a single word comprised of alphanumeric characters.
-    # alphanumeric characters. Maximum 20 tags per role.
+    #       Maximum 20 tags per role.
 
 dependencies: []
-  # List your role dependencies here, one per line.
+  # List your role dependencies here, one per line. Be sure to remove the '[]' above,
-  # Be sure to remove the '[]' above if you add dependencies
+  # if you add dependencies to this list.
-  # to this list.
   {%- for dependency in dependencies %}
   #- {{ dependency }}
   {%- endfor %}

lib/ansible/galaxy/role.py

@@ -49,7 +49,6 @@ class GalaxyRole(object):
     META_INSTALL = os.path.join('meta', '.galaxy_install_info')
     ROLE_DIRS = ('defaults','files','handlers','meta','tasks','templates','vars','tests')
 
-
     def __init__(self, galaxy, name, src=None, version=None, scm=None, path=None):
 
         self._metadata = None
@@ -83,6 +82,7 @@ class GalaxyRole(object):
                 self.paths = [x for x in galaxy.roles_paths]
                 self.paths = [os.path.join(x, self.name) for x in self.paths]
 
+
     def __eq__(self, other):
         return self.name == other.name
 
@@ -136,6 +136,8 @@ class GalaxyRole(object):
             version=self.version,
             install_date=datetime.datetime.utcnow().strftime("%c"),
         )
+        if not os.path.exists(os.path.join(self.path, 'meta')):
+            os.makedirs(os.path.join(self.path, 'meta'))
         info_path = os.path.join(self.path, self.META_INSTALL)
         with open(info_path, 'w+') as f:
             try:
@@ -210,6 +212,16 @@ class GalaxyRole(object):
                 if not role_data:
                     raise AnsibleError("- sorry, %s was not found on %s." % (self.src, api.api_server))
 
+                if role_data.get('role_type') == 'CON':
+                    # Container Enabled
+                    display.warning("%s is a Container Enabled role and should only be installed using "
+                                    "Ansible Container" % self.name)
+
+                if role_data.get('role_type') == 'APP':
+                    # Container Role
+                    display.warning("%s is a Container App role and should only be installed using Ansible "
+                                    "Container" % self.name)
+
                 role_versions = api.fetch_role_related('versions', role_data['id'])
                 if not self.version:
                     # convert the version names to LooseVersion objects