Use atomic_move to put the file, rather than shelling out

Fixes #4321
reviewable/pr18780/r1
James Cammarata 11 years ago
parent 5bed67aa61
commit 18379701f0

@ -311,14 +311,7 @@ class ThreadedTCPRequestHandler(SocketServer.BaseRequestHandler):
if final_path: if final_path:
log("moving %s to %s" % (out_path, final_path)) log("moving %s to %s" % (out_path, final_path))
args = ['sudo','cp',out_path,final_path] self.server.module.atomic_move(out_path, final_path)
rc, stdout, stderr = self.server.module.run_command(args, close_fds=True)
if rc != 0:
return dict(failed=True, stdout="failed to copy the file into position with sudo")
args = ['sudo','chown',final_user,out_path,final_path]
rc, stdout, stderr = self.server.module.run_command(args, close_fds=True)
if rc != 0:
return dict(failed=True, stdout="failed to chown the file via sudo")
return dict() return dict()
def daemonize(module, password, port, minutes): def daemonize(module, password, port, minutes):

Loading…
Cancel
Save