Fix enable_snat parameter (#44418) (#44451)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b7139782cf)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b7139782cf)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b7139782cf)

changelogs/fragments/fix-os_router.yaml

@@ -0,0 +1,3 @@
+bugfixes:
+    - fix the enable_snat parameter that is only supposed to be used by an user
+      with the right policies. https://github.com/ansible/ansible/pull/44418

lib/ansible/modules/cloud/openstack/os_router.py

@@ -42,7 +42,7 @@ options:
      description:
         - Enable Source NAT (SNAT) attribute.
      required: false
-     default: true
+     type: bool
    network:
      description:
         - Unique name or ID of the external gateway network.
@@ -317,6 +317,7 @@ def _build_kwargs(cloud, module, router, network):
     if network:
         kwargs['ext_gateway_net_id'] = network['id']
         # can't send enable_snat unless we have a network
+        if module.params['enable_snat']:
             kwargs['enable_snat'] = module.params['enable_snat']
 
     if module.params['external_fixed_ips']:
@@ -381,7 +382,7 @@ def main():
         state=dict(default='present', choices=['absent', 'present']),
         name=dict(required=True),
         admin_state_up=dict(type='bool', default=True),
-        enable_snat=dict(type='bool', default=True),
+        enable_snat=dict(type='bool'),
         network=dict(default=None),
         interfaces=dict(type='list', default=None),
         external_fixed_ips=dict(type='list', default=None),