Merge pull request #14755 from bcoca/pause_nohup_fix

avoid issues when stdin is a closed file

lib/ansible/plugins/action/pause.py

@@ -120,23 +120,29 @@ class ActionModule(ActionBase):
 
             # save the attributes on the existing (duped) stdin so
             # that we can restore them later after we set raw mode
-            fd = self._connection._new_stdin.fileno()
+            fd = None
-            if isatty(fd):
+            try:
-                old_settings = termios.tcgetattr(fd)
+                fd = self._connection._new_stdin.fileno()
-                tty.setraw(fd)
+            except ValueError:
-
+                # someone is using a closed file descriptor as stdin
-                # flush the buffer to make sure no previous key presses
+                pass
-                # are read in below
+            if fd is not None:
-                termios.tcflush(self._connection._new_stdin, termios.TCIFLUSH)
+                if isatty(fd):
-
+                    old_settings = termios.tcgetattr(fd)
+                    tty.setraw(fd)
+
+                    # flush the buffer to make sure no previous key presses
+                    # are read in below
+                    termios.tcflush(self._connection._new_stdin, termios.TCIFLUSH)
             while True:
                 try:
-                    key_pressed = self._connection._new_stdin.read(1)
+                    if fd is not None:
-                    if key_pressed == '\x03':
+                        key_pressed = self._connection._new_stdin.read(1)
-                        raise KeyboardInterrupt
+                        if key_pressed == '\x03':
+                            raise KeyboardInterrupt
 
                     if not seconds:
-                        if not isatty(fd):
+                        if fd is None or not isatty(fd):
                             display.warning("Not waiting from prompt as stdin is not interactive")
                             break
                         # read key presses and act accordingly
@@ -154,6 +160,7 @@ class ActionModule(ActionBase):
                     else:
                         raise AnsibleError('user requested abort!')
 
+
         except AnsibleTimeoutExceeded:
             # this is the exception we expect when the alarm signal
             # fires, so we simply ignore it to move into the cleanup