archive
/
ansible
mirror of https://github.com/ansible/ansible.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Test state.tasks_child_state before dereferencing

Browse Source 
I hit a traceback in the FAILED_TASKS case, but it seemed prudent to add
guards in the other similar branches.
pull/12328/head
Abhijit Menon-Sen 9 years ago
parent df89f03627
commit 049a48f3d3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File

6
lib/ansible/executor/play_iterator.py
Unescape Escape View File

@ -237,7 +237,7 @@ class PlayIterator:
if task is None: if task is None:
# check to see if the child state was failed, if so we need to # check to see if the child state was failed, if so we need to
# fail here too so we don't continue iterating tasks # fail here too so we don't continue iterating tasks
if state.tasks_child_state.fail_state != self.FAILED_NONE: if state.tasks_child_state and state.tasks_child_state.fail_state != self.FAILED_NONE:
state.fail_state |= self.FAILED_TASKS state.fail_state |= self.FAILED_TASKS
state.tasks_child_state = None state.tasks_child_state = None
state.cur_regular_task += 1 state.cur_regular_task += 1
@ -263,7 +263,7 @@ class PlayIterator:
if task is None: if task is None:
# check to see if the child state was failed, if so we need to # check to see if the child state was failed, if so we need to
# fail here too so we don't continue iterating rescue # fail here too so we don't continue iterating rescue
if state.tasks_child_state.fail_state != self.FAILED_NONE: if state.tasks_child_state and state.tasks_child_state.fail_state != self.FAILED_NONE:
state.fail_state |= self.FAILED_RESCUE state.fail_state |= self.FAILED_RESCUE
state.rescue_child_state = None state.rescue_child_state = None
state.cur_rescue_task += 1 state.cur_rescue_task += 1
@ -293,7 +293,7 @@ class PlayIterator:
if task is None: if task is None:
# check to see if the child state was failed, if so we need to # check to see if the child state was failed, if so we need to
# fail here too so we don't continue iterating always # fail here too so we don't continue iterating always
if state.tasks_child_state.fail_state != self.FAILED_NONE: if state.tasks_child_state and state.tasks_child_state.fail_state != self.FAILED_NONE:
state.fail_state |= self.FAILED_ALWAYS state.fail_state |= self.FAILED_ALWAYS
state.always_child_state = None state.always_child_state = None
state.cur_always_task += 1 state.cur_always_task += 1

Write Preview
Loading…
Cancel
Save