Commit Graph

280 Commits (fda3ad39c8d89b07d4ead691bacdca6865e46517)

Author SHA1 Message Date
Andrew Dolgov 4508e3103d some more eslint-related stuff 6 years ago
Andrew Dolgov 8572e0108a declare globals with let 6 years ago
Andrew Dolgov 424e28db6b eslint-related fixes 6 years ago
Andrew Dolgov e35a46733f hlClicked: do not set headline selected when ctrl-clicking 7 years ago
wn_ a972ab45bd strict js: various var fixes 7 years ago
wn_ a30f862de4 strict js: fix catchupBatchedArticles
This addresses the "Unread not removed from row" issue.
7 years ago
wn_ ad04bbf81d strict js: fix more dialog vars 7 years ago
Andrew Dolgov 3009ecc44f initial for JS strict mode 7 years ago
Andrew Dolgov 8f92a67e6f some (very minor) code cleanup in feeds class 7 years ago
wn_ b5fc9781ad Don't display label context menu items if there are no labels.
Caused by: 5e78b0c253
See: https://discourse.tt-rss.org/t/label-options-sometimes-not-showing-in-context-menu/366
7 years ago
Andrew Dolgov 22adcd7466 request counters less times during startup, delay initial request in feedlist_init() a bit 7 years ago
Andrew Dolgov 5e78b0c253 do not base headlines label context submenu on feed tree labels category 7 years ago
Andrew Dolgov 337535416f filter by search results while marking feed as read 8 years ago
Andrew Dolgov 63f0ed3d9c cdmClicked: do not use event.target.parents to figure out if clicked on a heading 8 years ago
Andrew Dolgov 1bfe1d7b31 simplify error handling
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
8 years ago
Andrew Dolgov b835a52814 rework the way headlines menus identify calling row 8 years ago
Andrew Dolgov 5161460048 bind headlines menu to a selector to avoid remaking it unnecessarily 8 years ago
Andrew Dolgov 20deb5fc32 cdmcollapse/expand: use less convoluted selector queries 8 years ago
Andrew Dolgov 829d478f1b add some protection against opener attacks if external site is opened via window.open() 8 years ago
Andrew Dolgov ad326dbf78 unpackVisibleHeadlines: do not iterate over all RROWs all the time 8 years ago
Andrew Dolgov 3bc1b53772 initHeadlinesMenu: remove unneeded output 8 years ago
Andrew Dolgov 974c6eb523 attach headline menu objects to correct DOM nodes in combined mode 8 years ago
Andrew Dolgov e1f7b05b52 reuse menu objects while appending headline rows 8 years ago
Anders Kaseorg 88946d331a Replace all setTimeout strings with functions
This fixes a cross-site scripting vulnerability.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8 years ago
Andrew Dolgov b6b5554db4 normalize some html5 custom attributes 9 years ago
Andrew Dolgov 2d052e42b5 getLoadedArticleIds: consider visible rows only
catchupFeedInGroup: hide articles when catching up, with caveats
9 years ago
Andrew Dolgov 6be118fda1 showArticleInHeadlines: remove unused code 9 years ago
Andrew Dolgov c4e211046e updateFloatingMenu: performance improvements 9 years ago
Andrew Dolgov d7cc5e6cdd fix previous 9 years ago
Andrew Dolgov 63c7446a79 headlines scroll handler: add a rate limit 9 years ago
Andrew Dolgov 7c0d68f207 remove dismiss* functions 9 years ago
Andrew Dolgov 6056d164fa cleanup dismissArticle functions 9 years ago
Kostiantyn Moroz 2757c49387 Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode) 9 years ago
Andrew Dolgov 0b41bd3414 add some hacks to hopefully mitigate headlines memory leaks 9 years ago
Andrew Dolgov a71e571b97 headlines_callback2: force prevent duplicate row ids 9 years ago
Andrew Dolgov a0dbc45acd add edit feed to feed header context menu in grouped mode 9 years ago
Andrew Dolgov 6b0a17ad8b viewfeed: switch to hash-based arguments
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
9 years ago
Andrew Dolgov 6810a1de42 use dijit form widget for attachments dropdown 9 years ago
Andrew Dolgov 176a489e54 use batch-based catching up in cdmExpandArticle() to reduce server load 9 years ago
Andrew Dolgov eaec06f950 prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
a bunch of other related fixes
9 years ago
Andrew Dolgov 95b493d68d partially revert previous because of navigation breakage in expanded mode, durrr 9 years ago
Andrew Dolgov b71add41d5 unfuck catchupbatchedarticles a bit 9 years ago
Andrew Dolgov 8292123ebc assorted fixes for keyboard navigation which hopefully don't break everything else 9 years ago
Andrew Dolgov 231c672c5d fix previous 9 years ago
Andrew Dolgov 837443630f infscroll: preload articles a bit earlier 9 years ago
Andrew Dolgov d8e8e24e34 pass DOMNodes instead of escaped html data to JS article rendered hooks (i think this makes much more sense) 9 years ago
Andrew Dolgov 8691b32abf disable headline appear animation 9 years ago
Andrew Dolgov d46af5a5cf headlines scroll handler: make preloading less aggressive 9 years ago
Andrew Dolgov e7a66d1230 (experimental) disable infscroll requests while marking auto catched up articles as read 9 years ago
Andrew Dolgov 33c4bd8968 fix error feed (i.e. when requested feed no longer exists) not display properly 9 years ago
Andrew Dolgov f17069960c roll back separate headline transport 9 years ago
Andrew Dolgov 57c521df91 maybe speedup headline adding a bit, maybe not 9 years ago
Andrew Dolgov 9ef1985f1b viewfeed.js: cleanup the code a bit 9 years ago
Andrew Dolgov ac4c1383ae bring cdmFeedTitle style in line with the rest of the UI
send headline rows as separate JSON objects
9 years ago
Andrew Dolgov 48fefe2f6b fixes for first_id stuff 9 years ago
Andrew Dolgov 39d488a256 viewfeed: set hsp status when scrolling to the very end 9 years ago
Andrew Dolgov 15ae8cd084 js: remove current_top_id global 9 years ago
Andrew Dolgov 3444020100 report top id changed in headlines buffer 9 years ago
Andrew Dolgov f5a0fb8b64 queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating 9 years ago
Andrew Dolgov 5a45821ec9 prevent event propagation when clicking on CDM article footer 9 years ago
Andrew Dolgov a72cd54ce1 bayes: properly reset score when going good -> ugly
article: add helper to refresh article score pic, properly set scorepic title
9 years ago
Anders Kaseorg 5c145bde7a Make the floating title transition smoother
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting.  Now it
appears at the point when its bottom lines up with the real title’s
bottom.  This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.

We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden.  It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.

Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
10 years ago
Andrew Dolgov 760183e37d minor spacer/whiteBox appearance tweaks 10 years ago
Andrew Dolgov 1d6191ee0a always create headline-spacer on lazy load 10 years ago
Andrew Dolgov 74217c72a1 adjust scroll amount to trigger auto-opening next unread feed 10 years ago
Andrew Dolgov 22f675e5c4 add a link to headlines-spacer to open next unread feed 10 years ago
Andrew Dolgov 0f85f483e5 another implementation of pull 386 (show next when finished reading) (2) 10 years ago
Andrew Dolgov b7c20a3759 another implementation of pull 386 (show next when finished reading) 10 years ago
Andrew Dolgov 6472dd11a2 Revert "scroll to end to show next feed or category"
This reverts commit 86f32020f6.
10 years ago
wolle 86f32020f6 scroll to end to show next feed or category
only if cmd_auto_catchup and on_catchup_show_next_feed set
10 years ago
Andrew Dolgov bace5e9e6f prevent cdmClicked ctrl-click handler working on article body 11 years ago
Andrew Dolgov df63125dd7 handle_rpc_json: do not crash if net-alert is somehow unavailable 11 years ago
Andrew Dolgov 1bffd1068f unify main and headlines toolbar 11 years ago
Andrew Dolgov b8fd08d6db do not unpack all visible headlines in collapsed mode because those are unpacked on expand 11 years ago
Andrew Dolgov 24940c3dc9 catchup group: deselect everything before processing 11 years ago
Andrew Dolgov 87065739cd add context menu for cdmFeedTitle; change mark as read prompt for grouped headlines more clear 11 years ago
Andrew Dolgov 2e35b3bd6b prevent automatic selection of headlines row first child when scrolling in 3panel mode because it screws with keyboard navigation (closes #752) 11 years ago
Andrew Dolgov 95be6e0c89 fix second row being selected on viewfeed (closes #748) 11 years ago
Andrew Dolgov 00fe7886b6 update floating title unread status when auto catching up 11 years ago
Andrew Dolgov 41d37fb2c3 add experimental hack to show row unread status in floating title 11 years ago
Andrew Dolgov 0971cc619d remove dijit checkbox element from floatingTitle 11 years ago
Andrew Dolgov 65f0eb01aa support headlines context menu in floating title 11 years ago
Andrew Dolgov 7415fcf212 enable floating title for expandable combined mode, minor expandable mode fixes 11 years ago
Andrew Dolgov 301a09dc55 fix floating title sometimes obscuring next article title 11 years ago
Andrew Dolgov d095f42fa4 floating title: remove cdm auto catchup id hack for the time being 11 years ago
Andrew Dolgov 8ee5e9e5e6 rework floatingtitle 11 years ago
Andrew Dolgov 03304fda54 if multiple articles are selected, do not reset active article / selection on scroll if auto catchup is enabled 11 years ago
Andrew Dolgov 4f62f8f6dc add js hook for floating title 11 years ago
Veit Lehmann d1754390cc only do article update operations once when scrolling
I discovered that DOM operations and function calls were done several times inside the 100px mirror when scrolling through articles. Especially painful on seamless scrolling systems like Mac OS, where dozens of updates would slow down this part dramatically. This change fixes it.
11 years ago
Andrew Dolgov d1343b844d make floating title less cpu intensive 11 years ago
Jeffrey Tolar 3b2605a02e Add some checks to see if the content element exists
This *might* help dismissal not break when not using combined mode.
11 years ago
Jeffrey Tolar 055a37e083 Fix incorrect function name in exception handling 11 years ago
Jeffrey Tolar abba5dd4d4 Remove content when an article is dismissed 11 years ago
Veit Lehmann 5313ae17e4 only update floatingTitle innerHTML if active article changes
This will boost scrolling performance pretty much and avoid flickering of floatingTitle
11 years ago
Andrew Dolgov 5f9699a53f hide floatingTitle when first batch of headlines is received 11 years ago
Andrew Dolgov 19b906b94b block automarking headlines on scroll in unexpanded cdm because it doesn't work so well 11 years ago
Andrew Dolgov 08820be70b add experimental floating title when scrolling long articles in combined mode 11 years ago
Andrew Dolgov 1ffd534f43 fix wrong article context menu item toggle marked (should be toggle starred) 12 years ago
Andrew Dolgov 2a7362596f moveToPost: check for current article element existing before getting its position info (closes #695) 12 years ago
Andrew Dolgov 6e098e5e8c enlarge auto mark offset height 12 years ago