Andrew Dolgov
ff708a9357
prefs: initial objectification
6 years ago
Andrew Dolgov
b9984c0ed6
revert wrong changes in prefs.js
6 years ago
Andrew Dolgov
18868fb7ac
remove counters_last_request from globals
6 years ago
Andrew Dolgov
97df81d8d9
even more objectification of JS
6 years ago
Andrew Dolgov
1d82bd4f19
further objectification
6 years ago
Andrew Dolgov
072c03fbac
cdmClicked: backport master change to click on links
6 years ago
Andrew Dolgov
00cd4a48d4
Feeds -> this
6 years ago
Andrew Dolgov
d86ddbc635
further objectification of JS code
6 years ago
Andrew Dolgov
049a37aa0e
WIP reshuffling of JS global context into separate logical objects
6 years ago
Andrew Dolgov
4dbbd45caf
enable floating title in unexpanded mode
6 years ago
Andrew Dolgov
468faee635
viewfeed: remove (tons of) obsolete code
6 years ago
Andrew Dolgov
069ecb6c2e
viewfeed: catchup batched articles before opening next feed
6 years ago
Andrew Dolgov
710d06a288
catchup batching:
...
* behave better if invoked during an infinite scroll request
* flush catchup batch when article is selected manually
6 years ago
Andrew Dolgov
195180b64d
minor refactoring: normalize some function names; cleanup; etc
6 years ago
Andrew Dolgov
e720e6b628
remove infobox_callback2
6 years ago
Andrew Dolgov
c151607b91
unpackVisibleHeadlines: increase lookahead distance
6 years ago
Andrew Dolgov
b87b4287b7
scroll handler: fix loadMoreHeadlines() not being called
6 years ago
Andrew Dolgov
523e1cb9e8
reduce headlines scrolling timeout
6 years ago
Andrew Dolgov
e84adbba37
rate-limit headlinesScrollHandler via timeout instead of distance scrolled
...
minor floating title cleanup
6 years ago
Andrew Dolgov
efd28bb3b7
add ngettext to globals
6 years ago
Andrew Dolgov
669077c6ad
refactor selection toggle functions; other minor cleanup
6 years ago
Andrew Dolgov
a2ef54cd92
toggleMark, togglePub: refactor implementation
...
shorten marked/published img CSS classes
6 years ago
Andrew Dolgov
3325979bf0
isCdmMode -> isCombinedMode
6 years ago
Andrew Dolgov
32d36d439c
in unexpanded mode unpack article only when activated
6 years ago
Andrew Dolgov
8971b920ce
getSelectedArticleIds2: return unique ids
...
setActiveArticleId: update selected prompt
6 years ago
Andrew Dolgov
c155a9e1ef
toggle_cdm_expanded: use xhrPost
6 years ago
Andrew Dolgov
5aa9c60494
bring back (debloated) version of unexpanded combined mode
6 years ago
Andrew Dolgov
1702ecf7ea
cdmClicked: when clicked on article link, open it in background window even without ctrl
6 years ago
Andrew Dolgov
e2b8c9273e
first stage of headline element handling refactoring
6 years ago
Andrew Dolgov
c1ee7035e6
</hurr>
6 years ago
Andrew Dolgov
137bc3b3db
cdmScrollToArticle: set id as active if selected
6 years ago
Andrew Dolgov
08bee97858
cdmScrollToArticle: set article read on selection
6 years ago
Andrew Dolgov
ebc09be79d
moveToPost: set unread to false when article is selected
6 years ago
Andrew Dolgov
8359ca6dad
combined mode (and more) css class name updates
6 years ago
Andrew Dolgov
2f961ee830
plugins: add some xhrPost refactoring
6 years ago
Andrew Dolgov
764434a491
remove remove_splash()
6 years ago
Andrew Dolgov
02ec3984bd
replace 4 space indents with tabs
6 years ago
Andrew Dolgov
59f5335f56
unpackVisibleHeadlines: go ahead of the buffer position a bit (2)
6 years ago
Andrew Dolgov
58dee80ae5
unpackVisibleHeadlines: go ahead of the buffer position a bit
6 years ago
Andrew Dolgov
0c06bb5fe1
scroll handler: performance improvements
6 years ago
Andrew Dolgov
b9585004e6
packed headlines: no point in using JSON here
6 years ago
Andrew Dolgov
9563e3bcd6
remove expandable CDM headlines
6 years ago
Andrew Dolgov
c8c9a26f30
move to simpler CDM handling of encoded content (instead of CENCW... etc)
6 years ago
Andrew Dolgov
da1a3c2cc5
remove ok = confirm() thing
6 years ago
Andrew Dolgov
fd752a79af
finish xhrPost migration of js/
6 years ago
Andrew Dolgov
7e8be97b66
remove duplicated code from hotkey actions handler
...
more xhrPost() refactoring
6 years ago
Andrew Dolgov
24c618dd6f
editSelectedFeeds: fix missing unset checkboxes properly
6 years ago
Andrew Dolgov
ef129fed2a
some more xhrPost refactoring (batchEditSave WIP)
6 years ago
Andrew Dolgov
fc0a3050eb
use xhrPost is even more places!
6 years ago
Andrew Dolgov
eaf7cfdba6
use xhrPost in even more places!
6 years ago
Andrew Dolgov
560b9fdd26
use xhrPost in more places
6 years ago
Andrew Dolgov
0d27227359
use xhrPost in more places; various minor cleanup
6 years ago
Andrew Dolgov
0267212454
move to let/const syntax in custom dojo modules
6 years ago
Andrew Dolgov
9dc5524df1
set dialogs to const
6 years ago
Andrew Dolgov
1b91bb4564
don't compare result with undefined seq
6 years ago
Andrew Dolgov
4508e3103d
some more eslint-related stuff
6 years ago
Andrew Dolgov
8572e0108a
declare globals with let
6 years ago
Andrew Dolgov
424e28db6b
eslint-related fixes
6 years ago
Andrew Dolgov
a3e2f1a9c3
define custom dojo modules with define() instead of require(), update startup module dependencies
6 years ago
Andrew Dolgov
e35a46733f
hlClicked: do not set headline selected when ctrl-clicking
7 years ago
Andrew Dolgov
fa2e3b235a
addLabel: remove unused active_tab
7 years ago
Andrew Dolgov
d195c6a62e
gotoExportOpml: js strict mode fix
7 years ago
wn_
a972ab45bd
strict js: various var fixes
7 years ago
Andrew Dolgov
ab688e963d
viewfeed: remove force_nocache (unused)
7 years ago
Andrew Dolgov
7560e54e39
switchPanelMode: strict-mode fix for article_id
7 years ago
wn_
30aa9743eb
strict js: fix subscribing when HTML with multiple feeds
...
also a minor fix for response handling in quickAddFilter
7 years ago
wn_
a30f862de4
strict js: fix catchupBatchedArticles
...
This addresses the "Unread not removed from row" issue.
7 years ago
wn_
ad04bbf81d
strict js: fix more dialog vars
7 years ago
wn_
97f084c828
strict js: fix helpDialog
7 years ago
Andrew Dolgov
3009ecc44f
initial for JS strict mode
7 years ago
Andrew Dolgov
f6269d1bc4
add special class for feeds with disabled updates
7 years ago
Andrew Dolgov
44eda8521e
filter delete action/rule: fix selector syntax
7 years ago
Andrew Dolgov
0518510814
remove some obsolete stuff, fix minor issues found by code analyzer
7 years ago
Andrew Dolgov
8f92a67e6f
some (very minor) code cleanup in feeds class
7 years ago
Andrew Dolgov
fa3bcfa379
queryfeedheadlines: there's no need to quote order_by/override_order
...
else: feedicon cache busting etc
7 years ago
Andrew Dolgov
7c0eb1b621
add defaultPasswordWarning nag dialog
7 years ago
Andrew Dolgov
b5bf9a0ff3
remove long forgotten stuff related to feed debugging actionbar
7 years ago
Andrew Dolgov
fbe7cb0a48
rpc: switch to PDO
7 years ago
Andrew Dolgov
03c56b041f
force-request counters on load once if bw_limit option is enabled (because there's no timeout())
7 years ago
wn_
b5fc9781ad
Don't display label context menu items if there are no labels.
...
Caused by: 5e78b0c253
See: https://discourse.tt-rss.org/t/label-options-sometimes-not-showing-in-context-menu/366
7 years ago
Andrew Dolgov
22adcd7466
request counters less times during startup, delay initial request in feedlist_init() a bit
7 years ago
Andrew Dolgov
5e78b0c253
do not base headlines label context submenu on feed tree labels category
7 years ago
Andrew Dolgov
267bcee32c
quickAddFeed: fix legacy feed_id type being passed to newrule
7 years ago
Andrew Dolgov
12b7b90c70
prefs: reload after OPML import
7 years ago
wn_
b3e3cb06d9
Show a blank icon in PrefFeedTree if there is no favicon for a feed.
...
Duplicates behavior of FeedTree.
Prevents a broken request to 'false' if a feed doesn't have a favicon.
8 years ago
Andrew Dolgov
5b6ea1ef91
remove pubsubhubbub: dead
8 years ago
Andrew Dolgov
7590f03961
feedtree.selectFeed: focus headlines-frame after selection
8 years ago
Andrew Dolgov
46b433933e
hotkey_handler: one more tiny tweak
8 years ago
Andrew Dolgov
a97e8cddf7
hotkey_handler: cleanup things a bit
8 years ago
Andrew Dolgov
0ae7de6d91
hotkey_handler: return true on prefix handled
8 years ago
Andrew Dolgov
fa1be041c2
feedtree, selectFeed: focus selected node
8 years ago
Andrew Dolgov
0a79531696
hotkey_handler: stop propagation of handled prefix/action events
8 years ago
Andrew Dolgov
337535416f
filter by search results while marking feed as read
8 years ago
Andrew Dolgov
63f0ed3d9c
cdmClicked: do not use event.target.parents to figure out if clicked on a heading
8 years ago
Andrew Dolgov
270c0a00e5
improve JS error logging with additional stuff
8 years ago
Andrew Dolgov
e0a957b3f6
use try/catch block in updatefeedlist
...
remove reporting function from exception dialog
8 years ago
Andrew Dolgov
1bfe1d7b31
simplify error handling
...
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
8 years ago
Andrew Dolgov
b835a52814
rework the way headlines menus identify calling row
8 years ago
Andrew Dolgov
ad7cea62e1
editFilter: fix selector expressions broken by 88946d3
8 years ago
Andrew Dolgov
79ec2f3efd
set error report url to https
8 years ago
Andrew Dolgov
5161460048
bind headlines menu to a selector to avoid remaking it unnecessarily
8 years ago
Andrew Dolgov
20deb5fc32
cdmcollapse/expand: use less convoluted selector queries
8 years ago
Andrew Dolgov
70c0a8c2e0
pass several image files used in notify messages to frontend as base64 to prevent broken error messages in case network connection is down. also, update some close buttons to show correct cursor.
8 years ago
Andrew Dolgov
3188e863b3
handle_rpc_json: fix netalert button never appearing on JSON parse error
8 years ago
Andrew Dolgov
829d478f1b
add some protection against opener attacks if external site is opened via window.open()
8 years ago
Andrew Dolgov
23c8ef7e36
parse_counters: skip subscribed-feeds id properly
8 years ago
Andrew Dolgov
6358d70d5e
reset local counter cache when feed count changes
8 years ago
Andrew Dolgov
24c7e4132d
subscribe dialog: do not report errors via alert()
...
fetch_file_contents: reset all globals on start, return error message body when not using curl
subscribe_to_feed: report if cloudflare is in the error message
8 years ago
Andrew Dolgov
ad326dbf78
unpackVisibleHeadlines: do not iterate over all RROWs all the time
8 years ago
Andrew Dolgov
70c5b2bfcc
feed tree: only run animation for appearing unread counters to prevent clashes with aux counter updating and animations ending up in wrong state
8 years ago
Andrew Dolgov
3bc1b53772
initHeadlinesMenu: remove unneeded output
8 years ago
Andrew Dolgov
974c6eb523
attach headline menu objects to correct DOM nodes in combined mode
8 years ago
Andrew Dolgov
d5f74019ac
parse_counters: cache previous reply and skip processing of unchanged rows (better implementation)
8 years ago
Andrew Dolgov
a4e04c498f
parse_counters: cache previous reply and skip processing of unchanged rows
8 years ago
Andrew Dolgov
e1f7b05b52
reuse menu objects while appending headline rows
8 years ago
Andrew Dolgov
b1a80693b1
collapse_feedlist: also toggle splitter
8 years ago
Anders Kaseorg
88946d331a
Replace all setTimeout strings with functions
...
This fixes a cross-site scripting vulnerability.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8 years ago
Andrew Dolgov
b7d63a58db
fix loading indicator position/size for tree leafs
8 years ago
Andrew Dolgov
7fbc10c236
force-enable persist for feedTree
8 years ago
Andrew Dolgov
e2e2479984
Merge branch 'dojo-1.12.1'
...
Conflicts:
js/prefs.js
8 years ago
Andrew Dolgov
ab235fc5f1
prefs: add updateSelectedPrompt shim called by toggleSelectedRow()
8 years ago
Andrew Dolgov
1c4f5e8390
add dependency on dojo/_base/html
8 years ago
Anders Kaseorg
6887a0f573
lib: Upgrade Dojo and Dijit from 1.8.3 to 1.12.1
...
The itemNode and expandoNode elements have changed from img to
span (https://bugs.dojotoolkit.org/ticket/16699 ), so we now put our
tree icons inside them rather than replacing them.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8 years ago
Anders Kaseorg
9f539be3c2
Replace deprecated dojo.place with domConstruct.place
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8 years ago
Andrew Dolgov
6293d3717c
add toggle_sidebar plugin, remove obsolete toggle button
...
add PluginHost::HOOK_MAIN_TOOLBAR_BUTTON
8 years ago
Andrew Dolgov
f04b12d8e7
category: swap context menu items
8 years ago
Andrew Dolgov
acfee412a3
feed tree: add category context menu entry to un/collapse it
8 years ago
Andrew Dolgov
d39a2f8005
switch modules to new dojo definition format
8 years ago
Andrew Dolgov
546b419f52
catch plugin JS errors
8 years ago
Andrew Dolgov
fd539f2800
prefs: use dojo asynchronously
8 years ago
Andrew Dolgov
0dbc20a8d4
load dijit properly, duh
8 years ago
Andrew Dolgov
ee5170424e
dojo: main UI: load stuff asynchronously
8 years ago
Andrew Dolgov
64c24ecb59
add hotkey for toggling VFEED_GROUP_BY_FEED preference
8 years ago
Andrew Dolgov
b6b5554db4
normalize some html5 custom attributes
9 years ago
Andrew Dolgov
2d052e42b5
getLoadedArticleIds: consider visible rows only
...
catchupFeedInGroup: hide articles when catching up, with caveats
9 years ago
Andrew Dolgov
6be118fda1
showArticleInHeadlines: remove unused code
9 years ago
Andrew Dolgov
c4e211046e
updateFloatingMenu: performance improvements
9 years ago
Andrew Dolgov
d7cc5e6cdd
fix previous
9 years ago
Andrew Dolgov
63c7446a79
headlines scroll handler: add a rate limit
9 years ago
Andrew Dolgov
7c0d68f207
remove dismiss* functions
9 years ago
Andrew Dolgov
a51bc3dfa5
catchupfeedingroup: do not remove elements
9 years ago
Andrew Dolgov
6056d164fa
cleanup dismissArticle functions
9 years ago
Andrew Dolgov
11514d576f
catchupFeedInGroup: dismiss elements on catchup
9 years ago
Andrew Dolgov
dfaf806a7a
catchupFeedInGroup: send catchup request even if there are no unread articles in the buffer for this feed
9 years ago
Andrew Dolgov
701de97ebb
improvements for catchupFeedInGroup()
9 years ago
Kostiantyn Moroz
2757c49387
Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode)
9 years ago
Andrew Dolgov
0b41bd3414
add some hacks to hopefully mitigate headlines memory leaks
9 years ago
Andrew Dolgov
9842b51c71
getfeedname: fix for non-numeric feeds (tags)
9 years ago
Andrew Dolgov
89bea945ce
filters: add to previous on JS side
9 years ago
Andrew Dolgov
d38cd41253
loadMoreHeadlines: use correct offsets for starred vfeed in adaptive mode
9 years ago
Andrew Dolgov
a71e571b97
headlines_callback2: force prevent duplicate row ids
9 years ago
Andrew Dolgov
f48f292d2b
tweak filter preview layout a bit; allow previewing matched articles in a popup
9 years ago
Andrew Dolgov
3857536f70
fix testing in create filter dialog, woops
9 years ago
Andrew Dolgov
261226a3a5
mostly implement async filter test dialog
9 years ago
Andrew Dolgov
a007c18dff
wip: filter async testing
9 years ago
Andrew Dolgov
a0dbc45acd
add edit feed to feed header context menu in grouped mode
9 years ago
Andrew Dolgov
b717c65e4e
update previous
9 years ago
Andrew Dolgov
791877c39d
fix catching up for grouped feeds
9 years ago
Andrew Dolgov
e17079dcef
make disabled filter rules easier to discern
...
show if filter set match_any_rule on the overview
9 years ago
Andrew Dolgov
dcbe36b2a2
fix some remaining old-style viewfeed() calls
9 years ago
Andrew Dolgov
9109e171ee
feedtree: don't hide feeds with errors
9 years ago
Andrew Dolgov
bf9cc9ad95
combine user edit & user details
9 years ago
Andrew Dolgov
f9c1f8b0d4
pref-feeds: check for inactive feeds asynchronously
9 years ago
Andrew Dolgov
6b0a17ad8b
viewfeed: switch to hash-based arguments
...
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
9 years ago
Andrew Dolgov
b87744534a
add plugin-based filter actions (see example plugin in attic)
...
bump schema
9 years ago
Andrew Dolgov
6810a1de42
use dijit form widget for attachments dropdown
9 years ago
Andrew Dolgov
176a489e54
use batch-based catching up in cdmExpandArticle() to reduce server load
9 years ago
Andrew Dolgov
eaec06f950
prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
...
a bunch of other related fixes
9 years ago
Andrew Dolgov
95b493d68d
partially revert previous because of navigation breakage in expanded mode, durrr
9 years ago
Andrew Dolgov
b71add41d5
unfuck catchupbatchedarticles a bit
9 years ago
Andrew Dolgov
8292123ebc
assorted fixes for keyboard navigation which hopefully don't break everything else
9 years ago
Andrew Dolgov
231c672c5d
fix previous
9 years ago
Andrew Dolgov
837443630f
infscroll: preload articles a bit earlier
9 years ago
Andrew Dolgov
d8e8e24e34
pass DOMNodes instead of escaped html data to JS article rendered hooks (i think this makes much more sense)
9 years ago
Andrew Dolgov
8691b32abf
disable headline appear animation
9 years ago
Andrew Dolgov
d46af5a5cf
headlines scroll handler: make preloading less aggressive
9 years ago
Andrew Dolgov
e7a66d1230
(experimental) disable infscroll requests while marking auto catched up articles as read
9 years ago
Andrew Dolgov
33c4bd8968
fix error feed (i.e. when requested feed no longer exists) not display properly
9 years ago
Andrew Dolgov
f17069960c
roll back separate headline transport
9 years ago
Andrew Dolgov
57c521df91
maybe speedup headline adding a bit, maybe not
9 years ago
Andrew Dolgov
9ef1985f1b
viewfeed.js: cleanup the code a bit
9 years ago
Andrew Dolgov
ac4c1383ae
bring cdmFeedTitle style in line with the rest of the UI
...
send headline rows as separate JSON objects
9 years ago
Andrew Dolgov
48fefe2f6b
fixes for first_id stuff
9 years ago
Andrew Dolgov
39d488a256
viewfeed: set hsp status when scrolling to the very end
9 years ago
Andrew Dolgov
15ae8cd084
js: remove current_top_id global
9 years ago
Andrew Dolgov
3444020100
report top id changed in headlines buffer
9 years ago
Andrew Dolgov
f5a0fb8b64
queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating
9 years ago
Andrew Dolgov
9090b874ab
simplify search, remove search_mode as useless
...
remove dialog to select by tags, simplify browsing by tag query
9 years ago
Andrew Dolgov
5a45821ec9
prevent event propagation when clicking on CDM article footer
10 years ago
Andrew Dolgov
a72cd54ce1
bayes: properly reset score when going good -> ugly
...
article: add helper to refresh article score pic, properly set scorepic title
10 years ago
Andrew Dolgov
86b05f8661
better feed debugger ui for f D
10 years ago
Andrew Dolgov
415a3b50c9
fix some minor typos and stuff
10 years ago
Andrew Dolgov
669fc881f3
add error notification if trying to toggle widescreen in cdm
10 years ago
Andrew Dolgov
40f147df79
feedtree: do not hide special category for reals if configured as such
10 years ago
Andrew Dolgov
119ba03bd4
minor fixes for previous
10 years ago
Andrew Dolgov
efcc5d365d
add placeholder update checker using git changesets
10 years ago
Andrew Dolgov
ed775e4e8d
remove obsolete code related to version checking and tarball updater plugin
10 years ago
Anders Kaseorg
5c145bde7a
Make the floating title transition smoother
...
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting. Now it
appears at the point when its bottom lines up with the real title’s
bottom. This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.
We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden. It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.
Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
10 years ago
Andrew Dolgov
0d41fd76d3
notify fixes
10 years ago
Andrew Dolgov
d9c93ebfdb
tweak notifications; use css animations for notifications
10 years ago