Commit Graph

59 Commits (d989fa63be52a656bcc86ea0f4d3922a14db5c44)

Author SHA1 Message Date
Michael Kuhn e38fcd6dea Fix button focus issues
This change introduces derived classes for ComboButton, DropDownButton
and Select that make sure that buttons do not remain focused after their
menus are closed. This allows using hotkeys after closing them.
5 years ago
Michael Kuhn 4a2a90c980 Fix focus issues with hotkeys
Since making use of keypress in addition to keydown, hotkeys did not
work in certain scenarios, including clicking on the feed tree expanders
or empty spaces of the toolbar.

This issue is caused by dijit.Tree and dijit.Toolbar implementing the
_KeyNavMixin, which explicitly stops propagation of keypress events.

This change contains two main fixes plus a smaller hotfix:
1. It overrides _onContainerKeydown and _onContainerKeypress for
   fox.FeedTree (which inherits from dijit.Tree).
2. It adds fox.Toolbar, which overrides _onContainerKeydown,
   _onContainerKeypress and focus. This fixes hotkeys being swallowed
   and the first focusable child receiving focus when clicking on an
   empty space of the toolbar.
3. It adds the same handling of keydown and keypress to the prefs hotkey
   handler as is done in the main hotkey handler.
5 years ago
Andrew Dolgov 16a9bdc387 make_password: generate longer passwords by default, use better random function if available 5 years ago
Andrew Dolgov ef6d2b8a4e update notifications to make them more visible
cleanup some minor stuff in pref-users
5 years ago
Andrew Dolgov 7724aa9b7c pref-users: fix typo which stopped search from working; quote style stuff 5 years ago
Andrew Dolgov 335147e572 dialogs: use semantic markup instead of dlgsec stuff
continue unifying quoting style for html strings
5 years ago
Andrew Dolgov 4d9141d762 simplify dlgSec-related markup 5 years ago
Andrew Dolgov c11f32ac38 center and rework some utility screens 5 years ago
Andrew Dolgov a68b150601 remove separate classes for various panels, unify under .panel
remove a few other unnecessary css classes/ids
6 years ago
Andrew Dolgov a0b1664620 prefs: change user icon 6 years ago
Andrew Dolgov cad6d1d7fd various icon updates; use new icons in feed tree 6 years ago
Andrew Dolgov 8c5c762a85 some more icon styling updates + user control panel 6 years ago
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 6 years ago
Andrew Dolgov b9869dbc01 prefs: remove some more stuff from global context (user management, etc) 6 years ago
Andrew Dolgov e23b6e397d prefs: store active tab for reload, remove most old table row functions 6 years ago
Andrew Dolgov 874560db54 remove obsolete row selection functions
move getUrlParam() to Utils
6 years ago
Andrew Dolgov a2ef54cd92 toggleMark, togglePub: refactor implementation
shorten marked/published img CSS classes
6 years ago
Andrew Dolgov 55bf4bc1d3 mailer: split to/from name/addresses 6 years ago
Andrew Dolgov 57932e1837 remove PHPMailer and related directives from config.php-dist; add pluggable Mailer class 6 years ago
Andrew Dolgov 3a0292303e php: remove trailing whitespaces 6 years ago
Andrew Dolgov 05e81655c3 user editor: add primary action 7 years ago
Andrew Dolgov e6532439d6 force strip_tags() on all user input unless explicitly allowed 7 years ago
Andrew Dolgov 2cf93c046c pref-users: fix sorting the table 7 years ago
Andrew Dolgov c2418a559b pref-users: PDO 7 years ago
Andrew Dolgov ea79a0e033 remove some redundant php closing tags 7 years ago
Andrew Dolgov 7b55001eee fix various issues reported by static analysis
update gitlab-ci config
7 years ago
Andrew Dolgov 328118d12e use print_hidden() for hidden dojo form fields 8 years ago
Andrew Dolgov a84fb943b4 pre-users: disallow renaming admin user 8 years ago
Andrew Dolgov bf9cc9ad95 combine user edit & user details 9 years ago
Andrew Dolgov f232aa5a34 remove num_articles from main pref_users query 9 years ago
Andrew Dolgov 1edff0d439 user manager: show stored feeds/articles 9 years ago
Andrew Dolgov b41c5741fe disable OTP on user password reset 10 years ago
Andrew Dolgov 2f20dd58d2 integrate silk icons by Mark James 11 years ago
Andrew Dolgov da8d534ac1 minor user editor updates 11 years ago
Andrew Dolgov d9afd9b2b5 use dojo stuff for user details 11 years ago
Andrew Dolgov 808ef3d4fc pref-users: remove useless javascript: prefix 11 years ago
Andrew Dolgov 222a61c222 user editor: use dojo stuff 11 years ago
Andrew Dolgov 610fe11535 add HOOK_PREFS_TAB_SECTION to user manager toolbar 11 years ago
Andrew Dolgov 0e72dbd79e Merge pull request #179 from nottwo/$link-cleanup
Remove obsolete $link parameter for password reset
11 years ago
Andrew Dolgov 8d090a910b use css nth-child instead of old even/odd class hacks for normal mode 11 years ago
Trannie Carter 233b74ad22 Remove obsolete $link parameter for password reset 11 years ago
Andrew Dolgov 1ffe3391f9 make pluginhost a singleton 11 years ago
Andrew Dolgov d9c85e0f11 classes: use OO DB interface 11 years ago
Andrew Dolgov a42c55f02b fix blank character after opening bracket in function calls 11 years ago
Andrew Dolgov 6322ac79a0 remove $link 11 years ago
Andrew Dolgov a5680acbe8 replace split with explode 11 years ago
Andrew Dolgov 977580a41c remove obsolete xml stuff in pref-users infoboxes 11 years ago
Andrew Dolgov 483f15d538 update utility.css related stuff some more 11 years ago
Andrew Dolgov c72069b098 pref_users: do not escape password to prevent special character
mishandling; remove inconsistent trimming of passwords
11 years ago
Tomas Chvatal 1844694351 gettext whitespace fix 11 years ago