Commit Graph

953 Commits (d4c925819b9d85a00520e413a90cfbcd61a1c667)

Author SHA1 Message Date
Andrew Dolgov 2411cc8d1c js: add PluginHost.HOOK_COUNTERS_RECEIVED 6 years ago
Andrew Dolgov 4b74491b8b feed tree: set placeholder feed unread value to -1 6 years ago
Michael Kuhn e38fcd6dea Fix button focus issues
This change introduces derived classes for ComboButton, DropDownButton
and Select that make sure that buttons do not remain focused after their
menus are closed. This allows using hotkeys after closing them.
6 years ago
Michael Kuhn 4a2a90c980 Fix focus issues with hotkeys
Since making use of keypress in addition to keydown, hotkeys did not
work in certain scenarios, including clicking on the feed tree expanders
or empty spaces of the toolbar.

This issue is caused by dijit.Tree and dijit.Toolbar implementing the
_KeyNavMixin, which explicitly stops propagation of keypress events.

This change contains two main fixes plus a smaller hotfix:
1. It overrides _onContainerKeydown and _onContainerKeypress for
   fox.FeedTree (which inherits from dijit.Tree).
2. It adds fox.Toolbar, which overrides _onContainerKeydown,
   _onContainerKeypress and focus. This fixes hotkeys being swallowed
   and the first focusable child receiving focus when clicking on an
   empty space of the toolbar.
3. It adds the same handling of keydown and keypress to the prefs hotkey
   handler as is done in the main hotkey handler.
6 years ago
ltGuillaume 4c72d3b4fc Add keyboard shortcut 'g r': Go to Recently read 6 years ago
Andrew Dolgov cc2ac3a86c FeedTree: add feed debugger to per-feed context menu 6 years ago
Andrew Dolgov b1bb7c6001 Merge branch 'master' of git.fakecake.org:tt-rss 6 years ago
Andrew Dolgov 019f4578bc fix feed icon upload not working, rework form to use FormData/ajax 6 years ago
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
6 years ago
Andrew Dolgov a34509c8ae Merge branch 'master' of git.fakecake.org:tt-rss 6 years ago
Andrew Dolgov 19f162dbe3 css: insensitive -> text-muted 6 years ago
Andrew Dolgov 900cdbbb31 Headlines.click: open original article (and mark as read) on alt click on title 6 years ago
Andrew Dolgov ae9ef7fe84 Headlines.click: fix another small issue with expanded mode (2) 6 years ago
Andrew Dolgov 0b8f3909fe Headlines.click: fix another small issue with expanded mode 6 years ago
Andrew Dolgov 84cf95fe8f Headlines.click: open original article when it makes sense to do so 6 years ago
Andrew Dolgov cf6f867feb getRange: handle start == stop 6 years ago
Andrew Dolgov d876cca22a tweak Headlines.click: ctrl-click toggles selection, shift-click selects range 6 years ago
Andrew Dolgov ef6d2b8a4e update notifications to make them more visible
cleanup some minor stuff in pref-users
6 years ago
Andrew Dolgov 70c53257d9 on_catchup_show_next: remove auto-trigger on headlines scroll 6 years ago
Andrew Dolgov 4db13b8a17 simplify preference layout, remove some unnecessary css classes 6 years ago
Andrew Dolgov 6e14e575b3 use separate id for default password warning dialog 6 years ago
Andrew Dolgov 848bb6579c floatingTitle: show collapse button if in expandable mode 6 years ago
Andrew Dolgov 1124c3f00a label display: fix unneeded nested container in headlines, increase overall minimalism, fix label element typo (div1) 6 years ago
Andrew Dolgov dbab03bd4c Feeds.catchupAllFeeds() should be Feeds.catchupAll() 6 years ago
Andrew Dolgov c7c9c5fb0a feedTree: amend previous to check that nodes are actually there (2) 6 years ago
Andrew Dolgov 42e0c7a420 feedTree: amend previous to check that nodes are actually there 6 years ago
Andrew Dolgov 3827e5b944 selectFeed: scroll feed tree to selected row 6 years ago
Andrew Dolgov 8b26b8629f headlines-frame: set is-vfeed attribute if result is virtual feed 6 years ago
Andrew Dolgov c607b7836e onLoaded: clear this.headlines on first page load 6 years ago
Andrew Dolgov f44c6d01b0 fix previous always disabling infscroll 6 years ago
Andrew Dolgov c66db9bde8 headlines onloaded: when appending, check for duplicate IDs 6 years ago
Andrew Dolgov 51b069a1ee display filter tree rules as a list 6 years ago
Andrew Dolgov 8393096947 selectionTogglePublished: fix typo which caused it to mark articles instead 6 years ago
Andrew Dolgov dee210e546 headlines onLoaded: make sure a few more things respect append instead of offset == 0 6 years ago
Andrew Dolgov 8effabd075 append headline buffer if requested, don't just use offset 6 years ago
Andrew Dolgov 957c44d177 rework git update checking to be initiated by frontend, outside of runtime info output 6 years ago
Andrew Dolgov c3b8b6a2a1 also prevent multiple requests 6 years ago
Andrew Dolgov 54ce930b8d delay counters request on promise completion a bit 6 years ago
Andrew Dolgov 8c49689fda filter test results: remove table bloat 6 years ago
Jordan Galby 47b4a262cf fix missing curly brace
Fix the error:
```
SyntaxError: missing } after property list
```
6 years ago
Andrew Dolgov d3885c5883 App.toggleNightMode: add some fadein/fadeout 6 years ago
Andrew Dolgov d53cdaf815 requestCounters: remove cooldown 6 years ago
Andrew Dolgov 4e41db7ed3 Article.unpack: add placeholder   if data-content is empty 6 years ago
Andrew Dolgov eda4ac2a2b add fallback colors for headline feed titles based on feed name if favicon color is not available 6 years ago
Andrew Dolgov be49b77b14 Revert "use codeflask for user css editor"
This reverts commit daa43e0572.
6 years ago
Andrew Dolgov 721f9ad866 requestIdleCallback: remove hard dependency for now 6 years ago
Andrew Dolgov daa43e0572 use codeflask for user css editor 6 years ago
Andrew Dolgov 7a98105960 remove old fatalError(), move everything to App.Error
update exception dialog css
6 years ago
Andrew Dolgov 071ca5aa96 Error.report: use JS template strings 6 years ago
Andrew Dolgov 2cbc2f5261 bring back frontend sanity check w/ App.checkBrowserFeatures() 6 years ago
Andrew Dolgov f3c04fc5d8 sync modified scores via mutation observer 6 years ago
Andrew Dolgov 25ca144bb7 score: get correct classes for rows/score icons on the client 6 years ago
Andrew Dolgov fd6f3e7f07 syncModified: request counters once after all xhr promises resolve 6 years ago
Andrew Dolgov 7cfd04ffb4 xhr helpers: wrap in promises 6 years ago
Andrew Dolgov 36f3299ddf use window.requestIdleCallback to sync observed modifications 6 years ago
Andrew Dolgov ad5a43bf66 sync article selected status via mutation observer
remove all rchk-related hacks
6 years ago
Andrew Dolgov c97c755195 remove _active_article_id; use selector instead 6 years ago
Andrew Dolgov d9bf0f17c6 sync unread state to server via mutation observer 6 years ago
Andrew Dolgov e5efde26ac sync marked and published states to server via mutation observer 6 years ago
Andrew Dolgov 6616c7cf67 keep track of selected prompt and floating title status using headline row mutation observer 6 years ago
Andrew Dolgov f96cdb7d5d renderAgain flag fixes 6 years ago
Andrew Dolgov 109910424c renderAgain: restore marked/published flags 6 years ago
fox cc267217e1 Merge branch 'tree_tooltip_error' of ggrandou/tt-rss into master 6 years ago
Andrew Dolgov 54f02a3b31 add Headlines.renderAgain() to switch between combined/expanded modes faster 6 years ago
Gilles Grandou df05794032 show errors in feedtree's tooltips 6 years ago
Andrew Dolgov 7e5c999146 show alert if recent_log_events > 0 6 years ago
Andrew Dolgov fca78f7417 add qmcToggleNightMode to actions dropdown 6 years ago
Andrew Dolgov 1c8593c1fa add hotkey (a N) to toggle night.css 6 years ago
Andrew Dolgov 95e1038e6d consistency: show author in multipanel headlines row 6 years ago
Andrew Dolgov a1c595687e fix previous to not crash in prefs 6 years ago
Andrew Dolgov 5e007e0090 headlines-spacer: only set 100% height if auto catchup is enabled 6 years ago
Andrew Dolgov 42780ddeb3 in grouped mode, don't display feed titles twice 6 years ago
Andrew Dolgov 302cffb1a7 catchupFeedInGroup: better icon 6 years ago
Andrew Dolgov dc84e10ba1 catchupFeedInGroup: overhaul
1. less hacky way to catchup actually unread headlines
2. don't fade rows away because it's inconsistent with different mark-as-read functions
3. fix stuck progress alert
6 years ago
Andrew Dolgov fa538a6c86 implement year-week sorting window if headlines buffer is grouped by feed titles 6 years ago
fox e338014d99 Merge branch 'pluginhost_fix' of ggrandou/tt-rss into master 6 years ago
Andrew Dolgov c8253f0e64 Article.openInNewWindow: do not crash if window is null 6 years ago
Gilles Grandou 392ad0bd83 fix PluginHost run method.
callbacks have no return value and anyway we should not prevent
to run subsequent plugins because one has failed.
6 years ago
Andrew Dolgov a0d332326c add PluginHost.HOOK_HEADLINE_RENDERED 6 years ago
Andrew Dolgov a400a8ffc1 add PluginHost.HOOK_INIT_COMPLETE (and make no_title_counters use it) 6 years ago
Andrew Dolgov f3737c0b24 update_rss_feed: add log message if article is filtered out
combine filters: fix crash on missing global function
6 years ago
Andrew Dolgov cf1ef002bc show disabled feeds in pref feed tree, use opacity instead of fixed gray color 6 years ago
Andrew Dolgov 4887db9820 update css for disabled filters; remove strikethrough 6 years ago
Michael Kuhn b43b7be9d5 Fix two more typos 6 years ago
Andrew Dolgov 41bf063e46 switchPanelMode: allow modifying layout in combined mode so that widescreen status won't be initially lost if starting in cdm 6 years ago
Andrew Dolgov bd66a9ef28 render article on the client using headlines data 6 years ago
Andrew Dolgov d1efcb7fc0 cdm: put originally_from into footer 6 years ago
Andrew Dolgov c31ae870c9 popupOpenArticle: don't cause an exception if popups are blocked 6 years ago
Andrew Dolgov 6e30af755c viewfeed: bring back comments prompt 6 years ago
Andrew Dolgov 76885fc5ad viewfeed: general code cleanup 6 years ago
Andrew Dolgov 8f75b06835 implement feed grouping display, remove unneeded server vgrlf passing 6 years ago
Andrew Dolgov 9d2caaefe7 viewfeed: show originally from... 6 years ago
Andrew Dolgov 20d460296d fix unread hl styling 6 years ago
Andrew Dolgov e075e6141b json-viewfeed updates 6 years ago
Andrew Dolgov 249c93a228 initial for js templates 6 years ago
Andrew Dolgov a68b150601 remove separate classes for various panels, unify under .panel
remove a few other unnecessary css classes/ids
6 years ago
Andrew Dolgov 7b0f4f1e46 updateFloatingTitle: marginRight correction no longer needed 6 years ago
Andrew Dolgov 7a276f9898 updateFloatingTitle: add safety offset to hide/show because mozilla can't into math 6 years ago
Andrew Dolgov c4b01dd547 updateFloatingTitle: sync row marked/published status 6 years ago
Andrew Dolgov 75666ac7ab Headlines.click: clicking in body of currently active cdm article should mark
it as read, otherwise it's not possible without a kb shortcut or auto catchup
6 years ago
Andrew Dolgov 7805b291b6 update floating title in toggleUnread functions post-xhr 6 years ago
Andrew Dolgov db3c7d2050 remove floating title appear animation for now 6 years ago
Andrew Dolgov 3e4326e34d add ttrss_filters2.last_triggered (bump schema version) 6 years ago
Andrew Dolgov 0b8cbc9156 remove some bitmaps and rework stuff using it to use iconfont instead 6 years ago
Andrew Dolgov d2d2cb7e7d rework scoring display, JS processing and icons 6 years ago
Andrew Dolgov b09a58a570 call Headlines.scrollhandler() on window resize 6 years ago
Andrew Dolgov d99d04a2ae notify: use iconfont, update colors and increase height a bit 6 years ago
Andrew Dolgov 0ea0b606be rework net-alert to use iconfont, move it to toolbar start 6 years ago
Andrew Dolgov f89ecda9b8 Feeds.updateRandom: fix calling wrong RPC method 6 years ago
Andrew Dolgov 0e25f5d512 add Lists.select() and make filter dialogs use it 6 years ago
Andrew Dolgov fbaa5ea857 label editor: fix changing tree color of edited item 6 years ago
Andrew Dolgov 0a41c1a6e1 update label rendering (and editor) 6 years ago
Andrew Dolgov f33cd597be selectionToggleUnread: remove loading... prompt (other similar methods don't have it) 6 years ago
Andrew Dolgov cad6d1d7fd various icon updates; use new icons in feed tree 6 years ago
Andrew Dolgov e7adc7e471 Merge branch 'master' into material-icons 6 years ago
Andrew Dolgov 7edcf6c45f ctrlclick in combined mode shouldn't open two windows 6 years ago
Andrew Dolgov f3e6e12d46 various minor updates re: icons 6 years ago
Andrew Dolgov 2dac797704 floatingTitle-related fixes 6 years ago
Andrew Dolgov b65d8384c2 update headlines to use vector icons 6 years ago
Andrew Dolgov e42d25a361 revert to previous headline ctrl-click behavior (open in new window, mark read) 6 years ago
Andrew Dolgov 05200a3840 rename main toolbar elements to be more consistent 6 years ago
Andrew Dolgov 85adef06f4 onkeydown handlers: fix default keyboard events not being blocked if necessary 6 years ago
Andrew Dolgov 9814ac608c Headlines.click: do not set article active if it already is
Headlines.onLoaded: reset active article if not called in append mode
6 years ago
Andrew Dolgov 2ab097b2e5 initial work for flat modern theme 6 years ago
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 6 years ago
Andrew Dolgov ed1bd992d7 PrefFilterTree: fix obscure crash because of getLabel() not casting data to string 6 years ago
Andrew Dolgov f6e287df11 remove 4px margin of cdm.expanded 6 years ago
Andrew Dolgov 7e7a15136b Headlines.onRowChecked: fix undefined row 6 years ago
Andrew Dolgov 4a0b644f61 Headlines.onRowChecked: fix possible desync in checkbox and row selected state 6 years ago
Andrew Dolgov 6d3092c742 Headlines.openInNewWindow: don't set article active, just window.open() it and set read 6 years ago
Andrew Dolgov d3486b15f9 fix collapse_sidebar hotkey action 6 years ago
Andrew Dolgov d8d3662729 CommonDialogs: refresh proper elements after feed operations in preferences 6 years ago
Andrew Dolgov e76d1fb995 plugins: mail, mailto: remove code from global context 6 years ago
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 6 years ago
Andrew Dolgov a049b5bd88 shorten declaration of PrefHelpers.OPML 6 years ago
Andrew Dolgov 8f1881e12c remove cookie set check 6 years ago
Andrew Dolgov 4d4034091a prefs: Prefs global -> Helpers 6 years ago
Andrew Dolgov b3bc638a9f refactor OPML export/import code to be less horrible 6 years ago
Andrew Dolgov 78cc470193 remove some plugin JS code out of global context 6 years ago
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
6 years ago
wn_ b83ed6c7c4 Fix reference to `PluginHost`.
A `const` doesn't create a property on `window`.
6 years ago
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 6 years ago
Andrew Dolgov ac8361e6f6 add AppBase as a shared ancestor for main and prefs app objects
remove event.observe stuff from startup, unneeded
6 years ago
Andrew Dolgov eeb49d375c uploadIconHandler -> CommonDialogs 6 years ago
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 6 years ago
Andrew Dolgov 495248dd97 add Notify object 6 years ago
wn_ 87850ca1aa Fix 'document.onkeydown' handler 6 years ago
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
6 years ago
Andrew Dolgov f89924f7a1 set use strict on JS modules; remove some mostly useless stuff like get_minified_js() 6 years ago
Andrew Dolgov 807ff07454 split main objects to dojo modules 6 years ago
Andrew Dolgov fda3ad39c8 split several utility objects into separate dojo modules 6 years ago
Andrew Dolgov 35ded4bc84 edit phrasing of some alert()s 6 years ago
Andrew Dolgov 3a6dae9203 prefs: more of the same, really 6 years ago
Andrew Dolgov b9869dbc01 prefs: remove some more stuff from global context (user management, etc) 6 years ago
Andrew Dolgov 58e54282d3 prefs: move more global functions into matching classes 6 years ago
Andrew Dolgov f26d404890 prefs: move other tree-related functions to respective trees 6 years ago
Andrew Dolgov 60cd467694 embed some pref-feed helper functions into the tree 6 years ago
Andrew Dolgov 2e985d1733 move some label helper functions to prefLabelTree 6 years ago
Andrew Dolgov e23b6e397d prefs: store active tab for reload, remove most old table row functions 6 years ago
Andrew Dolgov aa2f119eb6 remove getSelectedTableRowIds (Tables.getSelected) 6 years ago
Andrew Dolgov 874560db54 remove obsolete row selection functions
move getUrlParam() to Utils
6 years ago
Andrew Dolgov 2f85b50e36 remove toggleSelectListRow2() 6 years ago
Andrew Dolgov 8ea3a75df0 filters: simplify list row selection for checkboxes (properly) 6 years ago
Andrew Dolgov fb64726854 filters: simplify list row selection for checkboxes 6 years ago
Andrew Dolgov da9f83c4ac filter dialog fixes 6 years ago
Andrew Dolgov 1930f0e4e0 toggleSelect(etc): properly check for headlines object 6 years ago
Andrew Dolgov 0a18d0b1ed Feeds: shorten some method names
finally rename "view as rss"
6 years ago
Andrew Dolgov 6e625555c9 Headlines: shorten selectArticles 6 years ago
Andrew Dolgov 3678315bea Article, Headlines: shorten several method names 6 years ago
Andrew Dolgov d8ac5474ec onLoaded: since we call scroll handler anyway, remove fill up hack 6 years ago
Andrew Dolgov e5f3b75540 fix some minor linter problems 6 years ago
Andrew Dolgov 1e2d4410d3 move some more shared stuff to CommonDialogs, Filters, and Utils 6 years ago
Andrew Dolgov 4b492cc93e clear _infscroll_timeout when headlines are loaded 6 years ago
Andrew Dolgov bc96eac2ac addLabel -> CommonDialogs 6 years ago
Andrew Dolgov 2cd23e344c create headlines spacer with document.createElement() 6 years ago
Andrew Dolgov 6c110c1ceb headlines scroll handler: don't autoselect anything if feed was just opened 6 years ago
Andrew Dolgov de9509cd31 hotkeys: simplify prefix timeout handling 6 years ago
Andrew Dolgov b284e72d63 openArticleInNewWindow: also, set it active 6 years ago
Andrew Dolgov cc26be0793 migrate tt-rss.js contents to App 6 years ago
Andrew Dolgov 642c37ea61 further effocts to wrap JS stuff into objects 6 years ago
Andrew Dolgov 4bed9be57d js-ification: start on some common dialogs 6 years ago
Andrew Dolgov 44d3aedd38 prefs: hotkey handler to App 6 years ago
Andrew Dolgov ff708a9357 prefs: initial objectification 6 years ago
Andrew Dolgov b9984c0ed6 revert wrong changes in prefs.js 6 years ago
Andrew Dolgov 18868fb7ac remove counters_last_request from globals 6 years ago
Andrew Dolgov 97df81d8d9 even more objectification of JS 6 years ago
Andrew Dolgov 1d82bd4f19 further objectification 6 years ago
Andrew Dolgov 072c03fbac cdmClicked: backport master change to click on links 6 years ago
Andrew Dolgov 00cd4a48d4 Feeds -> this 6 years ago
Andrew Dolgov d86ddbc635 further objectification of JS code 6 years ago
Andrew Dolgov 049a37aa0e WIP reshuffling of JS global context into separate logical objects 6 years ago
Andrew Dolgov 4dbbd45caf enable floating title in unexpanded mode 6 years ago
Andrew Dolgov 468faee635 viewfeed: remove (tons of) obsolete code 6 years ago
Andrew Dolgov 069ecb6c2e viewfeed: catchup batched articles before opening next feed 6 years ago
Andrew Dolgov 710d06a288 catchup batching:
* behave better if invoked during an infinite scroll request
* flush catchup batch when article is selected manually
6 years ago
Andrew Dolgov 195180b64d minor refactoring: normalize some function names; cleanup; etc 6 years ago
Andrew Dolgov e720e6b628 remove infobox_callback2 6 years ago
Andrew Dolgov c151607b91 unpackVisibleHeadlines: increase lookahead distance 6 years ago
Andrew Dolgov b87b4287b7 scroll handler: fix loadMoreHeadlines() not being called 6 years ago
Andrew Dolgov 523e1cb9e8 reduce headlines scrolling timeout 6 years ago