Commit Graph

23 Commits (d0a9aeaf80510cdbbf4f4e461798ae9c36ace420)

Author SHA1 Message Date
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
6 years ago
Andrew Dolgov 6e14e575b3 use separate id for default password warning dialog 6 years ago
Andrew Dolgov 8effabd075 append headline buffer if requested, don't just use offset 6 years ago
Andrew Dolgov d53cdaf815 requestCounters: remove cooldown 6 years ago
Andrew Dolgov d9bf0f17c6 sync unread state to server via mutation observer 6 years ago
Andrew Dolgov dc84e10ba1 catchupFeedInGroup: overhaul
1. less hacky way to catchup actually unread headlines
2. don't fade rows away because it's inconsistent with different mark-as-read functions
3. fix stuck progress alert
6 years ago
Andrew Dolgov 76885fc5ad viewfeed: general code cleanup 6 years ago
Andrew Dolgov 8f75b06835 implement feed grouping display, remove unneeded server vgrlf passing 6 years ago
Andrew Dolgov e075e6141b json-viewfeed updates 6 years ago
Andrew Dolgov b09a58a570 call Headlines.scrollhandler() on window resize 6 years ago
Andrew Dolgov f89ecda9b8 Feeds.updateRandom: fix calling wrong RPC method 6 years ago
Andrew Dolgov 05200a3840 rename main toolbar elements to be more consistent 6 years ago
Andrew Dolgov 85adef06f4 onkeydown handlers: fix default keyboard events not being blocked if necessary 6 years ago
Andrew Dolgov 9814ac608c Headlines.click: do not set article active if it already is
Headlines.onLoaded: reset active article if not called in append mode
6 years ago
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 6 years ago
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
6 years ago
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 6 years ago
Andrew Dolgov ac8361e6f6 add AppBase as a shared ancestor for main and prefs app objects
remove event.observe stuff from startup, unneeded
6 years ago
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 6 years ago
wn_ 87850ca1aa Fix 'document.onkeydown' handler 6 years ago
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
6 years ago
Andrew Dolgov f89924f7a1 set use strict on JS modules; remove some mostly useless stuff like get_minified_js() 6 years ago
Andrew Dolgov 807ff07454 split main objects to dojo modules 6 years ago