Commit Graph

1296 Commits (9d2caaefe721e52f149a888f9be2bafc03b54e0c)

Author SHA1 Message Date
Andrew Dolgov 5edf4b73a4 add a workaround to support numeric tags 7 years ago
Andrew Dolgov f6269d1bc4 add special class for feeds with disabled updates 7 years ago
Andrew Dolgov a340b29ba9 pref-feeds: disable tree autoexpand 7 years ago
Andrew Dolgov 67bf38afda savefeedorder, savefilterorder: do not use clean() on json payload 7 years ago
Andrew Dolgov 7f4a404566 include: convert some spaces to tabs 7 years ago
Andrew Dolgov 102a01354b strip utf8mb4 characters in enclosures on mysql 7 years ago
jsoares 26ad257de5 Fixed time stamping of new unmarked/unpublished articles 7 years ago
Colin Vidal c217de557f rpc: addfeed: gets login and pass only if need_auth is checked.
Because of browser form auto-completion, the hidden field login and
password can be automatically filled when adding a feed. It would
enable feed authentication even if the user doesn't click on need_auth
button.
7 years ago
Andrew Dolgov c30f5e1811 subscribe_to_feed: force-cast login and password to string 7 years ago
immanuelfodor 09be7cdd73 binding statement named param instead of positional replacement 7 years ago
Andrew Dolgov 8dedacf497 remove synchronous feed refreshing on ForceUpdate 7 years ago
Tianon Gravi bbc4d4bf34 treat OPML-imported feeds without a title the same as a batch import 7 years ago
Francesco Turco 1a7277570b fix two-factor authenticaton 7 years ago
Andrew Dolgov d4c05d0be2 update_rss_feed: don't try to use quoted NOW() in query 7 years ago
Andrew Dolgov 6fb5f17be6 pluginhost: always return an array in get_all() 7 years ago
Andrew Dolgov bed2d6e054 force-cast some variables used in queries to integer
do not display SQL query in headlines debug mode
7 years ago
Andrew Dolgov d0cce0c7a4 isdefaultpassword: use method_exists() to check for check_password 7 years ago
Andrew Dolgov 0f05147531 properly highlight search keywords containing forward slash 7 years ago
simonp 5f19596651 Fix typo from previous pull request 7 years ago
Benjamin Collet 44c6a04b61 Check if the auth module supports check_password() method before using it 7 years ago
Andrew Dolgov 9390ddeae2 fix single user mode login failing because of isdefaultpassword() 7 years ago
Andrew Dolgov 1bf468ba1a pref-prefs: set button classes 7 years ago
Andrew Dolgov 121ac0481f filter rule/action dialogs: set default action 7 years ago
Andrew Dolgov ef1feb3610 subscribe dialog: add primary action 7 years ago
Andrew Dolgov 05e81655c3 user editor: add primary action 7 years ago
Andrew Dolgov 6fb5ce5e35 add some primary dialog actions; update css 7 years ago
Andrew Dolgov 5f7be9957f filter,label dlg: use default action 7 years ago
Andrew Dolgov 320a3ba529 search form: set default action 7 years ago
Andrew Dolgov f70d456a5b Merge branch 'master' of git.tt-rss.org:git/tt-rss into pdo-experimental 7 years ago
fox c463a95dca Merge branch 'master' of dim0x69/tt-rss into master 7 years ago
dim0x69 e58a14de72 Check return value from Plugins 7 years ago
fox 9306918767 Merge branch 'pda-rss-now' of richm/tt-rss into pdo-experimental 7 years ago
Richard Mortimer aa16334f1f Include NOW() in prepared SQL for rssutils.php 7 years ago
Andrew Dolgov 1c1fc17120 synchronous feed update: catch PDO exceptions as to not break headlines output 7 years ago
Andrew Dolgov 83a052f1fa pdo_connect: catch exception on create 7 years ago
Andrew Dolgov f8db5bb4db installer: use PDO, improve wording for some notices
PDO wrapper: allow working with blank DB_HOST
7 years ago
Andrew Dolgov 8e1450aa15 update previous to only affect mysql 7 years ago
Andrew Dolgov f76f773a16 purge_orphans: limit maximum number of deleted articles 7 years ago
Andrew Dolgov 99b23daee6 opml_import_filter: remove debugging 7 years ago
Andrew Dolgov 8f92a67e6f some (very minor) code cleanup in feeds class 7 years ago
Andrew Dolgov 003a7447c3 format_headlines_list: prevent warning on first_id changed check 7 years ago
Andrew Dolgov 92175a8371 setpref: remove nl2br() 7 years ago
Andrew Dolgov e6532439d6 force strip_tags() on all user input unless explicitly allowed 7 years ago
Andrew Dolgov 7c6f7bb0aa fix some minor issues found by code analyzer 7 years ago
Andrew Dolgov fa3bcfa379 queryfeedheadlines: there's no need to quote order_by/override_order
else: feedicon cache busting etc
7 years ago
Andrew Dolgov 5f5b0de423 style feed icon and opml file upload controls 7 years ago
Andrew Dolgov 229c139c6a ccache: properly recalculate counters for uncategorized 7 years ago
Andrew Dolgov 342e8a9eeb move feeds cache directory to cache/feeds 7 years ago
Andrew Dolgov 7c0eb1b621 add defaultPasswordWarning nag dialog 7 years ago
Andrew Dolgov 31e2811a63 ttrss_zoom: fix CSS 7 years ago
Andrew Dolgov 2f0623c9a5 db: return adapter on get(), remove IDB wrapper 7 years ago
Andrew Dolgov df5d2a0665 pluginhost: do not connect via legacy DB api until requested
log all initiated legacy database connections
7 years ago
Andrew Dolgov 2cf93c046c pref-users: fix sorting the table 7 years ago
Andrew Dolgov 28040002f3 pdo connection string: properly check for DB_PORT 7 years ago
Andrew Dolgov 1f16f9b8ae feed debugger: only allow debugging users own feeds 7 years ago
Andrew Dolgov 93e70e36c2 force article content/etc to string when updating to avoid failing null constraint check 7 years ago
Andrew Dolgov b51d44a5e6 further stylesheet simplification related fixes (2) 7 years ago
Andrew Dolgov 09bc54c690 further stylesheet simplification related fixes 7 years ago
Andrew Dolgov 5e68e24679 css/less updates 7 years ago
Andrew Dolgov 4dc3f7e779 api: do not use sql_bool_to_bool() 7 years ago
Andrew Dolgov 69563c96b4 plugin base: add type hint to init(host) 7 years ago
Andrew Dolgov 49a888ecce rssutils: forbid question marks in tsvector data, PDO gets confused sometimes even by quoted ?s 7 years ago
Andrew Dolgov 64312bfd71 feeds: remove sql_bool_to_bool() 7 years ago
Andrew Dolgov b6f3562d1e plugin base class: init pdo object
plugins/share: use PDO
7 years ago
Andrew Dolgov 187abfe732 main classes: remove sql_bool_to_bool() kludge 7 years ago
Andrew Dolgov 8ff3cbb32e filters: remove sql_bool_to_bool()
checkbox_to_sql_bool: return ints (???)
7 years ago
Andrew Dolgov e4291ba12f otpenable: use pdo prepare() 7 years ago
Andrew Dolgov 731ecac530 completeLabels: use prepare() not query() 7 years ago
Andrew Dolgov 7d960ce7e9 auth_internal: use PDO + other fixes 7 years ago
fox ab1960cf13 Merge branch 'upstream/pdo-experimental' of JustAMacUser/tt-rss into pdo-experimental 7 years ago
Andrew Dolgov bfccff11c4 filter rule saving fix 7 years ago
JustAMacUser 1a05210933 Fixed PDO query to prepared statement in API::updateArticles. 7 years ago
Andrew Dolgov bf6db17b8f feeds: use PDO 7 years ago
Andrew Dolgov 2e52e4fd7a feeds: more PDo stuff 7 years ago
Andrew Dolgov e4befe6bf4 fix label cache being double escaped on save
remove some old-style escaping
7 years ago
Andrew Dolgov 7a1872c1e0 feeds: more PDO stuff 7 years ago
Andrew Dolgov b5bf9a0ff3 remove long forgotten stuff related to feed debugging actionbar 7 years ago
Andrew Dolgov 91d679667e feeds: PDO progress 7 years ago
Andrew Dolgov da9ea57d1c checkbox to sql bool related changes, some more boolean fixes 7 years ago
Andrew Dolgov 7ccb4e91ff boolean handling changes which probably won't break everything 7 years ago
Andrew Dolgov 248c62a1cc filters: fix limit/offset for test dialog 7 years ago
Andrew Dolgov bf4a79eaa9 prefs: start PDO switchover 7 years ago
Andrew Dolgov f594717d18 filters: use PDO 7 years ago
Andrew Dolgov 21295a52aa labels: PDO 7 years ago
Andrew Dolgov c2418a559b pref-users: PDO 7 years ago
Andrew Dolgov 93ca6c95b8 pref-system: PDO 7 years ago
Andrew Dolgov 7039370368 pref-prefs: PDO 7 years ago
Andrew Dolgov f8108cc28d pluginhost: save_data() fixes 7 years ago
Andrew Dolgov 8af94f1292 pluginhost: use PDO 7 years ago
Andrew Dolgov 0500e14cc2 update_rss_feed: transaction lock article processing 7 years ago
Andrew Dolgov 0567016b40 rssutils: PDO 7 years ago
Andrew Dolgov afcb105f4e rssutils: start PDO switch 7 years ago
Andrew Dolgov 1d92297a96 dbupdater: use PDO 7 years ago
Andrew Dolgov c949a9282e OPML: use PDO; minor fixes 7 years ago
Andrew Dolgov 4102eb843f sql logger: pdo 7 years ago
Andrew Dolgov c1c08aed39 labels: PDO 7 years ago
Andrew Dolgov fbe7cb0a48 rpc: switch to PDO 7 years ago
Andrew Dolgov 9652fa6b66 API: small fix 7 years ago
Andrew Dolgov 3467e1fd7c api: switch to PDO 7 years ago
Andrew Dolgov dd90eefae1 PDO: set unicode for mysql and other connection params 7 years ago
Andrew Dolgov aee3f0e6d9 fix typo 7 years ago
Andrew Dolgov 7fc303e6ab query feed headlines: fix limit/offset 7 years ago
Andrew Dolgov cb13089af1 public: use PDO headlines result (2) 7 years ago
Andrew Dolgov dc393a580b public: use PDO headlines result 7 years ago
Andrew Dolgov 3623ebb1a1 feeds: handle escaping 7 years ago
Andrew Dolgov c9b6ca8b70 feeds: remove escaping 7 years ago
Andrew Dolgov b5791f11c5 queryfeedheadlines: PDOize (1) 7 years ago
Andrew Dolgov 29f1908e03 feeds: right before queryfeedheadlines() 7 years ago
Andrew Dolgov cc9450c309 ccache, misc: fixes
feeds: start PDO transition
7 years ago
Andrew Dolgov 1271407eea public: partial conversion to PDO, misc fixes 7 years ago
Andrew Dolgov fbde19580c db_prefs: PDO 7 years ago
Andrew Dolgov abf94f00b4 digest: use PDO 7 years ago
Andrew Dolgov 9ead64f6d8 dlg: PDO 7 years ago
Andrew Dolgov 933ff559e6 ccache: PDO 7 years ago
Andrew Dolgov a25ac0d7c8 counters: PDO 7 years ago
Andrew Dolgov c9d5c26041 auth/base: PDO
functions: fix small pdo-related bug
7 years ago
Andrew Dolgov 2c57df75ff article: remove db_escape..() 7 years ago
Andrew Dolgov d0e73ed8ae article: switch to PDO 7 years ago
Andrew Dolgov 2e46b434da pdo: set warnings 7 years ago
Andrew Dolgov c39ee27235 article: start pdo 7 years ago
Andrew Dolgov bfc54b0369 Merge branch 'pdo-experimental' of git.fakecake.org:tt-rss into pdo-experimental 7 years ago
Andrew Dolgov d9e60c0f68 Merge branch 'master' of git.fakecake.org:tt-rss into pdo-experimental 7 years ago
Andrew Dolgov e50c8eaa4e enforce unconditional requests every 6 hours even if server claims data is not modified 7 years ago
Andrew Dolgov 8adb3ec472 add some WIP pdo stuff 7 years ago
Andrew Dolgov ca82bb03c8 rm db_stmt 7 years ago
Andrew Dolgov 99bda9cc12 add some starting pdo glue 7 years ago
Andrew Dolgov 9dd336a2c3 generate base css files using lessc 7 years ago
dim0x69 5395526444 add HOOK_UNSUBSCRIBE_FEED 7 years ago
Andrew Dolgov 2352c320c2 fix possible sql injection in public/forgotpass 7 years ago
Andrew Dolgov 9d930af9e1 fetch_file_contents: improve error handling
1. if request fails get error string from http  response status line
2. do not override http error with possible CURL/php specific last error
3. fix silent php error generated while processing response headers to get last modified value
7 years ago
Andrew Dolgov 91f49ba17d api, setArticleLabel: allow JSON booleans 7 years ago
fox d320b55af9 Merge branch 'sort_title_date' of ggrandou/tt-rss into master 7 years ago
Gilles Grandou f9ad33c2d8 allows favicons to be in Windows PC BMP format 7 years ago
Gilles Grandou 81d96c0dee makes 'order by title' to sort by title and by ascending date
* this allows to chronologically browse all articles with the
  same title.
7 years ago
Andrew Dolgov 8b73bd28d8 remove apache-specific x-sendfile stuff
implement a hook (HOOK_SEND_LOCAL_FILE) which plugins may use to send files
via httpd-specific implementation to increase performance typically on larger files
7 years ago
fox b1d1bc901f Merge branch 'checkbox-feed' of dxbi/tt-rss into master 7 years ago
Felix Eckhofer cc50affb62
Add checkbox for authentication in edit feed dialog
This makes the UI more consistent with the "add feed" dialog and
prevents overzealous password-managers from leaking the login password.
7 years ago
Andrew Dolgov 51b521c326 fix batch feed editor using wrong SQL syntax when saving feed password
remove uses of auth_pass_encrypted in several other places
7 years ago
wn_ 3476690cbf Only require an array of basic info from 'HOOK_FEED_BASIC_INFO'.
Removes the need for the plugin to provide feed content.

Gives plugins a chance to provide 'title' and 'site_url' basic info.
Falls back to attempting retrieval+parsing of the fetch URL if needed.
7 years ago
wn_ bec5ba93e2 Add 'HOOK_FEED_BASIC_INFO' to enable plugins to provide basic feed info.
It's expected the plugin will return content parsable by FeedParser, which
will act as an interface to the basic feed info.  In the case of a plugin
that also uses 'HOOK_FETCH_FEED', both might return the same content.

The hook signature was made somewhat similar to 'HOOK_FETCH_FEED'.
7 years ago
wn_ f3774b9d65 Use 'saveHTML' when generating HTML from a DOMDocument.
This primarily occurs when modifying article content.  If 'saveXML' is
used following 'loadHTML' there is the possibility of strangeness, such
as a self-closing anchor tag.

Note that the DOMDocument used in 'classes/feeditem/atom.php' came from
'loadXML', but we use 'saveHTML' since we're returning HTML content.
7 years ago
Andrew Dolgov 153cb6d305 add support for http 304 not modified (no timestamp calculation bullshit like last time) 7 years ago
Andrew Dolgov edefcec19d filters/edit: properly parse feed-specific legacy format filter rules 7 years ago
Andrew Dolgov ab8daa0389 use mysqli_set_charset() to set MYSQL_CHARSET 7 years ago
Andrew Dolgov 20d2195f13 rssutils: include comment count when calculating article hash 7 years ago
Andrew Dolgov 51f13e7736 get_all_labels: order by caption 7 years ago
Andrew Dolgov 5e78b0c253 do not base headlines label context submenu on feed tree labels category 7 years ago
Andrew Dolgov be61f1c45c filters dialog: do not break markup on long feed names 7 years ago
Andrew Dolgov b2d42e960b replace some usages of SELF_URL_PATH with get_self_url_prefix() 7 years ago
Andrew Dolgov 667d32fd26 remove obsolete forum plugin links
mention how to enable system plugins in the UI
7 years ago
Andrew Dolgov 7b994e4bec filters: when adding rule select all feeds by default 7 years ago
Andrew Dolgov 57a1143c9d dbupdater: fail if version file missing 7 years ago
Andrew Dolgov 02f3992a5a Revert "Revert "filters: support matching on multiple feeds/categories""
This reverts commit f5d174bda9.
7 years ago
Andrew Dolgov f5d174bda9 Revert "filters: support matching on multiple feeds/categories"
This reverts commit 0bf7e007bb.
7 years ago
Andrew Dolgov e0f51d786f Merge branch 'master' of git.fakecake.org:tt-rss 7 years ago
Andrew Dolgov 0bf7e007bb filters: support matching on multiple feeds/categories
opml: update filter export/import for new format
7 years ago
Andrew Dolgov c053b97697 pref/feeds: start user category ordering from 1
api, getFeeds: send subcategory order_id
7 years ago
Andrew Dolgov e130b283a7 db prefs: ignore cache when preference requested for specified UID (in case cached value of a different profile is stored)
prefs: show (and set) enabled plugins for default profile only
7 years ago
Andrew Dolgov 93af11cb7a update_daemon_common: do not escape feed_url twice, remove some comments and stuff 8 years ago
Andrew Dolgov 6fd0399694 tunables:
* add CACHE_MAX_DAYS as a tunable generic expiry interval for various cached files
* add some comments to tunables in functions.php
* rename _MIN_CACHE_FILE_SIZE to MIN_CACHE_FILE_SIZE
* respect MIN_CACHE_FILE_SIZE setting in a few more places where content is cached
8 years ago
Andrew Dolgov e50a647916 add HOOK_FORMAT_ARTICLE & HOOK_FORMAT_ARTICLE_CDM
Feeds::format_headlines_list: add some comments for cdm article closing tags
8 years ago
Andrew Dolgov 9e381bc202 classes/Plugin: remove dbh & host fields; set init() and about() as abstract methods. 8 years ago
Andrew Dolgov 5b6ea1ef91 remove pubsubhubbub: dead 8 years ago
Andrew Dolgov 8f0a59f34a share function: remove tt-rss prefix from page title 8 years ago
Andrew Dolgov c114a2596f move add_feed_url() to pref_feeds 8 years ago
Andrew Dolgov 4fd0790804 fix DAEMON_SLEEP_INTERVAL not being defined when used
enforce minimum 60 sec spawn/sleep interval in update processes
8 years ago
Andrew Dolgov e6c886bf66 wrap rssfuncs into rssutils class 8 years ago
Andrew Dolgov 65af3b2cbb move counter stuff to a separate class 8 years ago
Andrew Dolgov 40f4a7aa6b feeditem_common: add get_element() 8 years ago
Andrew Dolgov 7c9b5a3fe4 move label stuff to Labels class
fix some unresolved functions
8 years ago
Andrew Dolgov c2f0f24e4c move digest stuff to Digest class 8 years ago
Andrew Dolgov 0086a89740 move some label stuff to labels.php
move getfeedcategory() to Feeds
8 years ago
Andrew Dolgov 4a0da0e5bf move get_article_labels to Article 8 years ago
Andrew Dolgov 2ed0d6c433 move counter cache to a separate class
fix references to get_article_tags
8 years ago
Andrew Dolgov aeb1abedb2 move a bunch of functions into Feeds/Article namespaces
+       static function catchupArticlesById($ids, $cmode, $owner_uid = false) {
+       static function getLastArticleId() {
+       static function queryFeedHeadlines($params) {
+       static function getParentCategories($cat, $owner_uid) {
+       static function getChildCategories($cat, $owner_uid) {

move the rest of functions2.php back to functions.php as it is of more manageable size, remove the former
8 years ago
Andrew Dolgov a230bf88a9 move to Article:
+       static function purge_orphans($do_output = false) {

move to Feeds

+       static function getGlobalUnread($user_id = false) {
+       static function getCategoryTitle($cat_id) {
+       static function getLabelUnread($label_id, $owner_uid = false) {
8 years ago
Andrew Dolgov 86a8351ca2 move the following to Feeds:
+       static function catchup_feed($feed, $cat_view, $owner_uid = false, $mode = 'all', $search = false) {
+       static function getFeedArticles($feed, $is_cat = false, $unread_only = false,
+       static function subscribe_to_feed($url, $cat_id = 0,
+       static function getFeedIcon($id) {
+       static function getFeedTitle($id, $cat = false) {
+       static function getCategoryUnread($cat, $owner_uid = false) {
+       static function getCategoryChildrenUnread($cat, $owner_uid = false) {
8 years ago
Andrew Dolgov 7e5f8d9fb3 move the following to Article:
+       static function format_article_enclosures($id, $always_display_enclosures,
+       static function format_article($id, $mark_as_read = true, $zoom_mode = false, $owner_uid = false) {
+       static function get_article_tags($id, $owner_uid = 0, $tag_cache = false) {
+       static function format_tags_string($tags) {
+       static function format_article_labels($labels) {
+       static function format_article_note($id, $note, $allow_edit = true) {
+       static function get_article_enclosures($id) {
8 years ago
Andrew Dolgov 4122da0290 move getArticleFeed to Article
move print_label_select to controls
8 years ago
Andrew Dolgov e60d5b0a84 move opml-specific get_feed_category to opml.php 8 years ago
Andrew Dolgov 3517d363d3 add api test for labels, api: fix setArticleLabel assign not handled correctly 8 years ago
Andrew Dolgov 891df34637 add some basic API unit tests 8 years ago
Andrew Dolgov ea79a0e033 remove some redundant php closing tags 8 years ago
Andrew Dolgov 7b55001eee fix various issues reported by static analysis
update gitlab-ci config
8 years ago
Andrew Dolgov 3c11159776 return result codes if DB connection or --debug-feed fails 8 years ago
Andrew Dolgov 337535416f filter by search results while marking feed as read 8 years ago
Andrew Dolgov 9c3c0ace6b rename cache images option label (rip translations) 8 years ago
Andrew Dolgov 41bead9baa remove local file extensions and generalize some method names for cached media
file extensions may still be present in urls, but are ignored by the backend

MIGRATION (if you have any cached data worth keeping, not required):
in cache/images run "rename 's/\..*$//' *" i.e. strip file extensions
8 years ago
Andrew Dolgov 63f0ed3d9c cdmClicked: do not use event.target.parents to figure out if clicked on a heading 8 years ago
Andrew Dolgov 270c0a00e5 improve JS error logging with additional stuff 8 years ago
Andrew Dolgov 1bfe1d7b31 simplify error handling
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
8 years ago
Andrew Dolgov b835a52814 rework the way headlines menus identify calling row 8 years ago
Andrew Dolgov 5161460048 bind headlines menu to a selector to avoid remaking it unnecessarily 8 years ago
Andrew Dolgov 58210301e0 add HOOK_ENCLOSURE_ENTRY for af_zz_imgproxy 8 years ago
Jérémy DECOOL ba2853caac Prevent target='_blank' vulnerability on dynamic link 8 years ago
Andrew Dolgov 4daaf23491 allow user plugins to expose public methods out in a limited fashion 8 years ago
Andrew Dolgov 328118d12e use print_hidden() for hidden dojo form fields 8 years ago
Andrew Dolgov 38b3998bbc af_zz_imgproxy: use inline disposition, misc updates 8 years ago
Andrew Dolgov 9c7ebaa08c cached_image: remove unnecessary basename() 8 years ago
Andrew Dolgov 0442cbb6c1 image cache: send files as content-disposition: attachment; add .png suffix to image urls 8 years ago