Commit Graph

1571 Commits (86b12fc06c33fe742ac4035a031716674bdb6462)

Author SHA1 Message Date
Andrew Dolgov 27e695436f fetch_file_contents: validate effective URL (after redirects) if using CURL 4 years ago
Andrew Dolgov 5a7e7e1367 don't try to call hash_equals() on unset user token 4 years ago
Andrew Dolgov f72e6947d5 use hash_equals() correctly 4 years ago
Andrew Dolgov e3adacc588 fix several cases of Db class being invoked as wrong name (as DB) 4 years ago
Andrew Dolgov 16c86e2fc3 replace some plain http links with https 4 years ago
Andrew Dolgov a817d3794d * use get_random_bytes() for CSRF token
* get_random_bytes: use PHP7 random_bytes() if it is available
* validate CSRF token using hash_equals
4 years ago
Andrew Dolgov 1f79d614c4 fix OTP QR code not displayed because of CSRF token passed as a query
parameter
use type-strict comparison when validating CSRF token on the backend
4 years ago
Andrew Dolgov 6a4b6cf603 amend previous to 127/8 subnet 4 years ago
Andrew Dolgov 213d6330b1 fetch_file_contents: resolve requested hosts and check for possible
loopback address
4 years ago
Andrew Dolgov 88c4dc405e build_url: also put query parameters and fragment in resulting URL
rewrite_relative_url: simplify handling of relative URLs
4 years ago
Andrew Dolgov da5af2fae0 cached_url: block SVG images because of potential javascript inside 4 years ago
Andrew Dolgov aeaafefa07 don't pass csrf token as a GET parameter to Article 4 years ago
Andrew Dolgov 1621abcffc rewrite_relative_url: validate resulting absolutized URLs 4 years ago
Andrew Dolgov aa89ea7769 validate_url: only allow safe ports (80, 443), disallow access to loopback 4 years ago
Andrew Dolgov 6c02fea641 validate_url: add clean() 4 years ago
Andrew Dolgov 4abc7d7898 rename base64_img() to image_to_base64() 4 years ago
Andrew Dolgov 1ee458b5c1 cached_url: perform mimetype validation before possible HOOK_SEND_LOCAL_FILE hooks 4 years ago
Andrew Dolgov b4cb67e77f remove csrf token from rpc method sanityCheck 4 years ago
Andrew Dolgov c3d14e1fa5 - fix multiple vulnerabilities in af_proxy_http
- fix vulnerability in rewrite_relative_url() which prevented some URLs from being properly absolutized
- fetch_file_contents: validate all URLs before requesting them
- validate URLs: explicitly whitelist http and https scheme, forbid everything else
- DiskCache/cached_url: only serve whitelisted content types (images, video)
- simplify filename/URL handling code, remove and consolidate some less-used functions
4 years ago
Rodney Stromlund 376dce02bb Update wiki and forums links in error message. 4 years ago
Andrew Dolgov 6eb94f1e13 better support for image srcset attributes as discussed in https://community.tt-rss.org/t/problem-with-img-srcset/3519 4 years ago
Andrew Dolgov 19893d33e3 only bind up/down in 3 panel mode 4 years ago
Andrew Dolgov ebb373987a Revert "unbind up/down by default (use native scrolling for consistency with pgup/pgdn)"
This reverts commit 6fc18e450b.
4 years ago
Andrew Dolgov 6fc18e450b unbind up/down by default (use native scrolling for consistency with pgup/pgdn) 4 years ago
Andrew Dolgov 9ae9302b6b implement keyboard-related changes discussed in https://community.tt-rss.org/t/changing-the-amount-of-scroll-by-arrow-key/3452/7 4 years ago
JustAMacUser 7a0ea9d90e Make iframes size responsively. 4 years ago
Andrew Dolgov 2b55afbeec sanitize: forbid "allow" attribute
CSS: remove auto hyphens stuff, remove iframe width clipping to 98% because they get squished
4 years ago
Andrew Dolgov 2558fcbe21 add hotkey "\" to cancel current search 4 years ago
Andrew Dolgov e934e9f05e sanitize: simplify initial attribute processing 4 years ago
Andrew Dolgov 7d9dd51cf4 sanitize: remove srcset plain-http hack, globally disallow width and height attributes for all elements 4 years ago
Andrew Dolgov 83c8834421 sanitize: handle picture[@srcset] elements properly, i.e. rewrite relative URLs 4 years ago
Martin Stone 1ad43dd202
Fix documentation for _noexpand commands 4 years ago
Toby Simmons 569228a5df In get_version() disable DIRECTORY_SEPARATOR check, permit using git on Windows to get version details; 4 years ago
Andrew Dolgov 4e74da590e af_readability: allow get full text button to work as a toggle; in cdm, scroll to article after embedding 4 years ago
Andrew Dolgov 07b27b375f update toggle_embed_original hotkey to invoke readability embed instead of removed embed_original plugin 4 years ago
Andrew Dolgov 4ab3854aed don't generate default.css, replace with themes/light.css as a default root CSS file 4 years ago
Andrew Dolgov 06b9d39662 add support for image loading=lazy attribute 4 years ago
Andrew Dolgov 076c5382fa login form: add workarounds for chrome password manager 5 years ago
Andrew Dolgov 6080cca9ca scrap counter cache system; rework counters to sum() booleans instead 5 years ago
Andrew Dolgov a6d314b753 support dark mode for login form 5 years ago
Andrew Dolgov 01513aa41b disable MAX_FETCH_REQUESTS_PER_HOST warnings for the time being 5 years ago
Andrew Dolgov 5fc499e19e get_version: don't rely on exec() exit code to determine whether output is valid 5 years ago
Andrew Dolgov fdb1fc7608 get_version: fix commit/timestamp lost on subsequent invocations because of misbehaving caching 5 years ago
Andrew Dolgov 6439f7817d force-disable php display_errors/display_startup_errors on startup 5 years ago
Andrew Dolgov c309856a97 get_version: filter out Darwin 5 years ago
Andrew Dolgov 74feef0f9d get_version: always return unsupported on windows 5 years ago
Andrew Dolgov c46c5e59fc SELF_USER_AGENT: switch to get_version() 5 years ago
Andrew Dolgov 72d8a34f74 get_version: don't pass useless root dir to git, instead log it in case of failure 5 years ago
Andrew Dolgov 72d0fac80c remove version.php and VERSION global constant, do version-related things in a slightly less ridiculous way 5 years ago
Andrew Dolgov 0237dee980 implement automatic night mode detection using MQL
add separate light.css to force light theme
remove manual night mode toggle and related code
5 years ago
Andrew Dolgov 0a10832491 - update descriptions of changed hotkeys
- bind noscroll variants of move article hotkeys to n/p by default
- update N/P (i.e. scroll article content) hotkeys to scroll by fraction of viewport height instead of hardcoded pixel distance
- minor fixes w/ checking for undefined
5 years ago
Andrew Dolgov 008afb97a9 exp: unbind from pgup/pgdn buttons by default 5 years ago
Andrew Dolgov 6191c48596 trim() contents of version_static.txt 5 years ago
fox f4945b1ba1 Merge branch 'page-hotkeys' of suraia/tt-rss into master 5 years ago
Andrew Dolgov 5907409a84 add support for custom version_static.txt for package maintainers 5 years ago
Michael Kuhn f133b78a3e Fix Shift+PageUp/Down hotkeys 5 years ago
Andrew Dolgov ac95ab4a65 user css dialog: allow saving and applying CSS without closing the dialog 5 years ago
Andrew Dolgov 565547f5a1 php 7.4 deprecation-related fixes 5 years ago
Andrew Dolgov 1902a7dcb0 pgup/pgdown hotkey normalization:
- pgup/pgdown without modifier scroll headline buffer
- shift+pgup/pgdown work similarly to shift+up/down but operating on pages
5 years ago
Andrew Dolgov f30287be65 versioning changes
- remove VERSION_STATIC - https://community.tt-rss.org/t/versioning-changes-for-trunk/2974
- report git commit/timestamp properly by invoking git instead of trying to parse .git/HEAD etc
- remove git-related global constants used when checking for updates
5 years ago
Andrew Dolgov 6913158b82 add hotkeys to scroll headlines/articles (whichever is active) by one page 5 years ago
Andrew Dolgov d15f0349bf remove hardcoded iframe domain whitelist, make iframe script whitelisting configurable by plugins (HOOK_IFRAME_WHITELISTED) 5 years ago
Andrew Dolgov e5b7b145e5 cache media: set referrer to source URL when fetching images 5 years ago
Andrew Dolgov 8c3efd51ec reset domain hit quota on feed update start 5 years ago
Andrew Dolgov cd4b7f1988 implement MAX_FETCH_REQUESTS_PER_HOST: only generating a warning on exceeded quota for the time being 5 years ago
cac2s 6b47f5a6d1 fix position for "forgotpass" link 5 years ago
Andrew Dolgov 68b0380118 add placeholder authentication via app passwords if service is passed
forbid logins via regular passwords for services
remove AUTH_DISABLE_OTP
5 years ago
Andrew Dolgov 84e9f1d5cc update schema for app-specific passwords 5 years ago
JustAMacUser 4cc6a773ff Removed redundant text for next/prev article without scroll. 5 years ago
JustAMacUser 2e61551c28 Try to clarify next/prev article keyboard shortcut help. 5 years ago
Andrew Dolgov 3e4701116d af_readability: add missing file 5 years ago
Andrew Dolgov 9806a2b5ff bump version_static 5 years ago
Andrew Dolgov 6914ad1f74 retire MIN_CACHE_FILE_SIZE 5 years ago
Andrew Dolgov 3c075bfd21 DiskCache: more strict checking for input filenames, getUrl() is no longer static 5 years ago
Andrew Dolgov 133c2b482b move rewrite_cached_urls to DiskCache::rewriteUrls() 5 years ago
Andrew Dolgov b1dd38f880 add DiskCache.getUrl() and use it in a bunch of places 5 years ago
Andrew Dolgov 088fcf8131 move more globals to more appropriate places
set libxml to always use internal errors
5 years ago
Andrew Dolgov 4fa9aee4e7 move several more global functions to more appropriate classes 5 years ago
Andrew Dolgov 6d746453c7 get_feeds_from_html: remove XML preamble hack
move several related helper functions to Feeds class
5 years ago
Andrew Dolgov 66cbe55148 sanity check: require UConverter from php intl 5 years ago
Andrew Dolgov ccc0315ef0 better tsquery support:
1. report query syntax errors properly
2. fall back to implicit &-joining only if no joiners are detected in user query, otherwise permit full tsquery syntax
5 years ago
ltGuillaume 3d8c6967da Add keyboard shortcut 'g r': Go to Recently read 5 years ago
Andrew Dolgov 6fbf349155 add hidden _SKIP_SESSION_UA_CHECKS tunable 5 years ago
Andrew Dolgov 6768b3a4a3 schema: add DEFAULT_SEARCH_LANGUAGE 5 years ago
Greg-T 2c2f74a104 PDO error in cleanup_tags repaired
Changes :
- add PDO::PARAM_INT to a value in a PDO query
- switch limit to limit_part to respect semantic here (cleanup by packages)
5 years ago
Andrew Dolgov 671f4cee65 domdocument: remove old meta charset unicode hacks, replace with shorter xml preamble utf8 hack (on loadhtml where it makes sense)
af_readability: better (?) charset hack for non-unicode pages
5 years ago
Andrew Dolgov 01b2f0a24f support "picture" tags in articles 5 years ago
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
5 years ago
Andrew Dolgov 32f9fda33d add composite key on ttrss_feeds (feed_url & owner_uid) 5 years ago
Andrew Dolgov 0b74db5ad7 remove feedbrowser (other feeds) 5 years ago
Andrew Dolgov 38e01270d8 archived feeds: expire old entries (schema bump) 5 years ago
Andrew Dolgov dfd3a4e581 update previous with make_password() in tt-rss proper 5 years ago
Andrew Dolgov 16a9bdc387 make_password: generate longer passwords by default, use better random function if available 5 years ago
Andrew Dolgov 5b3a73e574 login: switch to absolute redirect urls 5 years ago
Andrew Dolgov 925065b1fe Revert "login: only allow relative URLs in return="
This reverts commit c68ac04020.
5 years ago
Andrew Dolgov c68ac04020 login: only allow relative URLs in return= 5 years ago
Andrew Dolgov 72fcc81919 support per-plugin locale directories 5 years ago
Andrew Dolgov 32db1cb872 OPML: include (and import) ttrss per-feed update interval and sort order 5 years ago
Andrew Dolgov 54c1b5c611 fill in some missing doctypes; use short doctype where it wasn't 5 years ago
Andrew Dolgov 947e9cdc86 should be 19.2, duh 5 years ago
Andrew Dolgov 53a02b850e bump version_static 5 years ago
Andrew Dolgov 8cd7f31bde utility css updates 5 years ago
Andrew Dolgov 73c845858c make login form a bit special after all 5 years ago
Andrew Dolgov e2c9e283a2 remove ttrss_login stuff, use utility class 5 years ago
Andrew Dolgov c11f32ac38 center and rework some utility screens 5 years ago
Andrew Dolgov 4f720f906e simplify login form 5 years ago
Andrew Dolgov 874a2d2170 Revert "enable fi_FI locale"
oops, nevermind

This reverts commit e00041b206.
5 years ago
Andrew Dolgov e00041b206 enable fi_FI locale 5 years ago
root 5ac1935db5 Make article date select 12/24 time based on SHORT_DATE_FORMAT 5 years ago
Andrii Zhuk f1f2b81a90 Add i18n for auto mode:wq 6 years ago
Andrii Zhuk 57c3322088 Changed language name for Ukrainian 6 years ago
Andrew Dolgov 17a8821c0b enable uk_UA locale; rebase translations 6 years ago
Andrew Dolgov 1351ce370a truncate_middle: make it utf8 aware 6 years ago
Andrew Dolgov a5517fe857 fetch_file_contents: decompress gzipped data
af_readability: remove utf8 preamble hack
6 years ago
Andrew Dolgov 957c44d177 rework git update checking to be initiated by frontend, outside of runtime info output 6 years ago
Andrew Dolgov d53cdaf815 requestCounters: remove cooldown 6 years ago
Andrew Dolgov 25ca144bb7 score: get correct classes for rows/score icons on the client 6 years ago
Andrew Dolgov 7e5c999146 show alert if recent_log_events > 0 6 years ago
Andrew Dolgov 51de0ce807 runtime info: return count of recent eventlog entries 6 years ago
Andrew Dolgov 1c8593c1fa add hotkey (a N) to toggle night.css 6 years ago
Andrew Dolgov 703351c79e remove theme supports-version etc checking 6 years ago
Andrew Dolgov 33240b7fd9 various layout fixes related to inline player causing unnecessary left padding if shorten_expanded is enabled 6 years ago
Andrew Dolgov 3e4326e34d add ttrss_filters2.last_triggered (bump schema version) 6 years ago
Andrew Dolgov a01c33d654 add HOOK_FILTER_TRIGGERED (for filter debugging) 6 years ago
Andrew Dolgov 0b8cbc9156 remove some bitmaps and rework stuff using it to use iconfont instead 6 years ago
Andrew Dolgov 15d05e8a26 night.css: do not import default less theme statically
remove themes/default.php (not needed)
compact.css: fixes
6 years ago
Andrew Dolgov d2d2cb7e7d rework scoring display, JS processing and icons 6 years ago
Andrew Dolgov 73c68e600b feed browser: remove pub_set.png 6 years ago
Andrew Dolgov 29c890b495 login form: use dojo, remove profile hacks 6 years ago
Andrew Dolgov 197e80add6 fix several issues related to profile being set to a non-numeric value 6 years ago
Andrew Dolgov 6303e1626c remove cache/js (no longer used) 6 years ago
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 6 years ago
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
6 years ago
Andrew Dolgov e905ce7ea9 fix login 6 years ago
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
6 years ago
Andrew Dolgov f89924f7a1 set use strict on JS modules; remove some mostly useless stuff like get_minified_js() 6 years ago
Andrew Dolgov 874560db54 remove obsolete row selection functions
move getUrlParam() to Utils
6 years ago
Andrew Dolgov 2f85b50e36 remove toggleSelectListRow2() 6 years ago
Andrew Dolgov 5aa9c60494 bring back (debloated) version of unexpanded combined mode 6 years ago
Andrew Dolgov bf1b89d0f1 enable c-up/down hotkeys even out of cdm 6 years ago
Andrew Dolgov 07fd4f8d9d minor css fixes (mostly for zoom mode) 6 years ago
Andrew Dolgov 50052fb78a strip_harmful_tags: remove data- attributes 6 years ago
Andrew Dolgov 9563e3bcd6 remove expandable CDM headlines 6 years ago
Andrew Dolgov fc0a3050eb use xhrPost is even more places! 6 years ago
Andrew Dolgov c10a43069e debug logging system rework:
* support various logging levels per-message
 * remove hacks like debug_suppress, DAEMON_EXTENDED_DEBUG, etc
 * _debug() is kept as a compatibility shim for plugins
6 years ago
Andrew Dolgov b2f0858060 sanity config: fix typo 6 years ago
Andrew Dolgov d5256c8228 update sanity_config.php 6 years ago
Andrew Dolgov 5f66f872b6 fix session write handler always assuming that database entry exists and failing silently if it doesn't; remove session cookie-related hacks 6 years ago
Andrew Dolgov d246fb9fe1 remove session REMOTE_ADDR checks 6 years ago
Andrew Dolgov f8fc1ac543 login: check for stale session in login handler, instead of authenticate_user() 6 years ago