Commit Graph

29 Commits (84b847074ef654a0ab5e49a3f33825e8b6d6c7c8)

Author SHA1 Message Date
Michael Kuhn e38fcd6dea Fix button focus issues
This change introduces derived classes for ComboButton, DropDownButton
and Select that make sure that buttons do not remain focused after their
menus are closed. This allows using hotkeys after closing them.
6 years ago
Michael Kuhn 4a2a90c980 Fix focus issues with hotkeys
Since making use of keypress in addition to keydown, hotkeys did not
work in certain scenarios, including clicking on the feed tree expanders
or empty spaces of the toolbar.

This issue is caused by dijit.Tree and dijit.Toolbar implementing the
_KeyNavMixin, which explicitly stops propagation of keypress events.

This change contains two main fixes plus a smaller hotfix:
1. It overrides _onContainerKeydown and _onContainerKeypress for
   fox.FeedTree (which inherits from dijit.Tree).
2. It adds fox.Toolbar, which overrides _onContainerKeydown,
   _onContainerKeypress and focus. This fixes hotkeys being swallowed
   and the first focusable child receiving focus when clicking on an
   empty space of the toolbar.
3. It adds the same handling of keydown and keypress to the prefs hotkey
   handler as is done in the main hotkey handler.
6 years ago
Andrew Dolgov 335147e572 dialogs: use semantic markup instead of dlgsec stuff
continue unifying quoting style for html strings
6 years ago
Andrew Dolgov 063b4f535a filter rule & label dialog updates 6 years ago
Andrew Dolgov 93dfdb2fcd exp: tweak headline label styles 6 years ago
Andrew Dolgov a68b150601 remove separate classes for various panels, unify under .panel
remove a few other unnecessary css classes/ids
6 years ago
Andrew Dolgov fd10614f5d labels: unfortunately we can't rely on caption to selectively clear label_cache (because of json unicode encoding) so clean it completely if label is updated 6 years ago
Andrew Dolgov 0a41c1a6e1 update label rendering (and editor) 6 years ago
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 6 years ago
wn_ 6f9307aa9a Also fix the 'Create label' `onclick` 6 years ago
Andrew Dolgov f26d404890 prefs: move other tree-related functions to respective trees 6 years ago
Andrew Dolgov 2e985d1733 move some label helper functions to prefLabelTree 6 years ago
Andrew Dolgov 6fb5ce5e35 add some primary dialog actions; update css 7 years ago
Andrew Dolgov 5f7be9957f filter,label dlg: use default action 7 years ago
Andrew Dolgov e6532439d6 force strip_tags() on all user input unless explicitly allowed 7 years ago
Andrew Dolgov 21295a52aa labels: PDO 7 years ago
Andrew Dolgov 7c9b5a3fe4 move label stuff to Labels class
fix some unresolved functions
8 years ago
Andrew Dolgov ea79a0e033 remove some redundant php closing tags 8 years ago
Andrew Dolgov 328118d12e use print_hidden() for hidden dojo form fields 8 years ago
Andrew Dolgov 67f3e3f942 pref-labels: remove obsolete searching code 9 years ago
Andrew Dolgov 1ffe3391f9 make pluginhost a singleton 12 years ago
Andrew Dolgov d9c85e0f11 classes: use OO DB interface 12 years ago
Andrew Dolgov a42c55f02b fix blank character after opening bracket in function calls 12 years ago
Andrew Dolgov 6322ac79a0 remove $link 12 years ago
Andrew Dolgov a5680acbe8 replace split with explode 12 years ago
Andrew Dolgov 3972bf5981 db_escape_string: specify link parameter for consistency; sessions: do not force-close db connection in _close() 12 years ago
Andrew Dolgov 6065f3ad63 add support for plugins in prefs 12 years ago
Andrew Dolgov 6aff784575 implement multiple rule/action filters 12 years ago
Andrew Dolgov 369dbc19d6 rework class system to use subdirectories
add placeholder plugin/hook system
12 years ago