Commit Graph

218 Commits (78f1116d38b84a4d1809628e664c3da3607ad53f)

Author SHA1 Message Date
Andrew Dolgov 337535416f filter by search results while marking feed as read 7 years ago
Andrew Dolgov 63f0ed3d9c cdmClicked: do not use event.target.parents to figure out if clicked on a heading 7 years ago
Andrew Dolgov 1bfe1d7b31 simplify error handling
* less convoluted exception dialogs
* use window.onerror for the majority of exception catching/reporting
* remove most of now useless try/catch blocks
* report stacktrace instead of manually specified error locations
7 years ago
Andrew Dolgov b835a52814 rework the way headlines menus identify calling row 7 years ago
Andrew Dolgov 5161460048 bind headlines menu to a selector to avoid remaking it unnecessarily 7 years ago
Andrew Dolgov 20deb5fc32 cdmcollapse/expand: use less convoluted selector queries 7 years ago
Andrew Dolgov 829d478f1b add some protection against opener attacks if external site is opened via window.open() 7 years ago
Andrew Dolgov ad326dbf78 unpackVisibleHeadlines: do not iterate over all RROWs all the time 8 years ago
Andrew Dolgov 3bc1b53772 initHeadlinesMenu: remove unneeded output 8 years ago
Andrew Dolgov 974c6eb523 attach headline menu objects to correct DOM nodes in combined mode 8 years ago
Andrew Dolgov e1f7b05b52 reuse menu objects while appending headline rows 8 years ago
Anders Kaseorg 88946d331a Replace all setTimeout strings with functions
This fixes a cross-site scripting vulnerability.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
8 years ago
Andrew Dolgov b6b5554db4 normalize some html5 custom attributes 8 years ago
Andrew Dolgov 2d052e42b5 getLoadedArticleIds: consider visible rows only
catchupFeedInGroup: hide articles when catching up, with caveats
8 years ago
Andrew Dolgov 6be118fda1 showArticleInHeadlines: remove unused code 8 years ago
Andrew Dolgov c4e211046e updateFloatingMenu: performance improvements 8 years ago
Andrew Dolgov d7cc5e6cdd fix previous 8 years ago
Andrew Dolgov 63c7446a79 headlines scroll handler: add a rate limit 8 years ago
Andrew Dolgov 7c0d68f207 remove dismiss* functions 8 years ago
Andrew Dolgov 6056d164fa cleanup dismissArticle functions 8 years ago
Kostiantyn Moroz 2757c49387 Make "open in new tab" hotkey handler support mac "cmd+click" way (non-expanded mode) 9 years ago
Andrew Dolgov 0b41bd3414 add some hacks to hopefully mitigate headlines memory leaks 9 years ago
Andrew Dolgov a71e571b97 headlines_callback2: force prevent duplicate row ids 9 years ago
Andrew Dolgov a0dbc45acd add edit feed to feed header context menu in grouped mode 9 years ago
Andrew Dolgov 6b0a17ad8b viewfeed: switch to hash-based arguments
viewfeed: remove (obsolete) method parameter
add shortcut to debug viewfeed() query
9 years ago
Andrew Dolgov 6810a1de42 use dijit form widget for attachments dropdown 9 years ago
Andrew Dolgov 176a489e54 use batch-based catching up in cdmExpandArticle() to reduce server load 9 years ago
Andrew Dolgov eaec06f950 prevent cyclical scrolling in headlines if next offset requested by infscroll is zero
a bunch of other related fixes
9 years ago
Andrew Dolgov 95b493d68d partially revert previous because of navigation breakage in expanded mode, durrr 9 years ago
Andrew Dolgov b71add41d5 unfuck catchupbatchedarticles a bit 9 years ago
Andrew Dolgov 8292123ebc assorted fixes for keyboard navigation which hopefully don't break everything else 9 years ago
Andrew Dolgov 231c672c5d fix previous 9 years ago
Andrew Dolgov 837443630f infscroll: preload articles a bit earlier 9 years ago
Andrew Dolgov d8e8e24e34 pass DOMNodes instead of escaped html data to JS article rendered hooks (i think this makes much more sense) 9 years ago
Andrew Dolgov 8691b32abf disable headline appear animation 9 years ago
Andrew Dolgov d46af5a5cf headlines scroll handler: make preloading less aggressive 9 years ago
Andrew Dolgov e7a66d1230 (experimental) disable infscroll requests while marking auto catched up articles as read 9 years ago
Andrew Dolgov 33c4bd8968 fix error feed (i.e. when requested feed no longer exists) not display properly 9 years ago
Andrew Dolgov f17069960c roll back separate headline transport 9 years ago
Andrew Dolgov 57c521df91 maybe speedup headline adding a bit, maybe not 9 years ago
Andrew Dolgov 9ef1985f1b viewfeed.js: cleanup the code a bit 9 years ago
Andrew Dolgov ac4c1383ae bring cdmFeedTitle style in line with the rest of the UI
send headline rows as separate JSON objects
9 years ago
Andrew Dolgov 48fefe2f6b fixes for first_id stuff 9 years ago
Andrew Dolgov 39d488a256 viewfeed: set hsp status when scrolling to the very end 9 years ago
Andrew Dolgov 15ae8cd084 js: remove current_top_id global 9 years ago
Andrew Dolgov 3444020100 report top id changed in headlines buffer 9 years ago
Andrew Dolgov f5a0fb8b64 queryFeedHeadlines: move to array-based arguments, optionally check if first element changed when paginating 9 years ago
Andrew Dolgov 5a45821ec9 prevent event propagation when clicking on CDM article footer 9 years ago
Andrew Dolgov a72cd54ce1 bayes: properly reset score when going good -> ugly
article: add helper to refresh article score pic, properly set scorepic title
9 years ago
Anders Kaseorg 5c145bde7a Make the floating title transition smoother
Previously the floating title would not appear until the real title
scrolled entirely out of view, which was visually distracting.  Now it
appears at the point when its bottom lines up with the real title’s
bottom.  This isn’t perfect yet due to small differences between the
two titles’ layouts, but it’s much closer.

We now need to use visibility: visible|hidden instead of display:
block|none to show and hide the floating title, in order to be able to
retrieve its height while it’s hidden.  It’s important to use that
height because occasionally line wrapping differences make the
floating title shorter than the real title, and we don’t want the real
title to poke out from underneath.

Also fix scrollToRowId to offset by the 4 pixel top margin (like
cdmScrollToArticleId already does), so that it goes back to a point
when the floating title was hidden; and set the right margin on the
floating title so that it’s the same width as the real title and
doesn’t overlap the scroll bar.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
10 years ago