Commit Graph

56 Commits (6f29ecbbb96440552f434f5f487b96753bdb02df)

Author SHA1 Message Date
wn_ 1bd5152c80 Open the default feed after unsubscribing.
Previously the UI appeared to hang, even though the backend request had already completed successfully.
4 years ago
Andrew Dolgov 737cffc241 render feed icon markup on the client 4 years ago
Andrew Dolgov 660a1bbe01 * switch to xhr.post() almost everywhere
* call App.handlerpcjson() automatically on json request (if possible)
 * show net/log indicators in prefs
4 years ago
Andrew Dolgov bb4e4282f4 migrate a bunch of xhrPost invocations 4 years ago
Andrew Dolgov 6b43b788d9 migrate xhrJson invocations to the new helper 4 years ago
Andrew Dolgov 00310d2d23 cleanup some unused code, fix App.byId() invoked by wrong name 4 years ago
Andrew Dolgov 70fa423026 initial for RIP prototype/scriptaculous 4 years ago
Andrew Dolgov b16abc157e * App: rename hidden to hidden_tag
* search: use client dialog
 * add some form field helpers
4 years ago
Andrew Dolgov 020f062a76 feeds: unify naming 4 years ago
Andrew Dolgov 3d11c61f32 * OPML import: don't reload everything, just feed tree
* dialogs: use auto-destroying dialog for almost all dialogs instead of destroying them manually
* some general dialog-related cleanup
4 years ago
Andrew Dolgov 72e38bfe1f rework a few more dialogs to use App.dialogOf() 4 years ago
Andrew Dolgov d466284fab * customizeCSS: client dialog
* remove hardcoded width from most dialogs (move to css)
* add helper to easily get dialog from its widget
* rework some dialog buttons to use current object instead of calling dialog by name
4 years ago
Andrew Dolgov 1a680d4eae publishedOPML: use client dialog 4 years ago
Andrew Dolgov 848bc57f29 disable themes in safe mode; rework safe mode warning/login prompt 4 years ago
Andrew Dolgov 57f36f3f97 search dialog: populate current search values onShow instead of onLoad because the dialog is preloaded via xhr 4 years ago
Andrew Dolgov 87184904ed don't select next unread feed when marking as read last week, etc. 4 years ago
Andrew Dolgov f693ebab21 fix default password nag dialog, load via xhr 4 years ago
Andrew Dolgov cbcb10a272 Feeds: load quickaddfeed and search dialogs via XHR w/ CSRF protection 4 years ago
Andrew Dolgov 697418f863 more eslint fixes 5 years ago
Andrew Dolgov 88027d7a39 fix various minor issues reported by eslint 5 years ago
Andrew Dolgov 9d28b3ac50 unify prefs/main App objects, remove fake classes, use single static App object instead 5 years ago
Andrew Dolgov e37f8cfa78 don't use declare() for static objects with no inheritance because apparently it's not actually needed by AMD 5 years ago
Andrew Dolgov 2d3fdd6836 hide read feeds / hide read shows special: use CSS instead of JS-based hiding 5 years ago
Andrew Dolgov 776fe4768b default password warning: fix close button, don't crash if dialog is recreated (on feed tree reload etc) 5 years ago
Andrew Dolgov 6f625aa8aa apply Has_Marked css class to feed tree elements with marked articles 5 years ago
Andrew Dolgov 9c0235ab66 show current unread counter on headlines toolbar if sidebar is hidden 5 years ago
Andrew Dolgov 5b4eb8d7b9 remove unnecessary "== 1" when checking for init params
unsubscribeFeed: check for undefined title correctly
5 years ago
Andrew Dolgov 079ef15b1b previous: remove unused debugging line 6 years ago
Andrew Dolgov 905f038610 search dialog: display active query if searching already 6 years ago
Andrew Dolgov 3bf40f3ba8 _active_feed_id: set to undefined on startup to prevent unneeded Feed.open() if reloadCurrent is called because of a non-default main toolbar value 6 years ago
Andrew Dolgov 9368f1a07f restore feed from URL hash after feedlist init 6 years ago
Andrew Dolgov 6479c07324 js: add PluginHost.HOOK_COUNTERS_PROCESSED 6 years ago
Andrew Dolgov 2411cc8d1c js: add PluginHost.HOOK_COUNTERS_RECEIVED 6 years ago
Michael Kuhn e74f7bde22 Refactor hotkeys to use keypress instead of keydown
keydown returns the "raw" key in event.which. Depending on the keyboard
layout, this may not be what is wanted. For example, on a German
keyboard, Shift+7 has to be pressed to get a slash. However, event.which
will be 55, which corresponds to "7". In the keypress event, however,
event.which will be 47, which corresponds to "/".

Sadly, several important keys (such as escape and the arrow keys) do not
trigger a keypress event. Therefore, they have to be handled using a
keydown event.

This change refactors the hotkey support to make use of keypress events
whenever possible. This will make hotkeys work regardless of the user's
keyboard layout. Escape and arrow keys are still handled via keydown
events.

There should be only one change in behavior: I could not make Ctrl+/
work and therefore rebound the help dialog to "?".
6 years ago
Andrew Dolgov 6e14e575b3 use separate id for default password warning dialog 6 years ago
Andrew Dolgov 8effabd075 append headline buffer if requested, don't just use offset 6 years ago
Andrew Dolgov d53cdaf815 requestCounters: remove cooldown 6 years ago
Andrew Dolgov d9bf0f17c6 sync unread state to server via mutation observer 6 years ago
Andrew Dolgov dc84e10ba1 catchupFeedInGroup: overhaul
1. less hacky way to catchup actually unread headlines
2. don't fade rows away because it's inconsistent with different mark-as-read functions
3. fix stuck progress alert
6 years ago
Andrew Dolgov 76885fc5ad viewfeed: general code cleanup 6 years ago
Andrew Dolgov 8f75b06835 implement feed grouping display, remove unneeded server vgrlf passing 6 years ago
Andrew Dolgov e075e6141b json-viewfeed updates 6 years ago
Andrew Dolgov b09a58a570 call Headlines.scrollhandler() on window resize 6 years ago
Andrew Dolgov f89ecda9b8 Feeds.updateRandom: fix calling wrong RPC method 6 years ago
Andrew Dolgov 05200a3840 rename main toolbar elements to be more consistent 6 years ago
Andrew Dolgov 85adef06f4 onkeydown handlers: fix default keyboard events not being blocked if necessary 6 years ago
Andrew Dolgov 9814ac608c Headlines.click: do not set article active if it already is
Headlines.onLoaded: reset active article if not called in append mode
6 years ago
Andrew Dolgov 71fc6d45bd refactor error reporting to AppBase; keep exception_error() for now as a shim 6 years ago
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
6 years ago
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 6 years ago