Commit Graph

659 Commits (master)

Author SHA1 Message Date
Andrew Dolgov 481bd76100 pref helpers: move some methods to their own sections 3 years ago
Andrew Dolgov 6af83e3881 drop ENABLE_GZIP_OUTPUT; system prefs: load php info only if needed 3 years ago
Andrew Dolgov 157675d9fd prefs: fix published shared URL dialog 3 years ago
Andrew Dolgov 03b85248e6 move some dialogs to xhr loading 3 years ago
Andrew Dolgov 3268364693 more dialog-related cleanup 3 years ago
Andrew Dolgov 3d11c61f32 * OPML import: don't reload everything, just feed tree
* dialogs: use auto-destroying dialog for almost all dialogs instead of destroying them manually
* some general dialog-related cleanup
3 years ago
Andrew Dolgov 8f8675a26a * filters: remove duplicate code, overall cleanup
* check if some tres exist before trying to reload them
3 years ago
Andrew Dolgov 0f7af07c6e edit filter dialog: cleanup 3 years ago
Andrew Dolgov 20fb056323 remove customizecss from csrf-ignored methods 3 years ago
Andrew Dolgov bf6d0f2817 various dialog-related fixes; stop referring to many dialogs by name; move filter test initial dialog to client side 3 years ago
Andrew Dolgov 72e38bfe1f rework a few more dialogs to use App.dialogOf() 3 years ago
Andrew Dolgov d466284fab * customizeCSS: client dialog
* remove hardcoded width from most dialogs (move to css)
* add helper to easily get dialog from its widget
* rework some dialog buttons to use current object instead of calling dialog by name
3 years ago
Andrew Dolgov 83b0738b04 opml import: no more iframe, use client dialog 3 years ago
Andrew Dolgov 3134d71b8f fix typo introduced by 4182018cb7 3 years ago
Andrew Dolgov 4182018cb7 generated feed: use client dialog 3 years ago
Andrew Dolgov 1a680d4eae publishedOPML: use client dialog 3 years ago
Andrew Dolgov 09e9f34bb4 add UserHelper::find_user_by_login() and rewrite some user checks to invoke it instead of going through PDO 3 years ago
Andrew Dolgov 7af8744c85 authentication: make logins case-insensitive (force lowercase) 3 years ago
Andrew Dolgov e7e73193fe fix warning in profile edit dialog (2) 3 years ago
Andrew Dolgov 2505ae43a9 fix warning in profile edit dialog 3 years ago
Andrew Dolgov 9e1459d5db pref/prefs: fix warning when in non-default profile 3 years ago
Andrew Dolgov d630a92c40 fix 2 warnings in feed editor 3 years ago
Andrew Dolgov 345dbb3521 rewrite some more hooks 3 years ago
Andrew Dolgov fc2e0bf67b log viewer: disable previous page on page 1 3 years ago
Andrew Dolgov 3b52cea811 move some old-style handlers to new callback ones 3 years ago
Andrew Dolgov 1d5c8ee500 prefs: fix user plugins shown by incorrect criteria 3 years ago
Andrew Dolgov 1eb1629d9e pluginhost: rework run_hooks() to be shorter, add callback variant; implement exception handling for both 3 years ago
Andrew Dolgov d293cbd5a9 fix several warnings related to feed editor 3 years ago
Andrew Dolgov ce2335deaf pref-users: css fixes 3 years ago
Andrew Dolgov d8de10d78a error log: fix severity dropdown 3 years ago
Andrew Dolgov 73e697a0df fix some warnings in prefs (filters, users) 3 years ago
Andrew Dolgov 73070544ca error log: make it more readable 3 years ago
Andrew Dolgov 5cfc5914f2 log viewer: show total pages 3 years ago
Andrew Dolgov 10392ecc28 event log: add pagination 3 years ago
Andrew Dolgov a544123b59 fix clean() for arrays and user plugin list 3 years ago
Andrew Dolgov 6e774a58fe more php8 fixes mostly related to login 3 years ago
Andrew Dolgov 403dca154c initial WIP for php8; bump php version requirement to 7.0 3 years ago
Andrew Dolgov da0ad82c24 Archive cleanup:
- remove code to manually archive/unarchive articles
- remove ttrss_archived_feeds/orig_feed_id handling - the whole thing was implemented for
this data to be kept indefinitely; it doesn't make a lot of sense to deal with this stuff
now that it is expired after one month anyway (same reasons as feed browser being removed - privacy)
- remove "originally from"-related stuff because of the above
- also remove unused remaining frontend/backend code related to feed browser (rip)
3 years ago
Andrew Dolgov 40f38fc87f pluginhost: load plugin data automatically (also marks load_data method as private) 3 years ago
Andrew Dolgov 33a5ecd2ce feed editor: show purge interval correctly if FORCE_ARTICLE_PURGE is set 3 years ago
Andrew Dolgov 8cc07bc8bd event log: add severity filtering 3 years ago
Andrew Dolgov 6da576dbe4 BLACKLISTED_TAGS: use textarea for editing; normalize value when saving 3 years ago
wn_ d2db58de4f Switch from 'vsprintf' to 'sprintf' in another place. 4 years ago
fox ef7e679363 Merge branch 'feature/php8' of wn/tt-rss into master 4 years ago
Andrew Dolgov 9b7338e807 feed editor: properly show global purging interval as disabled 4 years ago
wn 62da307ef1 Use correct 'sprintf' function and other minor fixes in Pref_Feeds. 4 years ago
wn a1f8d6941b Remove duplicate block in 'classes/pref/filters.php'.
Also a minor tweak to getting the search filter.
4 years ago
wn 8c4ca7c8ef Fix some 'isset' checks in 'classes/pref/prefs.php'. 4 years ago
Andrew Dolgov 8089fcc762 feed editor: also show default value for purge interval 4 years ago
Andrew Dolgov d48460969d feed editor: show actual value of default update interval 4 years ago
Andrew Dolgov d1ee30d1ba prevent horizontal scrolling in filter editor dialog if rules are very long 4 years ago
Andrew Dolgov 215f388992 move timestamp-related stuff to a separate class 4 years ago
Andrew Dolgov 6811d0bde2 use self:: in some places to invoke static methods from the same class 4 years ago
Andrew Dolgov 74568df4ff remove a lot of stuff from global context (functions.php), add a few helper classes instead 4 years ago
Andrew Dolgov 03a337a660 add basic safe mode which doesn't load any user plugins 4 years ago
Andrew Dolgov a4525d31b2 replace FALSE with false so that static analyzer shuts up about it 4 years ago
Andrew Dolgov 89d53a7f49 fix typo in previous 4 years ago
Andrew Dolgov 1f79d614c4 fix OTP QR code not displayed because of CSRF token passed as a query
parameter
use type-strict comparison when validating CSRF token on the backend
4 years ago
Andrew Dolgov 33fdde249e pass CSRF token to opml import and feed icon replace dialogs 4 years ago
Andrew Dolgov 4a074111b5 user preferences: forbid < and > characters when changing passwords (were silently stripped on save because of clean()) 4 years ago
Andrew Dolgov c3d14e1fa5 - fix multiple vulnerabilities in af_proxy_http
- fix vulnerability in rewrite_relative_url() which prevented some URLs from being properly absolutized
- fetch_file_contents: validate all URLs before requesting them
- validate URLs: explicitly whitelist http and https scheme, forbid everything else
- DiskCache/cached_url: only serve whitelisted content types (images, video)
- simplify filename/URL handling code, remove and consolidate some less-used functions
4 years ago
Andrew Dolgov fa653f5a43 prefs: show disabled filters properly on mysql 4 years ago
Andrew Dolgov 2996a3942f prefs: show root of filter tree as enabled so it's not grayed out 4 years ago
Andrew Dolgov d01ad09800 eslint-related fixes; move a few things from global context to App 4 years ago
Andrew Dolgov c8cc845d5b when removing favicon, reset its auto-refresh timer 4 years ago
Andrew Dolgov 1f2a721905 allow overriding built-in templates via templates.local 4 years ago
Andrew Dolgov bcbc5ccc78 batchSubscribe: use validationtextarea 4 years ago
Andrew Dolgov f24ece85a6 add validationtextarea control, use it for filter match editor 4 years ago
Andrew Dolgov 8645f36c5b filter test dialog: pass contents via xhr POST 4 years ago
Andrew Dolgov 4ab3854aed don't generate default.css, replace with themes/light.css as a default root CSS file 4 years ago
Andrew Dolgov 60288f02e8 1. feedtree: show counters for marked articles if view-mode == marked
2. hide/show relevant counter nodes using css
3. cleanup some counter-related code
4. compile default css into light theme to prevent cache-related issues
4 years ago
Andrew Dolgov 5b6d9cee29 prefs layout fixes:
1. prevent layout breakage when using an authenticator which doesn't allow changing passwords
2. show explanatory messages when OTP or password changing is not available
3. allow app (API) passwords when using any auth module
4 years ago
Andrew Dolgov 6080cca9ca scrap counter cache system; rework counters to sum() booleans instead 4 years ago
Andrew Dolgov df464e3d0d update app password notice 5 years ago
Andrew Dolgov 76dd74e0d9 add a hidden tweakable which forbids changing passwords 5 years ago
Andrew Dolgov ac95ab4a65 user css dialog: allow saving and applying CSS without closing the dialog 5 years ago
Andrew Dolgov 63ce7ea705 add a plugin page warning for plugins using HOOK_FEED_FETCHED, etc 5 years ago
Andrew Dolgov f75fb6bd75 Merge branch 'master' of git.fakecake.org:tt-rss 5 years ago
Andrew Dolgov 266a805bfe line endings + remove : from headings 5 years ago
Andrew Dolgov 05dffcff6f OTP stuff: update notice wording a bit 5 years ago
Andrew Dolgov 812a6c9f16 auth_internal: fix indents 5 years ago
Andrew Dolgov 249130e58d implement app password checking / management UI 5 years ago
Andrew Dolgov 88cd9e586e add placeholder UI plumbing for app passwords 5 years ago
Andrew Dolgov 904ecc31e2 allow using OTP without GD 5 years ago
Andrew Dolgov 2820f41a4b add notification for OTP being disabled 5 years ago
Andrew Dolgov ef514bc4bd add notifications for mail and password changes
update and shorten some other message templates
5 years ago
Andrew Dolgov 12a542977e makefeedtree: properly calculate feed total amount in no-categories mode 5 years ago
Andrew Dolgov 6825aaff55 update SSL certificate wiki link 5 years ago
Andrew Dolgov e8523733b0 filter dialog: add inline regexp checker 5 years ago
Andrew Dolgov 86a014f23b add placeholder Filters.filterDlgCheckRegExp 5 years ago
Andrew Dolgov 088fcf8131 move more globals to more appropriate places
set libxml to always use internal errors
5 years ago
Andrew Dolgov 4fa9aee4e7 move several more global functions to more appropriate classes 5 years ago
Andrew Dolgov 6d746453c7 get_feeds_from_html: remove XML preamble hack
move several related helper functions to Feeds class
5 years ago
Andrew Dolgov d36b64d8a7 event log: simplify styles, prevent horizontal scrolling
sql logger: clip context length to 8kb
5 years ago
Andrew Dolgov 4b74491b8b feed tree: set placeholder feed unread value to -1 5 years ago
Michael Kuhn e38fcd6dea Fix button focus issues
This change introduces derived classes for ComboButton, DropDownButton
and Select that make sure that buttons do not remain focused after their
menus are closed. This allows using hotkeys after closing them.
5 years ago
Michael Kuhn 4a2a90c980 Fix focus issues with hotkeys
Since making use of keypress in addition to keydown, hotkeys did not
work in certain scenarios, including clicking on the feed tree expanders
or empty spaces of the toolbar.

This issue is caused by dijit.Tree and dijit.Toolbar implementing the
_KeyNavMixin, which explicitly stops propagation of keypress events.

This change contains two main fixes plus a smaller hotfix:
1. It overrides _onContainerKeydown and _onContainerKeypress for
   fox.FeedTree (which inherits from dijit.Tree).
2. It adds fox.Toolbar, which overrides _onContainerKeydown,
   _onContainerKeypress and focus. This fixes hotkeys being swallowed
   and the first focusable child receiving focus when clicking on an
   empty space of the toolbar.
3. It adds the same handling of keydown and keypress to the prefs hotkey
   handler as is done in the main hotkey handler.
5 years ago
Andrew Dolgov ed22473272 feed editor: use DEFAULT_SEARCH_LANGUAGE as a default per-feed dropdown value 5 years ago
Andrew Dolgov c936cc3a1f use DEFAULT_SEARCH_LANGUAGE to generate tsvector index if per-feed language is not specified, also use it as default value on search form for convenience 5 years ago
Andrew Dolgov 019f4578bc fix feed icon upload not working, rework form to use FormData/ajax 5 years ago
Andrew Dolgov 241d646fba batch subscribe: stop dialog from being submitted twice 5 years ago
Andrew Dolgov 19f162dbe3 css: insensitive -> text-muted 5 years ago
Andrew Dolgov 371325a899 remove feed editor private checkbox 5 years ago
Andrew Dolgov 38e01270d8 archived feeds: expire old entries (schema bump) 5 years ago
Andrew Dolgov 16a9bdc387 make_password: generate longer passwords by default, use better random function if available 5 years ago
Andrew Dolgov ef6d2b8a4e update notifications to make them more visible
cleanup some minor stuff in pref-users
5 years ago
Andrew Dolgov 1f2c769c5a editfeed: mark save button 5 years ago
Andrew Dolgov b9309b1822 filters: show inverse status in list 5 years ago
Andrew Dolgov a130da2d1a add layout hack to unify heights of plugin fieldsets 5 years ago
Andrew Dolgov 8819272db1 prefs-set -> prefs 5 years ago
Andrew Dolgov cbd119c7a3 pref-prefs: fix markup 5 years ago
Andrew Dolgov 52d77dee62 plugin list: update layout 5 years ago
Andrew Dolgov 7724aa9b7c pref-users: fix typo which stopped search from working; quote style stuff 5 years ago
fox e72243edfd Merge branch 'master' of DLange/tt-rss into master 5 years ago
Andrew Dolgov dab81ff7d0 feed editor: fix missing <section> breaking checkbox fieldsets 5 years ago
DLange a539baece2 Fix warning after icon has successfully been moved. 5 years ago
Andrew Dolgov a0636ccc90 Revert "Fix warning after icon has successfully been moved."
This reverts commit 8b73b9812d.
5 years ago
Andrew Dolgov e535a063ca Merge branch 'master' of git.tt-rss.org:fox/tt-rss 5 years ago
Andrew Dolgov 335147e572 dialogs: use semantic markup instead of dlgsec stuff
continue unifying quoting style for html strings
5 years ago
DLange 8b73b9812d Fix warning after icon has successfully been moved. 5 years ago
Andrew Dolgov 7dbf63693b prefs small update 5 years ago
Andrew Dolgov c2fa0c4416 try to organize preferences better, shorten some descriptions 5 years ago
Andrew Dolgov 4e253add8c UI: add some more info links to relevant wiki pages; minor layout updates 5 years ago
Andrew Dolgov c78425b386 feed edit dialog: add interval label 5 years ago
Andrew Dolgov 1dbfbcfae1 batchSubscribe: use common markup 5 years ago
Andrew Dolgov 4db13b8a17 simplify preference layout, remove some unnecessary css classes 5 years ago
Andrew Dolgov 3880a17e57 pref-prefs: rework personal info tab, remove ugly table markup 5 years ago
Andrew Dolgov 580f8c0883 enlarge feed title 5 years ago
Andrew Dolgov f8836ec080 search dialog fixes
pgsql: get FTS languages list from the database
5 years ago
Andrew Dolgov 063b4f535a filter rule & label dialog updates 5 years ago
Andrew Dolgov 4d9141d762 simplify dlgSec-related markup 5 years ago
Andrew Dolgov 205a75dfb9 prefs: show phpinfo on system tab 5 years ago
Andrew Dolgov c11f32ac38 center and rework some utility screens 5 years ago
Andrew Dolgov 734af3357d fix user plugins not saving properly in non-default profiles 6 years ago
Andrew Dolgov 51b069a1ee display filter tree rules as a list 6 years ago
Andrew Dolgov 5f1b39f7dc filter tree: don't crash on search, also search by filter titles 6 years ago
Andrew Dolgov 8c49689fda filter test results: remove table bloat 6 years ago
Andrew Dolgov b6a021461d add night_base so that output files would generate properly, etc 6 years ago
Andrew Dolgov be49b77b14 Revert "use codeflask for user css editor"
This reverts commit daa43e0572.
6 years ago
Andrew Dolgov 66d3dcbc7d update user css info line 6 years ago
Andrew Dolgov daa43e0572 use codeflask for user css editor 6 years ago
Andrew Dolgov 93dfdb2fcd exp: tweak headline label styles 6 years ago
Andrew Dolgov 703351c79e remove theme supports-version etc checking 6 years ago
Andrew Dolgov a68b150601 remove separate classes for various panels, unify under .panel
remove a few other unnecessary css classes/ids
6 years ago
Andrew Dolgov 4fdcc923f0 prefs: reload on user theme change 6 years ago
Andrew Dolgov 3e4326e34d add ttrss_filters2.last_triggered (bump schema version) 6 years ago
Andrew Dolgov 0b8cbc9156 remove some bitmaps and rework stuff using it to use iconfont instead 6 years ago
Andrew Dolgov 15d05e8a26 night.css: do not import default less theme statically
remove themes/default.php (not needed)
compact.css: fixes
6 years ago
Andrew Dolgov 4aa11fe78d set some alt-info buttons; fix missing default submit for create filter dialog 6 years ago
Andrew Dolgov 814e49f8f7 add icons to accordion panels in preferences
fix typo in pref-prefs closing panel tag
6 years ago
Andrew Dolgov fd10614f5d labels: unfortunately we can't rely on caption to selectively clear label_cache (because of json unicode encoding) so clean it completely if label is updated 6 years ago
Andrew Dolgov 0a41c1a6e1 update label rendering (and editor) 6 years ago
Andrew Dolgov 19e24b4fe2 force cast profile id to integer when assigning to session variable 6 years ago
Andrew Dolgov a0b1664620 prefs: change user icon 6 years ago
Andrew Dolgov cad6d1d7fd various icon updates; use new icons in feed tree 6 years ago
Andrew Dolgov 8c5c762a85 some more icon styling updates + user control panel 6 years ago
Andrew Dolgov f3e6e12d46 various minor updates re: icons 6 years ago
Andrew Dolgov b16c57d29c replace plugin.png with scalable icon 6 years ago
Andrew Dolgov 6befff30d7 updates for flat theme (mostly disable old dijit overrides) 6 years ago
Andrew Dolgov f81df37c36 wrap plugin list into border container, like prefs (2) 6 years ago
Andrew Dolgov 0880100f6a wrap plugin list into border container, like prefs 6 years ago
Andrew Dolgov 31e79317b3 normalize various font sizes and families between prefs & main UI
change some dialogs layout a bit to maybe become more readable
6 years ago
Andrew Dolgov 197e80add6 fix several issues related to profile being set to a non-numeric value 6 years ago
Andrew Dolgov 4d4034091a prefs: Prefs global -> Helpers 6 years ago
Andrew Dolgov b3bc638a9f refactor OPML export/import code to be less horrible 6 years ago
wn_ 6f9307aa9a Also fix the 'Create label' `onclick` 6 years ago
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 6 years ago
Andrew Dolgov eeb49d375c uploadIconHandler -> CommonDialogs 6 years ago
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 6 years ago
Andrew Dolgov d9c5c93cef move some more stuff out of common.js
rework client-side cookie functions a bit
limit dojo cachebust based on server scripts modification time
remove param_escape()
6 years ago
Andrew Dolgov 3a6dae9203 prefs: more of the same, really 6 years ago
Andrew Dolgov b9869dbc01 prefs: remove some more stuff from global context (user management, etc) 6 years ago
Andrew Dolgov 58e54282d3 prefs: move more global functions into matching classes 6 years ago
Andrew Dolgov f26d404890 prefs: move other tree-related functions to respective trees 6 years ago
Andrew Dolgov 60cd467694 embed some pref-feed helper functions into the tree 6 years ago
Andrew Dolgov 2e985d1733 move some label helper functions to prefLabelTree 6 years ago
Andrew Dolgov e23b6e397d prefs: store active tab for reload, remove most old table row functions 6 years ago
Andrew Dolgov 874560db54 remove obsolete row selection functions
move getUrlParam() to Utils
6 years ago
Andrew Dolgov 2f85b50e36 remove toggleSelectListRow2() 6 years ago
Andrew Dolgov 0a18d0b1ed Feeds: shorten some method names
finally rename "view as rss"
6 years ago
Andrew Dolgov 1e2d4410d3 move some more shared stuff to CommonDialogs, Filters, and Utils 6 years ago
Andrew Dolgov 4bed9be57d js-ification: start on some common dialogs 6 years ago
Andrew Dolgov 049a37aa0e WIP reshuffling of JS global context into separate logical objects 6 years ago
Andrew Dolgov 195180b64d minor refactoring: normalize some function names; cleanup; etc 6 years ago
Andrew Dolgov a2ef54cd92 toggleMark, togglePub: refactor implementation
shorten marked/published img CSS classes
6 years ago
Andrew Dolgov 9563e3bcd6 remove expandable CDM headlines 6 years ago
Andrew Dolgov ef129fed2a some more xhrPost refactoring (batchEditSave WIP) 6 years ago
Andrew Dolgov fc0a3050eb use xhrPost is even more places! 6 years ago
Andrew Dolgov c10a43069e debug logging system rework:
* support various logging levels per-message
 * remove hacks like debug_suppress, DAEMON_EXTENDED_DEBUG, etc
 * _debug() is kept as a compatibility shim for plugins
6 years ago
Andrew Dolgov 55bf4bc1d3 mailer: split to/from name/addresses 6 years ago
Andrew Dolgov 57932e1837 remove PHPMailer and related directives from config.php-dist; add pluggable Mailer class 6 years ago
Andrew Dolgov 3a0292303e php: remove trailing whitespaces 6 years ago
Andrew Dolgov d4fef36237 rewrite per-feed/global strip images to strip media 6 years ago
Andrew Dolgov 069aea5989 remove FEED_CRYPT_KEY and everything related to it
always assume auth_pass_encrypted is false
6 years ago
Andrew Dolgov 310c18e6bb move OTPHP to vendor/; additionally move Base32 class to OTPHP namespace 6 years ago
Andrew Dolgov 4fa64e8446 filter dialog: remove placeholder 6 years ago
Andrew Dolgov e794e434da filter dialog: add tooltip re: filter syntax 6 years ago
tsia 551f3c2c85 fixed "reset to defaults" in preferences 6 years ago
Andrew Dolgov 0a8cdd4b9c remove firefox feed subscribe integration code (obsolete) 6 years ago
Andrew Dolgov c9a5e5aa28 feed editor: expose site_url for editing 6 years ago