From 08ae2a5ba6b69b574c891a7fb3f88cab5d55b66f Mon Sep 17 00:00:00 2001 From: Craig Meyer Date: Sat, 30 Jul 2011 22:34:22 -0400 Subject: [PATCH] Extend OPML preferences pane, to provide more control of Export OPML User is prompted for filename, and also whether to include settings. Default filename is: TinyTinyRSS.opml modules/pref-feeds.php Prompt for output OPML filename (Default: TinyTinyRSS.opml ) opml.php Modify to support passing in name=&settings=[0|1] functions.js Modify to support passing in name=&settings=[0|1] --- functions.js | 5 +++-- modules/pref-feeds.php | 15 ++++++++++----- opml.php | 14 ++++++++++---- 3 files changed, 23 insertions(+), 11 deletions(-) diff --git a/functions.js b/functions.js index 335ed61ec..e8bd6af33 100644 --- a/functions.js +++ b/functions.js @@ -277,8 +277,9 @@ function gotoMain() { document.location.href = "tt-rss.php"; } -function gotoExportOpml() { - document.location.href = "opml.php?op=Export"; +function gotoExportOpml(filename, settings) { + tmp = settings ? 1 : 0; + document.location.href = "opml.php?op=Export&filename=" + filename + "&settings=" + tmp; } diff --git a/modules/pref-feeds.php b/modules/pref-feeds.php index e16fa9b13..947716e91 100644 --- a/modules/pref-feeds.php +++ b/modules/pref-feeds.php @@ -1440,16 +1440,21 @@ name=\"upload_iframe\" onload=\"opmlImportComplete(this)\" style=\"width: 400px; height: 100px; display: none;\">"; - print "
  - - -
"; + " . + "

" . __('Export Name: ') . + " " . + __('Include Settings? ') . "" . + + "

"; print "

".__('Your OPML can be published publicly and can be subscribed by anyone who knows the URL below.'); diff --git a/opml.php b/opml.php index 2e1eb84c6..991f93e0c 100644 --- a/opml.php +++ b/opml.php @@ -10,12 +10,14 @@ init_connection($link); - function opml_export($link, $owner_uid, $hide_private_feeds=false, $include_settings=true) { + function opml_export($link, $name, $owner_uid, $hide_private_feeds=false, $include_settings=true) { if (!$_REQUEST["debug"]) { header("Content-type: application/xml+opml"); } else { header("Content-type: text/xml"); } + header("Content-Disposition: attachment; filename=" . $name ); + print ""; print ""; @@ -119,14 +121,18 @@ // FIXME there are some brackets issues here $op = $_REQUEST["op"]; + if (!$op) $op = "Export"; + + $output_name = $_REQUEST["filename"]; + if (!$output_name) $output_name = "TinyTinyRSS.opml"; - if (!$op) $op = "Export"; + $show_settings = $_REQUEST["settings"]; if ($op == "Export") { login_sequence($link); $owner_uid = $_SESSION["uid"]; - return opml_export($link, $owner_uid); + return opml_export($link, $output_name, $owner_uid, false, ($show_settings == 1)); } if ($op == "publish"){ @@ -138,7 +144,7 @@ if (db_num_rows($result) == 1) { $owner_uid = db_fetch_result($result, 0, "owner_uid"); - return opml_export($link, $owner_uid, true, false); + return opml_export($link, "", $owner_uid, true, false); } else { print "User not found"; }