Commit Graph

5407 Commits (d5038ee5d910ffe200e5cad60ca407f615b2691d)

Author SHA1 Message Date
Thomas Bruederli 9675702579 Fix canned responses in HTML mode (#1489536) 11 years ago
Thomas Bruederli 90dc9b1512 Compare message IDs before suggesting to restore compose messages on reply 11 years ago
Aleksander Machniak 3509a8e5f8 Do not use rcube_config::all() 11 years ago
Aleksander Machniak 4da065e8a9 Check/create default folders on every login not only the first (#1489423) 11 years ago
Aleksander Machniak 2d3abfda48 Update to jQuery 1.11.0 11 years ago
Aleksander Machniak 3b1d410b4e Fix confusing intersect/filter methods naming/behaviour.
Removed rcube_result_index::intersect() method.
Changed rcube_result_index::filter() to filter in the same way as
rcube_result_thread::filter(), which means it actually does array_intersect().
Added tests scripts for rcube_result_index class.
11 years ago
Aleksander Machniak 5140c31064 Remove quotes around addressee name in case they are encoded.
Some clients encode quotes with name using base64/quoted-printable
encoding. Quotes were removed only for unencoded strings. Now also
encoded names are handled this way.
So, recipient/sender strings are displayed without quotes around
and e.g. saving to addressbook does not save these redundant quotes.
11 years ago
Aleksander Machniak c0dda0556c Allow single quote in style attribute values.
E.g. "font-family: 'Tahoma'" should not be removed.
11 years ago
Thomas Bruederli febcd4b225 Improve wording: don't pretend that mailbox is empty if search/filter doesn't find any messages 11 years ago
Aleksander Machniak a62c7392aa Add 'markfolder' event (#1485775) 11 years ago
Thomas Bruederli 4a7a861912 Apply the right flags for searching in all folders 11 years ago
Thomas Bruederli d93ce5cde2 Fix concurrent connections to IMAP while searching 11 years ago
Aleksander Machniak 357f9c831a Support SMTP socket context options via new config option 'smtp_conn_options' 11 years ago
Thomas Bruederli 19262e6eab Code cleanup: remove duplicated code, don't trigger multi-folder search on simple filter requests 11 years ago
Thomas Bruederli 1d6082c5e2 Fix thread/list mode update and display 11 years ago
Thomas Bruederli 9202e93b75 Fix slicing of returned search result headers 11 years ago
Thomas Bruederli 6884f3f1f7 Re-submit search query when switching folders 11 years ago
Thomas Bruederli 6f17090258 Fix row UID handling in list widget 11 years ago
Thomas Bruederli 1bbf8c4886 - Make search scope selectable in UI
- Disable thread mode when searching over multiple folders
- Encode UID values for HTML message row identifiers
11 years ago
Thomas Bruederli 689a222170 Append per-folder search results to global index but only if it has matches 11 years ago
Thomas Bruederli ff3eb83492 Handle combined UID-folder identifiers in rcube_imap class 11 years ago
Thomas Bruederli 2c33c7e38b Make message pagenav (prev/next) work with sorted multi-folder search results 11 years ago
Thomas Bruederli 2baeac116a Fix sorting and paging in cross-folder searches 11 years ago
Thomas Bruederli 25a244908b Remove merge conflict 11 years ago
Thomas Bruederli b6100d9ed2 Merge branch 'dev-multi-folder-search' of github.com:roundcube/roundcubemail into dev-multi-folder-search
after rebasing to master
11 years ago
Thomas Bruederli d53b60406c Fix typos 11 years ago
Thomas Bruederli b6e24c6946 Minor improvements to threaded searching 11 years ago
Thomas 566747af00 First attempt to search in multiple folders; do it multi-threaded using pthreads if available 11 years ago
Thomas 9684dc018f Support globally unique message UIDs with IMAP folder name appended 11 years ago
Thomas 628706acdc Prepare message list to display IMAP folder 11 years ago
Thomas 017c4f19fd Refactor multi-threaded autocomple contact searching to make it available for other purposes, too 11 years ago
Thomas Bruederli 5740b10bf8 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak 531c4d896c Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak d924ebebf7 Fix compatibility with PHP 5.2 in html.php file (#1489514) 11 years ago
Thomas Bruederli 3786a48aeb * New option that write logs to per-user directories. (Debug) logs will only be written if a directory for the current user exists.
* The 'write_log' plugin hook now also supports the return property 'dir' to let plugins specify the log directory.
11 years ago
Aleksander Machniak 1fd6c43e19 Improve parse_thread so it uses much less recursive calls 11 years ago
Thomas Bruederli c5f6352710 Don't log error if no plugin config is found in global directories 11 years ago
Thomas Bruederli 8fc49e51a4 Use the right base_dn for listing records of the selected group 11 years ago
Aleksander Machniak 5f3c7e3920 Make sure unread_children count (and class) on thread root is always updated when read status of a child row is changed 11 years ago
Aleksander Machniak 8080554cf3 Remove expand/collapse with plus/minus keys (on numeric keypad) (#1489513) 11 years ago
Thomas Bruederli 7c28d45c8e Update class name in subscriptions folder list after saving folder properties 11 years ago
Thomas Bruederli aa581c2912 Fall back to load plugin config from global config directories only if no local config file exists 11 years ago
Thomas B. 5991988b9a Merge pull request #160 from Takika/patch-1
Load plugin config file (by plugin name) from any configured path
11 years ago
Aleksander Machniak 14bd927c71 Extracting inline image data into attachments also if data type is not set 11 years ago
Takika d073a66db3 Load plugin config file from any configured path
Try to load plugin_name.inc.php config file from any pre-configured config path (rcube_config::path array) so webmail admins can move plugin configurations out of www root.
11 years ago
Aleksander Machniak f67037ce57 Fix error when calling get_selection() after any (selected) row was removed 11 years ago
Thomas Bruederli e59471fcb9 Make sure prefs always is a valid array (otherwise causes fatal errors if language if not set) 11 years ago
Aleksander Machniak 090d3ed38c Fix compat. with PHP 5.2 (#1489500) 11 years ago
Thomas Bruederli 72975e1497 Move folder/directory list auto-scrolling functionality to treelist widget (same as auto-expand) and make it work without list header/footer blocks 11 years ago
Aleksander Machniak b23b3f2c35 Fix case-sensitivity of email addresses handling on compose (#1485499) 11 years ago
Aleksander Machniak 4957530dec Fix an obvious mistake in search_once() casing wrong result when called
with empty 2nd argument (which also is not what should happen, should we return error?)
11 years ago
Aleksander Machniak 7a3c0c96c4 Use '0' instead of 0, to fix possible issue. 11 years ago
Thomas B. 2957e77fbc Merge pull request #159 from JohnDoh/group_delete
re-add lost group_delete js event
11 years ago
Aleksander Machniak 172302e2cf Small perf. improvement 11 years ago
Aleksander Machniak ee43f09724 Fix possible warning when advances_prefs setting is not an array 11 years ago
Aleksander Machniak 0301d9347f CS fixes 11 years ago
Aleksander Machniak d575e46067 CS fixes 11 years ago
Aleksander Machniak f5d2eef55c More CS fixes, replace global $CONFIG usage with $RCMAIL->config->get() 11 years ago
Aleksander Machniak ddc161721c Fix default priority selection broken in last CS fix 11 years ago
Aleksander Machniak 5e30349639 CS fixes 11 years ago
Aleksander Machniak 0f16a0353c CS fixes 11 years ago
JohnDoh 1fdb55a99e re-add lost group_delete js event 11 years ago
Aleksander Machniak 10936fef64 Don't alter Message-ID of a draft when sending (#1489409) 11 years ago
Aleksander Machniak c7250749ab Fix issue where deprecated syntax for HTML lists was not handled properly (#1488768) 11 years ago
Aleksander Machniak 3e98f8be71 Add some code for S/MIME signatures verification, update Crypt_GPG package 11 years ago
Aleksander Machniak c97625e02a CS fixes 11 years ago
Aleksander Machniak da5fa28d57 Display different icons when Trash folder is empty or full (#1485775) 11 years ago
Aleksander Machniak 772bec6789 Make addEventListener() chainable for better performance and compact code
Replace deperecated row_init usage with addEventListener('initrow')
11 years ago
Aleksander Machniak b3c034ce30 Merge pull request #157 from JohnDoh/trigger-insertrow
trigger insertrow JS event from compose screen address book widget
11 years ago
Aleksander Machniak ac0fc383fd Fix so message flags modified by another client are applied on the list on refresh (#1485186) 11 years ago
Aleksander Machniak 6b2b2eca5f Remove deprecated functions (these listed in bc.php file) usage 11 years ago
Aleksander Machniak 54029ea959 Fix broken text/* attachments when forwarding/editing a message (#1489426) 11 years ago
Aleksander Machniak 5224a6b394 Make possible to get contact ID from HTML id attribute (#1489414) 11 years ago
Aleksander Machniak f6d23a8dce Fix PHP warning when 1st argument of parse_host() is not a string (#1489486) 11 years ago
Aleksander Machniak c562a31681 Improved minified files handling, added css minification (#1486988) 11 years ago
Aleksander Machniak 538e64c572 Fix Closure-compiler warnings, small code improvements 11 years ago
Aleksander Machniak 774f9dc835 Fix replacing group name with group members on autocompletion
(for some addressbook plugins where email field is not a flat array)
11 years ago
Aleksander Machniak a520f331c1 Fix handling of X-Forwarded-For header with multiple addresses (#1489481) 11 years ago
Aleksander Machniak 0c8049f226 Fix position of messages list column dragging layer when the list is scrolled down 11 years ago
Aleksander Machniak 9a0153324e Implemented menu actions to copy/move messages, added folder-selector widget (#1484086) 11 years ago
Aleksander Machniak 4187b3e26f Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak d19c0f9f30 In normalize_string() replace 4-byte unicode characters with '?' character.
These are not supported in default utf-8 charset on mysql,
the chance we'd need them in searching is very low.
11 years ago
Aleksander Machniak 48660a881c Fix use of non-existing localization label (#1489474) 11 years ago
Aleksander Machniak f896370557 Improved drag-n-drop layer: - do not auto-select children of collapsed threads,
display subjects in real order (not is selection order), some code improvements
11 years ago
Aleksander Machniak 302eb266de Fix regression where only first new folder was placed in correct place on the list (#1489472) 11 years ago
Aleksander Machniak 7eecf873da Fix issue where children of selected and collapsed thread were skipped on various actions (#1489457) 11 years ago
Aleksander Machniak 37ef824256 Added sk_SK localization for csv2vcard map 11 years ago
Aleksander Machniak edca654ef0 Fix quota image broken in e71ceb0c98 (#1489467) 11 years ago
Aleksander Machniak fd0c123e44 Fix fixed header issue after removing rows (1295420) 11 years ago
Aleksander Machniak 39c90d6b61 Make sure selected group is listed after delete error (#1489463) 11 years ago
Aleksander Machniak 029f7a157d Clarify update() result description, return boolean when ID didn't change 11 years ago
JohnDoh 9a8873270f trigger insertrow JS event from compose screen address book widget 11 years ago
Aleksander Machniak 2c16ab5682 Check rcube_addressbook::get_error() after failing delete (#1489463) 11 years ago
Aleksander Machniak 18b40c1a32 Fix issue where groups were not deleted when "Replace entire addressbook" option on contacts import was used (#1489420) 11 years ago
Aleksander Machniak 38bf401cf8 Fix performance of listing writeable folders (#1489451) 11 years ago
Thomas Bruederli ce6050cbbb Display version from composer.json even if not intstalled 11 years ago
Thomas Bruederli 3b95e24fbb Updated localizations from Transifex 11 years ago
Aleksander Machniak 5f31429de5 Fix preparation of message object before saving into the cache.
The bug cased e.g. displaying HTML content as plain text for messages
with Content-Type: text/html.
11 years ago
Aleksander Machniak 38f1f56920 Exec config_get hook also in rcube_config::all() (#1485981) 11 years ago
Aleksander Machniak ffec857b69 Fix handling of invalid closing tags in HTML messages (#1489446) 11 years ago
Aleksander Machniak 993eb88d5a Always send unread counter update for current folder 11 years ago
Aleksander Machniak ac3cddac97 Skip charset (or use US_ASCII) intead of UTF-8 if body contains only ASCII characters 11 years ago
Aleksander Machniak acc900cb63 Small code improvement 11 years ago
Aleksander Machniak 75a5c3554a Add possibility to overwrite a label/message in Roundcube's language package (#1489433) 11 years ago
Aleksander Machniak f59cfe8806 Make Reporting-UA header in MDN report optional, as User-Agent is 11 years ago
Thomas Bruederli 0786798438 Make local storage functions work before rcmail.init() was called 11 years ago
Aleksander Machniak 8c5f405587 Set real content-type for file downloads (#1489439) 11 years ago
Aleksander Machniak 7184b3a0e1 - Update TinyMCE to version 3.5.10 (#1489442) 11 years ago
Aleksander Machniak 184a11b4fb Fix keyboard navigation in autocompletion list on Opera browser
(use keydown event on all browsers)
11 years ago
Aleksander Machniak f768a6eae8 Fix so contactnotfound message is of type error not info 11 years ago
Aleksander Machniak b82fccfc69 Display loading message when loading identity frame 11 years ago
Thomas Bruederli 8d3a9d3213 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak b5117238db Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Thomas Bruederli bf3018e7ed Trigger event when opening new windows with a reference to the window object (#1489413) 11 years ago
Aleksander Machniak 3ab616c742 Fix rowcount when list element contains bot only tr/li elements but also text nodes 11 years ago
Thomas Bruederli 34003c5fa5 Display status messages as pile of black bars overlaying the UI in order to improve visibility (#1488974) 11 years ago
Aleksander Machniak b7fb20af3a Fix issue where subject input might get filled with "null" string (IE8) 11 years ago
Aleksander Machniak 303e21fc63 Replace Array.indexOf() with jQuery.inArray() for older browsers (IE<9) 11 years ago
Aleksander Machniak 5bd8712f71 Fix folders sorting procedure.
Fixes the issue where after creating a folder with name 'Abc abc'
it were added before existing subfolders of folder 'Abc' and after 'Abc'.
11 years ago
Aleksander Machniak f13ae32aec Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak 978ff8794f Make sort_folder_list() public 11 years ago
Thomas Bruederli aef6ed4702 Add hook to notify plugins about message sending errors 11 years ago
Aleksander Machniak 3b8a7918fc Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak 4c8491275c Small fixes: variable scope 11 years ago
Aleksander Machniak fdf79703e2 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Aleksander Machniak 3373e4ae10 Fix browser version detection and failing tests 11 years ago
Aleksander Machniak 8328d0643e Code improvements and some unification with browser detection code in javascript 11 years ago
Aleksander Machniak 51fe045a04 Fix deprecated function usage 11 years ago
Thomas Bruederli fa635d8862 Make $force parameter only override the task check for required plugins (#1489437) 11 years ago
Thomas Bruederli f9c8e8285b Move 'advanced' block to the end of the settings form 11 years ago
Thomas Bruederli f8101fff1e Accept text/html parts inside multipart/mixed parts as HTML contents 11 years ago
Aleksander Machniak f03ed8d9bb Fix (again) IE11 detection where document.all is not defined.
@TODO: review our document.all uses.
11 years ago
Aleksander Machniak 5e4894a916 Fix bgcolor attribute handling 11 years ago
Aleksander Machniak 741ddced5b Fix Internet Explorer 11 detection (#1489434) 11 years ago
Thomas Bruederli 596301c10b Reset $part_orig_mimetype variable in for-loop. This avoids attachments along with message/rfc822 parts being listed twice 11 years ago
Thomas Bruederli 2af3748596 Clean HTML message body from URL parameters after enabling HTML mode in commit e957bfec 11 years ago
Thomas Bruederli cf31954661 Make require_plugin() force loading of the required plugin 11 years ago
Thomas Bruederli e957bfecdf Allow plugins to override message compose mode 11 years ago
Aleksander Machniak 8d91770bcc Do not start autocomplete request on arrow keys press 11 years ago
Thomas Bruederli ceb2a31b38 Compare draft message-ID when restoring local message contents 11 years ago
Thomas Bruederli 7bfc02e122 Track typing activity in HTML editor 11 years ago
Thomas Bruederli 87b513853c Better button text for message restore dialog 11 years ago
Thomas Bruederli 8c74925df1 Track typing in compose screen and only update local storage on activity 11 years ago
Thomas Bruederli 85e60ada15 First version of the local storage compose data saving feature; some behavioral improvements and encrytion are still to be added 11 years ago
Thomas Bruederli e46d060a4a Fix errors in error page :-) 11 years ago
Thomas Bruederli 4a05e8a7e8 Finish advanced prefs feature (#1488829) 11 years ago
Aleksander Machniak 5983ee0f18 Fix categories/groups import from csv 11 years ago
Aleksander Machniak 96247867f2 Fix operations on folders with trailing spaces in name (#1489419) 11 years ago
Aleksander Machniak d1a17029a3 Better handling of fopen() errors 11 years ago
Thomas Bruederli 884e1ecce9 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Thomas Bruederli 1e7d1240ed Avoid rcube_session::reload() to reset previous changes. This fixes parallel attachment uploads that could get lost when using the database_attachments plugin 11 years ago
Aleksander Machniak 00de8ddf8d Small performance improvements, use str_replace() instead of strtr(),
do not parse query if there are no params to replace,
keep one instance of (potentially long) query less in memory
11 years ago
Aleksander Machniak 5c7bbfcd59 Fix regression where child messages on collapsed thread weren't selected
on move/delete action (#1489415)
11 years ago
Aleksander Machniak 88934b6132 Keep all security rules in one place, support Apache 2.4 syntax 11 years ago
Aleksander Machniak 5e3e4fe0c6 Merge pull request #152 from cmcnulty/control-shift
Reset shift_start on control select
11 years ago
Aleksander Machniak 04fbc555b9 Code improvements 11 years ago
Aleksander Machniak a8b004e8d8 Improve identity selection based on From: header (#1489378) 11 years ago
Aleksander Machniak e28b12259f Fix issue where mails with inline images of the same name contained only the first image multiple times (#1489406) 11 years ago
Aleksander Machniak 64cb702847 Remove duplicate languages on spellchecker langs list (#1489395) 11 years ago
Aleksander Machniak 052a6a4d65 Fix list record selection on lists with toggleselect:true, i.e. folder manager
- this is a regression in recent keyboard handling refactoring (#1489408)
11 years ago
cmcnulty e769a7b588 need to reset shift_start on control select
reproduce steps: shift-select some messages, hold down control and
select another message.  hold down shift+control and select more
messages - desired behavior, two separate ranges of selected messages.
(consistent with outlook/thunderbird/windows explorer)
11 years ago
Aleksander Machniak 6a91448aee Improve performance and code readability by using String's startsWith() method, other code improvements 11 years ago
Thomas Bruederli 8d9dcca2b6 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Thomas Bruederli 4c02ef0c5c Fix function calls after refactoring 11 years ago
Aleksander Machniak 8f8e263977 CS fixes 11 years ago
Aleksander Machniak 2aacf1a31d Fix drag-n-drop broken in bc35e865 11 years ago
Aleksander Machniak c511f5d7c8 Eliminate "blinking" loading icon in browser on messages selection
- do not assign location.href to the same value as it is
11 years ago
Aleksander Machniak 03da10725c Bring back fix for #1489396, unintentionally removed in another pull request 11 years ago
Aleksander Machniak bc35e865ae Fix Ctrl+click selection after recent refactorings of keyboard nawigation on list widget 11 years ago
Aleksander Machniak 0fb8940d06 Merge pull request #151 from cmcnulty/new-key-navigation
Spacebar for message selection, left/right arrow for thread collapse/expand
11 years ago
Aleksander Machniak 0c77475f3f Merge pull request #149 from cmcnulty/1489403
#1489403 - fixes scrolling issues when highlighted message is below header.
11 years ago
Thomas Bruederli 1723f92251 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Thomas Bruederli 5b334509a8 Updated localizations from Transifex 11 years ago
Aleksander Machniak ed119d3639 Merge pull request #150 from cmcnulty/1489396
fix #1489396 - make home/end key behavior consistent
11 years ago
Aleksander Machniak b972b4c4c0 Add an option to disable smart Reply-List behaviour - reply_all_mode (#1488734) 11 years ago
Aleksander Machniak 60e1b34e33 Fix typo in last commit 11 years ago
Aleksander Machniak ccb1323dc8 Move setting _next_uid to selection_post_data() 11 years ago
cmcnulty a8876fba93 Revert "simplify home/end key behavior"
This reverts commit 3bef61232b.
11 years ago
cmcnulty 9806c72764 replace space bar with arrow key thread handling
and switch spacebar to select messages
11 years ago
cmcnulty 3bef61232b simplify home/end key behavior
Makes the home/end keys behave like every other mechanism for selecting
records.
11 years ago
cmcnulty 741f387c14 fix scrolling up
Make sure that the fixed header is never over a message
11 years ago
Aleksander Machniak a222f5c045 Fix an issue where pressing minus key on contacts list was hiding list records (#1489393) 11 years ago
Thomas Bruederli a9d476f012 Merge branch 'master' of github.com:roundcube/roundcubemail 11 years ago
Thomas Bruederli 59cdb433a6 Avoid duplicate elements with the same id in HTML. Fixes broken icons in classic skin. 11 years ago
Aleksander Machniak b1f3c3bee8 Fixed saving contact birthday/anniversary dates before 01-01-1970 11 years ago
Aleksander Machniak 8946c2fca9 Merge pull request #146 from cmcnulty/1489397
1489397 - fix shift-down arrow key over thread when going up
11 years ago
Thomas Bruederli fdb30f3279 Fix CSS selector modifications when nested in @media blocks 11 years ago
Charles McNulty d194179863 Fix shift-select when navigating UP the messsage list 11 years ago
Aleksander Machniak 89e50739b4 Refactored status/flag toggle code, added touch event support on flag and status icons.
Fixed regression in commit 4e4c2511bc where click on flag/status/expando
icons was selecting the message row.
11 years ago
Thomas Bruederli 3ce7c56826 Applied the (modified) patch to extend configuration possibilities of LDAP address books as suggested in #1488753:
- Add option to specify arbitrary replacements of config options with attributes from the bound user
- Allow mapping of group object class => member attribute used in these objects
- Describe the 'member_filter' property for groups config
11 years ago
Thomas Bruederli 98b7b548a2 Merge branch 'dev-canned-responses'
Conflicts (resolved):
	skins/classic/includes/settingstabs.html
	skins/larry/includes/settingstabs.html
11 years ago
cmcnulty 52616821c8 #1489392 - arrow key with control down should *not* select messages
In alignment with desktop applications (windows & mac) using the arrow keys with the control key pressed should not select the messages.  Changes code so that with_mouse will be passed as true when click event occurs, and row will only be toggled if it was a click event.
11 years ago
Thomas Bruederli 6abdfff07d Allow to override popup options; return reference to popup dialog 11 years ago
Thomas Bruederli 1ece73dc4e Fix mime.types parsing (#1489391) 11 years ago
Thomas B. e1ae18311a Merge pull request #142 from Takika/patch-2
Add contact_listname hook to handle special name order
11 years ago
Thomas Bruederli b461a2d72e Send last fetch time with 'refresh' requests and allow plugins to alter query parameters of http requests 11 years ago
Takika 03713dbf5d Add contact_listname hook to handle special name order
I can modify the addressbook_name_listing variable via main config or preferences_list_hook but I have to change the rcube_addressbook class to use the modified value. Some contry use special [name orders](http://en.wikipedia.org/wiki/Personal_name#Name_order) and we can handle them with this hook.
I changed the hook name to contact_listname as proposed by thomascube in the original PR#127.
11 years ago
Aleksander Machniak a649e0488a Fix failing vCard import when email address field contains spaces (#1489386) 11 years ago
Aleksander Machniak 99d59620e1 Join many preg_replace() calls into one 11 years ago
Aleksander Machniak 27a620c012 Fix typo in method name 11 years ago