Commit Graph

6671 Commits (c25a6cf09b9ad1d8aef72f4a37075b30eab2c15e)

Author SHA1 Message Date
Thomas Bruederli f78e2a4367 Add 1.3-beta milestone + update copyright year 8 years ago
Aleksander Machniak 8086099621 Small code improvements in PDF capability checker 8 years ago
Aleksander Machniak 25de39d444 Merge branch 'dev-remove-js-deps' 8 years ago
Aleksander Machniak 9d45ef20cc Fix so group/addressbook selection is retained on page refresh 8 years ago
Aleksander Machniak eec77c1a99 Fix some advanced search issues with multiple addressbooks (#5572) 8 years ago
Aleksander Machniak 369b44d94a Fix unsetting template objects
Fixes compatibility with some plugins e.g. kolab_addressbook which
call parse() method (for sub-templates) while parsing the main template
8 years ago
Aleksander Machniak 2418f07985 Nicely handle contact deletion on contact edit (#5522) 8 years ago
Aleksander Machniak 68c9b669e4 Fix adding images to new identity signatures
It already worked only on edits, because the image data for new identity
was stored in the wrong session item.
8 years ago
Aleksander Machniak 15bd0b51a4 Improve mailvelope decryption errors handling, hide encrypted part attachment on successful decryption (#5279)
+ small style improvements
8 years ago
Aleksander Machniak a487055c5a Add possibility to attach contact vCard to composed message (#4997) 8 years ago
Aleksander Machniak 692cb9c63b Update localization 8 years ago
Aleksander Machniak 930c921bed Disable Print button for pdf attachments in Firefox (#5125)
Mozilla's PDF.js viewer does not allow printing from host page.
We try to detect such situation and disable the button to minimize
user confusion.
8 years ago
Aleksander Machniak c183463a6e Fix visual glitch when using disabled_actions for items in Settings menu 8 years ago
Jens Carl de82576134 Add mime type detection under FreeBSD and Apache 2.4 (#5560) 8 years ago
Aleksander Machniak 8d1e0eb574 Preserve message internal/received date on import in mbox format (#5559) 8 years ago
Aleksander Machniak 2733258d2b Load 'close' label for dialogs by default 8 years ago
Aleksander Machniak 2482088a76 Possibility to display QR code for contacts data (#5030) 8 years ago
Aleksander Machniak 12a49437d2 Upgrade to TinyMCE 4.5.1 8 years ago
Aleksander Machniak 4f5ec65a36 Close SMTP connection ASAP after the message has been sent
We should not keep the connection open until the script shuts down.
It may take long time e.g. to save the message in IMAP.
8 years ago
Aleksander Machniak 5e1da48d0c Remove external javascript code from the git repo, add jsdeps.sh script (#5535) 8 years ago
Aleksander Machniak a99e479cb4 Fix variable substitution in ldap host for some use-cases, e.g. new_user_identity (#5544) 8 years ago
Aleksander Machniak 581c41ca67 Make sure subject is always on proper place in widescreen mode 8 years ago
Aleksander Machniak 32b68959b2 Merge branch 'master' of github.com:roundcube/roundcubemail 8 years ago
Aleksander Machniak a1f679adca Fixed redundancy in sql caching system and compatibility with Galera Cluster (#5439)
- Removed redundant 'created' column from cache and cache_shared tables
- Removed use of redundant data records
- Added missing primary keys (dictionary, cache, cache_shared tables)
8 years ago
Aleksander Machniak 940a27400e Use GSSAPI only if configured (#5530) 8 years ago
Aleksander Machniak 5cca1988b6 Fix write_log() return value when using syslog() and it fails 8 years ago
Aleksander Machniak dad1852126 Fix _from argument validation 8 years ago
Aleksander Machniak a844db6a27 Merge branch 'dev-layouts' 8 years ago
Thomas Bruederli 32cd762278 Always send columns list as array (unsetting items makes it an object with numeric keys) 8 years ago
Aleksander Machniak c344f60d75 Fix displaying attached images with wrong Content-Type specified (#5527) 8 years ago
Aleksander Machniak 6287227fff Fix missing content check when image resize fails on attachment thumbnail generation (#5485) 8 years ago
Aleksander Machniak 8a76bf3783 Make sure $prefs property is an array (#5523) 8 years ago
Aleksander Machniak e306328340 Fix storing "empty" values in rcube_cache/rcube_cache_shared (#5519) 8 years ago
Aleksander Machniak 7e90de4ef5 write_record() should return boolean value 8 years ago
Aleksander Machniak b26dcb64c3 Code simplification 8 years ago
Aleksander Machniak 68221ed4ae Improve uppercase/lowercase/ucfirst attrib handling in rcube::gettext()
- Make ucfirst mode compatible with UTF-8
- Fix bug which made uppercase=FIRST non-working
- Replace \n with real line-break before converting char case
8 years ago
Aleksander Machniak 6e0effa54c Fix "Illegal string offset" warning in rcube::log_bug() on PHP 7.1 (#5508) 8 years ago
Aleksander Machniak e17fcf1649 Support ALLOW-FROM in x_frame_options (#5122) 8 years ago
Aleksander Machniak 0e5a167cd2 Fix recognizing Sent folder on search if current folder has been changed by plugins in meantime 8 years ago
Aleksander Machniak e17e8851f1 CS improvements, _xor() method replaced with an anonymous function 8 years ago
Aleksander Machniak d02e6ea45e Fix so templating system does not mess with external (e.g. email) content (#5499) 8 years ago
Aleksander Machniak c3e7d93c43 Make "Add contact" image/text ignored when copying/selecting recipients in main headers (#5103) 8 years ago
Aleksander Machniak 386af483ce Fix redundant keep-alive/refresh after session error on compose page (#5500) 8 years ago
Aleksander Machniak 2dbbaf7739 Warn about too many disclosed recipients in composed email [max_disclosed_recipients] (#5132)
Allow to omit a subject when sending an email (#5068)
8 years ago
Aleksander Machniak bd12d94fae Fix missing contact ID for contacts from non-sql addressbooks 8 years ago
Aleksander Machniak 28741ed032 Disable double-click on the list when preview pane is on (#5199)
This eliminates delay when opening a message in preview pane.
8 years ago
Aleksander Machniak 556c1725a7 Unify automatic marking as \Seen in preview pane, full-page and extwin views (#5071)
We now have one 'mail_read_time' option that works for all cases.
Option 'preview_pane_mark_read' has been removed and marked as an alias.
8 years ago
Aleksander Machniak c42d447a55 Removed unused moxieplayer.swf 8 years ago
Aleksander Machniak ecfe177173 CS fixes, use $this instead of local variable 8 years ago
Aleksander Machniak e3b61cd487 Plugin API: Added get_compose_responses hook (#5457) 8 years ago
Aleksander Machniak 1727071816 Better handling of rcube_text_editor.replace()'s input argument, some simplification 8 years ago
Aleksander Machniak edea8732a6 Fix regression where UI object could be not created on some pages (#5484) 8 years ago
Aleksander Machniak 571a10751f Display error when trying to upload more files than specified in max_file_uploads (#5483) 8 years ago
Aleksander Machniak f43f5bf93f Use JSON_PRETTY_PRINT in devel_mode
This effectively makes PHP 5.4 a real requirement
8 years ago
Aleksander Machniak 4e0532808d Fix bug where it wasn't possible to store more that 2MB objects in memcache/apc (#5452)
Added memcache_max_allowed_packet and apc_max_allowed_packet settings
8 years ago
Aleksander Machniak cf9f0d8829 Fix bug where IMAP password could be exposed via error message (#5472) 8 years ago
Aleksander Machniak b8f9ba7d47 Fix bug where deleting folders with subfolders could fail in some cases (#5466) 8 years ago
Aleksander Machniak 20086193eb Support HTML input to rcube_text_editor.replace() (#5456) 8 years ago
Aleksander Machniak b258b91560 Do not show inline images of unsupported mimetype (#5463) 8 years ago
Aleksander Machniak d305f4f0fd Separate action to mark all messages in a folder as \Seen (#5006)
with possibility to do this in all folders or in a folder and its subfolders (#5076)
8 years ago
Aleksander Machniak 40fe66b71e Fix reference to non-existing blank.tif file in mime_content_type check 8 years ago
Aleksander Machniak 8a51607671 Fix regression where creation of default folders wasn't functioning without prefix (#5460) 8 years ago
Aleksander Machniak 638afafbd2 Make so rcmail.log() depends on devel_mode (#5193) 8 years ago
Aleksander Machniak d85f30bec4 Archive: Don't reload messages list when it's not needed (#5225)
Archive: Add option to automatically mark archived messages as \Seen (#5142)
8 years ago
Aleksander Machniak 9e129383a1 Improve randomness of password salts and random hashes (#5266) 8 years ago
Aleksander Machniak 195dc11855 Support host-specific imap_conn_options/smtp_conn_options/managesieve_conn_options (#5136) 8 years ago
Aleksander Machniak 8c75dd3aa8 Add convenient method to create new session records 8 years ago
Aleksander Machniak c13119b81c Fix bug where folders list would scroll to top when clicking on subscription checkbox (#5447) 8 years ago
Aleksander Machniak 42ddfe5ec9 Simplify mbstring code path in rcube_charset::convert() 8 years ago
Aleksander Machniak 48585867f3 INBOX should be always protected, event with protect_default_folders=false
I.e. it should not be possible to rename INBOX
8 years ago
Aleksander Machniak 331bb579c2 jQuery 3.1.1 8 years ago
Aleksander Machniak c1c0a0d815 Implemented rcube::sleep() method for disconnecting all external connection in long-running/sleeping scripts 8 years ago
Aleksander Machniak a227589eb2 de_DE: abboniert -> abonniert 8 years ago
Aleksander Machniak f713d186bc Disable navigation if can't get messages index in pagenav.inc 8 years ago
Aleksander Machniak 6886a4de3f Widescreen layout aka three column view (#5093) 8 years ago
Aleksander Machniak e22824a316 Use mb_strtoupper() instead of strtoupper() for localized texts 8 years ago
Aleksander Machniak 650ac8befb Fix displaying size of attachments with zero size 8 years ago
Aleksander Machniak a8d41ac7f4 Fix some undefined variables 8 years ago
Aleksander Machniak bfbab5bcde Fix keyboard event detection with jQuery 3.x and remove hacks for old browsers
This fixes e.g. unwanted focus on a toolbar button after closing popup
menu with mouse click on the document.
8 years ago
Aleksander Machniak f92052fd73 Fix so when moving to Trash we make sure the folder exists (#5192) 8 years ago
Aleksander Machniak 2e1675bc4a Center and scale images in attachment preview frame (#5421) 8 years ago
Aleksander Machniak 4bf4afec68 Fix so folders list is scrolled to the selected folder on page load (#5424) 8 years ago
Aleksander Machniak 2999cc38a5 Generate more compact HTML5 code, e.g. use short form of boolean attributes 8 years ago
Aleksander Machniak 95df255af4 Added max_message_size option enforced when attaching files to a composed message (#4993) 8 years ago
Aleksander Machniak aad269c2f8 Fix PHP warning when handling shared namespace with empty prefix (#5420) 8 years ago
Aleksander Machniak d7089c81d6 Fix so messages list does not lose focus when releasing drag-n-drop outside of the list 8 years ago
Aleksander Machniak ce0c42ed8a Fix error causing empty INBOX listing in Firefox when using an URL with user:password specified (#5400) 8 years ago
Aleksander Machniak defdf84bb7 Really fix login form regression
Remove 'form' from allowed attributes list of input field. We needed
it only for a moment, now we don't. It's also not supported by IE/Edge
which means there's no way we would need it. Maybe some day...
8 years ago
Victor Benincasa daeb66ee99 Fix login form
Fix a small bug introduced on commit 43f3c5f that breaks the login form ($attrib['form'] is checked at line 1899, so it cannot be unset).
8 years ago
Aleksander Machniak 32e5a6bbcf Fix bug where folder creation could fail if personal namespace contained more than one entry (#5403)
+ small code improvements
8 years ago
Aleksander Machniak 99cb08c41c Fix so "All" messages selection is resetted on search reset (#5413) 8 years ago
Aleksander Machniak 80919e1cf5 Added Search button in quick search menus (#5312) 8 years ago
Aleksander Machniak 873e0353cf Use smart-upload-button for messages and contact photos upload
Unified interface with rcmail::upload_form().
8 years ago
Aleksander Machniak de5da687e4 Remove code for "placeholder" attribute support in old browsers 8 years ago
Aleksander Machniak c88a88fb0b Rewrite smart upload button to work in IE (#5410) 8 years ago
Aleksander Machniak 820d614c79 Fix missing </form> tag 8 years ago
Aleksander Machniak 43f3c5fb2a Implement "one click" attachment upload (#5024) 8 years ago
Aleksander Machniak c65bb121eb Describe Framework requirements, drop some redundant code (since we require mbstring) 8 years ago
Aleksander Machniak 0485275a75 Merge branch 'dev/drop-legacy-browsers' 8 years ago
Aleksander Machniak 689996896a Fix bug where names of downloaded files could be mailformed when derived from the message subject (#5404) 8 years ago
Aleksander Machniak 9debc38724 Drop mail_header_delimiter option, since we don't use mail() we don't need it 8 years ago
Aleksander Machniak 184de7735c CS fixes (mostly phpdoc) 8 years ago
Aleksander Machniak 2298ecf7f6 Fix E_DEPRECATED warning when using Auth_SASL::factory() (#5401) 8 years ago
Aleksander Machniak d7c4c3fb62 Drop IE9 support 8 years ago
Aleksander Machniak eecc601601 Fix compatibility with jQuery 3.x 8 years ago
Aleksander Machniak 0836b213db Removed useless 'created' column from 'session' table (#5389) 8 years ago
Aleksander Machniak 505efff5c4 Fix bug where blocked.gif couldn't be attached to reply/forward with insecure content 8 years ago
Aleksander Machniak 94f8ce3334 Make html::parse_attrib_string() more robust
Fixes PHP Error: Expression parse error on: ($app->config->get('preview_pane',rcube_utils::get_boolean('')) == true ? ' checked=checked' : ')
8 years ago
Aleksander Machniak 062d95503e Fix bug where Message-ID domain part was tied to username instead of current identity (#5385) 8 years ago
Aleksander Machniak 55cdf1569e Support contact+group searches in all relevant places (T1360)
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.
8 years ago
DanCld ee00d949c4 Properly set the memcache debug log file name
Properly set the debug log file name ('memcache') as $this->type is undefined
8 years ago
Aleksander Machniak 53b5ccfb0c Fix regression where LDAP results could be counted incorrectly when using VLV
... broken by d08bd0a51f where we added searching in users+groups in one request
8 years ago
Aleksander Machniak 71340a1bea Update to jQuery-3.1.0 8 years ago
Aleksander Machniak eda23fe6c8 Remove hacks for old Internet Explorer versions 8 years ago
Aleksander Machniak 9e3263acbe Simplify popup dialogs creation 8 years ago
Aleksander Machniak dcabc1d814 Merge remote-tracking branch 'upstream/master'
Conflicts:
	tests/Framework/Washtml.php
8 years ago
Aleksander Machniak 94eb2e5a40 Make the attachment rename input bigger (size: 50) 8 years ago
Aleksander Machniak ebc2f5dc7d Add possibility to rename attachments in mail compose (#4996)
... and fix some small issues related to the new compose attachment menu feature
8 years ago
Aleksander Machniak c3fc072d97 Remove code related to magic_quotes_* and register_globals
...they do not exist in PHP 5.4 which we now require.
8 years ago
Aleksander Machniak 906cf101c3 Better time handling in rcube_utils::clean_datestr() 8 years ago
Aleksander Machniak ec1525a1e6 Remove debug code 8 years ago
Aleksander Machniak ed35267b9b Managesieve: Fix parsing of vacation date-time with non-default date_format (#5372)
Added new method rcube_utils::format_datestr() to convert date_format date
into ISO date format.
8 years ago
Aleksander Machniak 2f2765ab43 Fix regression in resizing JPEG images with Imagick (#5376) 8 years ago
Aleksander Machniak 672ca96b24 Merge pull request #5375 from filhocf/master
Correct file csv2vcard.inc
8 years ago
Claudio Ferreira Filho 40a493b0e1 Adjusting csv2vcard.inc file 8 years ago
Aleksander Machniak 8a13615e9e Add possibility to preview and download attachments in mail compose (#5053) 8 years ago
Claudio Ferreira Filho 51979cb554 Adding localized in pt_BR csv2vcard.inc file 8 years ago
Thomas Bruederli 354042c4f4 Fix German tranlsation for 'open' (#5360) 8 years ago
Thomas Bruederli 4e3442877d Updated localizations from Transifex 8 years ago
Aleksander Machniak e1165fed89 Remove backward compatibility "layer" of bc.php (#4902) - now for real 8 years ago
Aleksander Machniak 64763853c9 Fix javascript errors in IE on page with iframe that points to another domain 8 years ago
Aleksander Machniak e6553ce60d Fix German localization label 8 years ago
Aleksander Machniak d91bad5975 Fix handling of blockquote tags with mixed case on html2text conversion (#5363) 8 years ago
Aleksander Machniak 7a7a6795f0 Support WEBP images in mail messages (#5362) 8 years ago
Aleksander Machniak 1988f68660 Merge pull request #5203 from bostjan/foundation-for-customizable-contacts-autocomplete
Foundation for customizable contacts autocomplete
8 years ago
Aleksander Machniak 6626328e7c We already require PEAR, so it's not needed to check if PEAR class exists.
Sooner or later it will fail if PEAR does not exist, so better to do this sooner.
8 years ago
Aleksander Machniak fdf9ff5a17 Merge pull request #5361 from PeterDaveHelloKitchen/image-optimize
optimize png images using zopflipng
8 years ago
Aleksander Machniak 437aca39e0 Enigma: Import keys from key-server(s) (#5286) 8 years ago
Aleksander Machniak 4361a95820 Fix missing localization of HTML editor when assets_dir != INSTALL_PATH 8 years ago
Aleksander Machniak edfd9da42a Support MathML in HTML message preview (#5182) 8 years ago
Aleksander Machniak 158b34ed42 Rename Addressbook to Contacts (#5233) 8 years ago
Peter Dave Hello 6ee0cec8e9
optimize png images using zopflipng 8 years ago
Aleksander Machniak ee895a2c96 Remove PHP mail() support, smtp_server is required now (#5340) 8 years ago
Aleksander Machniak 8e65f618c5 Display full message subject in onmouseover on truncated subject in mail view (#5346) 8 years ago
Aleksander Machniak e13deb2e47 Merge branch 'master' of github.com:roundcube/roundcubemail 8 years ago
Aleksander Machniak 930e363e55 Fix handling of 'mailto' and 'error' arguments in message_before_send hook (#5347) 8 years ago
Aleksander Machniak d2d4f867e5 Merge pull request #5350 from demis-palma/fix-encoding
Fixed wrong encoding in currency symbols
8 years ago
Aleksander Machniak dc6cfe1eec Merge pull request #5351 from fliespl/patch-1
Remove use of deprecated method Imagick::flattenImages
8 years ago
Aleksander Machniak 9a2264ba0e Fix regression where messages with no text part (but e.g. application/zip) were not displayed as an attachment (#5357) 8 years ago
fliespl 10c032165b Remove deprecated function flattenImages
flattenImages in imagick is deprecated since php 5.6. 
`PHP Deprecated:  Imagick::flattenImages method is deprecated and it's use should be avoided `


Proposed solution works with imagick 3.1.0+.
11 is used as an alternative to `Imagick::ALPHACHANNEL_REMOVE` which was added in imagick 3.2.0.
9 years ago
Demis Palma 411bd3fe82 Fixed wrong encoding in currency symbols 9 years ago
Aleksander Machniak 3d9e170d8b Use contact_search_name format in popup on results in compose contacts search 9 years ago
Aleksander Machniak 352c6329cc Enigma: Search missing public keys on a key-server in mail compose (#5286) 9 years ago
Aleksander Machniak 997e82d2b2 Merge pull request #5326 from raoulbhatia/autoload
Translate PHP namespaces into directories
9 years ago
Aleksander Machniak 0ae4001121 Don't create multipart/alternative messages with empty text/plain part (#5283) 9 years ago
dsoares 8e7e22c656 Avoid PHP fatal error
After last change to file `rcube_ldap.php`, my roundcube instance was getting this error:
```
PHP Fatal error:  Cannot use object of type Net_LDAP3_Result as array in ...
```
In
```php
protected function extended_search($count = false)
```
`$result = $this->ldap->search()` returns a LDAP object (whatever package we use).
If the search returns no results (and if `$is_extended_search` is false), then it gets to line 971 trying to do a `usort()` and then a `count()` on an object, instead of an array.
9 years ago
Aleksander Machniak c08ca018d8 Get rid of rcube_imap_generic::strToTime() in favor of rcube_utils::strtotime() 9 years ago
Raoul Bhatia 7122df719d Translate PHP namespaces into directories 9 years ago
Aleksander Machniak d08bd0a51f Searching in both contacts and groups when LDAP addressbook with group_filters option is used 9 years ago
Aleksander Machniak de53074734 Fix syntax error 9 years ago
Sandor Takacs 6d1a68bd44 Rename field_blocks to head_fields 9 years ago
Sandor Takacs e108902eff Add $field_blocks to contact_form hook
Add $field_blocks to contact_form hook, so plugins can change the order of the fields: https://github.com/roundcube/roundcubemail/pull/5281
9 years ago
Aleksander Machniak 22241a5d82 CS fixes 9 years ago
Aleksander Machniak 58c036116b Support type=password in rcube_output::get_edit_field() 9 years ago
Aleksander Machniak f2eafda539 Fix bug where microsecond format in logged date didn't work in some cases 9 years ago
Aleksander Machniak 5e1277e971 Trim error message 9 years ago
Aleksander Machniak f840abe6e0 Don't add HTTP response body/headers to the spellchecker error message (it is displayed to the user) 9 years ago
Aleksander Machniak c478536741 Make SQL selects less expensive in memory for some cases where we fetch big data chunks 9 years ago
Aleksander Machniak 5e5eab3e53 Update TinyMCE to version 4.3.13 (#5309) 9 years ago
Aleksander Machniak d0bb0a9c9d Fix subscription checkbox state on error in folder subscribe/unsubscribe action (#5243) 9 years ago
Aleksander Machniak b9d3fb0221 Display different attachment icon on encrypted messages 9 years ago
Aleksander Machniak c76c4ed08b Workaround PHP issue by calling closelog() on script shutdown when using log_driver=syslog (#5289) 9 years ago
Aleksander Machniak d61d33a12a Fix handling of --delete argument in moduserprefs.sh script (#5296) 9 years ago
Aleksander Machniak f466899d8d Simplified code 9 years ago
Aleksander Machniak 7864a98f08 Fix searching by email address in contacts with multiple addresses (#5291) 9 years ago
Aleksander Machniak 6737e293bb Wash position:fixed style in HTML mail for better security (#5264) 9 years ago
Thomas Bruederli 44894414cd Avoid sending completely empty text parts for multipart/alternative messages (#5283) 9 years ago
Thomas Bruederli f82e336ada Add licence header to cloned PublicKey.js 9 years ago
Aleksander Machniak bf049c80e7 Remove debug code 9 years ago
Aleksander Machniak 1a8593a315 Update changelog 9 years ago
Aleksander Machniak db70d3e491 Merge pull request #5277 from hemio-ev/mailvelope-fixes
Fixes 'nobodywarning' on sending mailvelope mails
9 years ago
Aleksander Machniak 796bb4ccbb Update localization, add Enigma plugin localizations 9 years ago
Aleksander Machniak ff735fb3a5 Protect INBOX folder even if protected_default_folders=false 9 years ago
Aleksander Machniak 0ce7c493a8 Fix multi-folder search issues in "this and subfolders" scope (#5282, #5259)
- Fix bug where multi-folder search could choose a wrong folder
- Fix bug where multi-folder search didn't work for unsubscribed INBOX
9 years ago
Aleksander Machniak 2b88e6cf95 Use $OUTPUT->set_env(...) instead of $OUTPUT->command('set_env', ...) 9 years ago
Aleksander Machniak 98c1712e29 Fix redundant keep-alive requests when session_lifetime is greater than ~20000 (#5273) 9 years ago
Michael Herold d3c6d6570b Fixes 'nobodywarning' on sending mailvelope mails 9 years ago
Aleksander Machniak 87cf0a3fb1 Use minified publickey.js (with cache-buster) when available (#5254) 9 years ago
Aleksander Machniak 9e64dc2deb Remove application/x-tar file extension test as it might not exist in nginx config (#5253)
Use text/css instead
9 years ago
Aleksander Machniak 378d10b748 Fix bug where message list columns could be in wrong order after column drag-n-drop and list sorting 9 years ago
Aleksander Machniak 930a3ceac0 Fix bug where errors could have been not logged when per_user_logging=true 9 years ago
Aleksander Machniak f7fdf1a4de Merge pull request #5168 from piuma/patch-1
Set maxlength for email address input
9 years ago
Aleksander Machniak 3d0d5dbd0f Performance improvements in format_flowed() and unfold_flowed() 9 years ago
Aleksander Machniak afd090672c Small performance optimization 9 years ago
Aleksander Machniak 9cd4b1bc58 Display different confirmation text when moving messages to Trash (#5220) 9 years ago
Aleksander Machniak 6d1337e1df Fix regression where setting Answered/Forwarded flag didn't work when sending an email 9 years ago
Aleksander Machniak 6652367d65 Fix XSS issue in href attribute on area tag (#5240, #5241) 9 years ago
Aleksander Machniak 4921c21cff Optimize SELECT response handling 9 years ago
Aleksander Machniak 344b0af9c6 Indicate that a collapsed thread has flagged children (#5013) 9 years ago
Aleksander Machniak 9796cd2063 Merge branch 'dev-rfc822-preview'
Conflicts:
	CHANGELOG
	program/steps/mail/show.inc
9 years ago
Aleksander Machniak 56f9883d84 Update to jsTimezoneDetect 1.0.6 9 years ago
Aleksander Machniak 9634169647 Bump version number to 1.3-beta 9 years ago
Aleksander Machniak bd6d7645d7 Update localization 9 years ago
Aleksander Machniak 667ed37f77 Fix bug where Encrypt button appears when switching editor to HTML (#5235) 9 years ago
Aleksander Machniak 013aaeb895 CS improvements/fixes 9 years ago
Aleksander Machniak 0eece8222b Fix autoloading of 'html' class and improve autoloader performance 9 years ago
Aleksander Machniak 5d08d57005 Don't log ajax requests/responses, browser development tools already can show this information 9 years ago
Aleksander Machniak 5e406f7b7e Disable links list when converting html2text for spellchecking 9 years ago
Aleksander Machniak 1da8ffd52b Use "email" over "e-mail" consistently (#5212) 9 years ago
Aleksander Machniak 7abfe41ab7 Fix bug where getting HTML editor content could steal focus from other form controls (#5223) 9 years ago
Aleksander Machniak 7dad859ffa Fix message list multi-select/deselect issue (#5219) 9 years ago
Aleksander Machniak 52106ffd39 Fix bug where rcube_contacts::get_record() could return cached result when requested record wasn't found (#5218) 9 years ago
Bostjan Skufca 12756e2297 Autocomplete: store last searched-for string into separate variable for later consumption
Reason:
Autocompleting person contacts works as expected - ksearch_value is available and passed to triggerEvent.
But with group autocomplete, ksearch_value is reset (to null) and triggerEvent call lacks necessary data.
9 years ago
Bostjan Skufca f919e8ffa6 Autocomplete: change type from 'contact' to 'person' to sync with what is expected from LDAP.
Explanation:
Alternative would be to leave type empty, as it is when contact comes form SQL source.
But this feels overly ambiguous and may cause problems in the future.
9 years ago
Bostjan Skufca 1791c3e3d7 Autocomplete/frontend: provide functions that hook into 'autocomplete_insert' actual search and result data
Reason:
In order to enable development of sophisticated autocomplete algorithms, they will need
to process all the data relevant to autocomplete - what was the search string and which
result was the correct one.

Example to illustrate the need:
Say we are talking about these two people of interest, who are in the address book, among others:
- person 1: Bostjan Skufca <bostjan@a2o.si>
- person 2: Bostjan SkuBIC <bostjan@otherdomain.com>

Our user is used to think about the first person by the first name, "Bostjan", as he is an old friend.
The second one is a colleague at work where people call themselves mostly by surnames, "Skubic" in this case.

Without this data provided to 'autocomplete_insert', there is no way for RC to learn that when our user
enters "bos" in the To: field he thinks about person #1 (Bostjan SkuFCA), and when he starts typing "sku"
he means person #2 (Bostjan SkuBIC).
9 years ago
Bostjan Skufca 05c7d49a37 Autocomplete search: add id and source (addressbook) into resulting contact data array
Two reasons:
- provide it to plugin backend functions that use 'contacts_autocomplete_after' hook
- provide it to frontend

Why to frontend?
If plugin JS adds an 'autocomplete_insert' hook we need to provide it with exact
autocomplete data. Providing it with name and email address only, without pinpointing
exact origin of this autocomplete result, will severely limit learning capabilities of
potential future autocomplete implementations.
9 years ago
Bostjan Skufca a15b2d5998 Autocomplete refactoring: replace variable name '$id' with '$abook_id'
Reason:
Having genericly named variable $id in nested loops makes code unreadable.
Replacing generic name '$id' with '$ENTITIY_id' format removes all ambiguity.
9 years ago
Bostjan Skufca ed55af4aa9 Autocomplete: trigger "contacts_autocomplete_after" hook processing
Provide existing list of contact suggestions as an argument - it might be unclear
now what logic plugin developers decide to implement, but data for that logic
should be provided upfront, and that includes list of suggestions that RC
itself comes up with.

Plugin logic might then replace the list entirely, or just rearrange its entries, or use
part of the list when it runs out of own ideas, or do something entirely different.
9 years ago
Bostjan Skufca 865230e420 Autocomplete: fix undefined variable notice if no addressbook is configured for autocomplete 9 years ago
Aleksander Machniak e2e56261b9 Fix handling of long script/style tags when converting to text 9 years ago
Aleksander Machniak a0f38f5fd8 Small code style improvements 9 years ago
Aleksander Machniak e8ab3d96bd Fix converting mail addresses with @www. into mailto links (#5197) 9 years ago
Aleksander Machniak d01c06eded CS fixes 9 years ago
Bostjan Skufca 70a8236cd5 mailbox/listing: Make server response for large mailbox listing faster when using threaded view
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.

Mailbox index view timing:    ~360 ms
Mailbox threaded view timing: ~800 ms

Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.

This optimization is already present in index view handler, but was missing
from threaded view.

Results after optimization
==========================
Both average out around ~360 ms response time.
9 years ago
Aleksander Machniak 4fdcd8c9d1 Remove redundant code 9 years ago
Bernardo Silva c72446a8fc Allow pattern attribute in input
"pattern" included in the list of allowed attributes in the input tag
9 years ago
Aleksander Machniak 6f2c007d1b CS fixes: Replace use of "bool ? true : false" with just "bool" 9 years ago
Aleksander Machniak 5c253dd59e Fix so SPECIAL-USE assignments are forced only until user sets special folders (#4782)
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
9 years ago
Aleksander Machniak aba88576ef Update localizations 9 years ago
Aleksander Machniak 7462095f60 Small code improvements 9 years ago
Aleksander Machniak 46f7b70964 Enable reply/reply-all/forward buttons also in preview frame of message/rfc822 9 years ago
Aleksander Machniak e8b6e726f6 Add message menu with viewsource and edit actions in message/rfc822 preview 9 years ago
Aleksander Machniak d125f864ea Message/rfc822 previewer compatibility with Enigma 9 years ago
Aleksander Machniak 640e5e265d Enigma: Handle encrypted/signed content inside message/rfc822 attachments 9 years ago
Aleksander Machniak 4e6f3019f5 Enigma: Handle encrypted/signed content inside message/rfc822 attachments 9 years ago
Aleksander Machniak ce3105c58f Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview 9 years ago
Aleksander Machniak 323fa20bc8 Message/rfc822 attachment preview (#5054) 9 years ago
Danilo 1db4c05078 Fix: Set long email addresses
The changes permit to set long email address up to the maximum permissible length.
9 years ago
Aleksander Machniak 05972d7b33 Refer to Github issues instead of Trac 9 years ago
Aleksander Machniak 791ee65d2e Fix so contactlist_fields option can be set via config file 9 years ago
Aleksander Machniak 348ec70f12 Export vCard PHOTO with "ENCODING=b" (instead of "ENCODING=B") as specified in RFC2426 9 years ago
Aleksander Machniak 3a13b5dab8 CS fixes 9 years ago
Aleksander Machniak 0c9e55b0c9 Fix PHP warning when defaults.inc.php is not readable 9 years ago
Aleksander Machniak bf91666621 Revert "Update to jQuery 2.2.1"
This reverts commit 940b966fac.

There are issues with jQuery-UI 1.10 we use and it's actually
too late for such a change now when we want 1.2 release soon.
9 years ago
Thomas Bruederli 4a408843b0 Protect download urls against CSRF using unique request tokens (#1490642)
Send X-Frame-Options headers with every HTTP response
9 years ago
Aleksander Machniak d4df3748cf Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix) 9 years ago
Aleksander Machniak ca34ba139e CS fixes 9 years ago
Aleksander Machniak 940b966fac Update to jQuery 2.2.1 9 years ago
Aleksander Machniak b0a8e36930 Fix handling of body parameter in mail compose request 9 years ago
Aleksander Machniak faeeebdc55 Hide DSN option in Preferences when smtp_server is not used (#1490666) 9 years ago