5282cbaff9
Check against trusted_host_patterns in rcube_utils::parse_host()
7 years ago
0f4f85e097
Skip redundant INSERT query on successful logon when using PHP7
...
Since PHP 7.0 session_regenerate_id() will cause the old session data update.
This is redundant INSERT query and also produces a record for the session
we don't need anymore.
7 years ago
ef0982f1b8
Merge branch 'master' into dev-elastic
7 years ago
50a9c8f777
Add option trusted_host_patterns
7 years ago
515d496808
Replace display_version with display_product_info ( #5904 )
7 years ago
e21ab984bc
Skip <span> wrappers in html_table that is a <ul> list
7 years ago
d815525c6a
Merge branch 'master' into dev-elastic
7 years ago
4574870adc
fix: unknown content-disposition type should be treated as attachment ( #6002 )
7 years ago
5e08a6ac59
Handle remote stylesheets the same as remote images, ask the user to allow them ( #5994 )
...
Fixes the issue where remote stylesheet could have been blocked
if the message contained no remote images and user have no way to
allow that content.
7 years ago
3196d656db
Fix css conflicts in user interface and e-mail content ( #5891 )
...
... by adding prefix to element/class identifiers
Also cleaned up some code and removed global variable use.
7 years ago
403d8453c8
Fix issue caused by non-default session.cookie_lifetime setting ( #5961 )
7 years ago
f8fc01b800
Fix so untagged COPYUID responses are also supported according to RFC6851 ( #5982 )
7 years ago
5d3add78aa
Add Message-ID to the sendmail log ( #5871 )
7 years ago
117c150b2f
Fix bug where mail search could return empty result on servers without SORT capability ( #5973 )
7 years ago
3c1b78af48
Merge branch 'master' into dev-elastic
7 years ago
4223bed7e8
Add html_button class
7 years ago
5d16751ed8
Fix (again) bug where image data URIs in css style were treated as evil/remote in mail preview ( #5580 )
7 years ago
3723f3f178
Fix rcube_utils::random_bytes() to not throw exception for length=0
7 years ago
130f0cde3e
Add host to IMAP login error
...
This simplifies debugging authentication failures in multi-host setups.
7 years ago
72fe97ddfc
Fix bug where HTML messages could have been rendered empty on some systems ( #5957 )
...
Consistently use $nodeName instead of $tagName property.
7 years ago
ee6b5e9e58
Fix PHP 7.2 error: count(): Parameter must be an array or an object that implements Countable
7 years ago
fa3eb6813f
Ignore rewind() warnings ( #5950 )
7 years ago
3a77c906a1
Merge branch 'master' into dev-elastic
7 years ago
7fc626d527
Changed defaults for smtp_user (%u), smtp_pass (%p) and smtp_port (587)
7 years ago
cdcbad1879
Handle inline images also inside multipart/mixed messages ( #5905 )
7 years ago
2d608a799c
Fix decoding message/rtf822 part body/size
...
When e.g. an encrypted message has one of it's sub-parts a part that is message/rfc822
part we need it's body and size, because it will be listed on the attachments list
and also can be downloaded.
7 years ago
1235dcf321
Encode JSON with JSON_UNESCAPED_SLASHES and JSON_UNESCAPED_UNICODE options
7 years ago
919338d4ba
Escape textarea contents in Washtml
7 years ago
1c24c69a3b
Fix path for css file existence check in include_stylesheet()
7 years ago
4a71847c98
Fix bug where last character of a filename extracted from TNEF could be truncated ( #5799 )
7 years ago
69f50b122d
Add a way to include plugin stylesheets optionally only if the file exists
7 years ago
fc1a0a1f65
Fix bug where messages count was not updated after delete when imap_cache is set ( #5872 )
7 years ago
76adb49454
Support for IMAP folders that cannot contain both folders and messages ( #5057 )
7 years ago
b97e3b5cd7
Don't ignore (global) userlogins/sendmail logs in per_user_logging mode
7 years ago
e04f72d018
Fix PHP 7.2 warnings on count() use ( #5845 )
7 years ago
97bf251dc6
Don't use create_function() deprecated in PHP 7.2
7 years ago
86a4d78369
Merge branch 'dev-elastic'
7 years ago
05ea5a5548
Add ignore_errors option to rcube_db, so error logging can be disabled temporarily
...
Use ignore_errors to make sure the DDL upgrade errors are printed only once.
7 years ago
9d63b80873
Fix bug where errors were not printed when using bin/update.sh ( #5834 )
...
Don't pass errors to rcmail_install::raise_error() in CLI mode.
7 years ago
a8278d61cf
Update changelog, CS fixes
7 years ago
8b7c7dd5a9
Merge branch 'issue-logfilename' of https://github.com/remicollet/roundcubemail into remicollet-issue-logfilename
7 years ago
21e7d873ce
Fix so links over images are not removed in plain text signatures converted from HTML ( #4473 )
7 years ago
6a83c3cc18
Fix fatal error when using DMY- or MDY-based date format in PostgreSQL ( #5808 )
7 years ago
1fcf7bfab3
Fix bug where HTML messages with @media styles could moddify style of page body ( #5811 )
7 years ago
f0431c7475
Fix uninitialized string offset in rcube_utils::bin2ascii() and make sure rcube_utils::random_bytes() result has always requested length ( #5788 )
7 years ago
0bef84c410
Fix decoding non-ascii attachment names from TNEF attachments ( #5646 , #5799 )
7 years ago
6ca4eab399
add 'log_file_ext' configuration option
7 years ago
bcc6405552
Fix various issues when downloading files with names containing non-ascii chars, use RFC 2231 ( #5772 )
7 years ago
3bc8a30314
Translate old 'preview_pane' setting into new 'layout' property
8 years ago
27a621818d
Make sure rcube_utils::resolve_url() does not add port 80 to the url
...
...which might have happened with reverse proxies
8 years ago
7c001260fa
Simplified code to parse METADATA responses
8 years ago
76170baac0
Fix bug where it wasn't possible to set timezone to auto-detected value ( #5782 )
8 years ago
6ad4ebe431
Fix SQL syntax error on MariaDB 10.2 ( #5774 )
8 years ago
bb67757b5c
Removed global $CONFIG variable
8 years ago
9a63e40faf
Accept an array as $input argument of decode_address_list()
...
... to support a common case and to prevent from PHP warnings.
8 years ago
336a0cd87b
strncasecmp() -> strcasecmp()
8 years ago
f7809af6e4
Support AUTHENTICATE LOGIN for IMAP connections ( #5563 )
...
Add imap_auth_type=IMAP to force use of LOGIN instead of AUTHENTICATE LOGIN.
In imap_auth_type=CHECK mode prefer LOGIN over AUTHENTICATE LOGIN (for performance reasons).
8 years ago
253aac5d9e
Fix var name
8 years ago
0a7a95b714
Support LDAP GSSAPI authentication ( #5703 )
...
Requires https://git.kolab.org/rPNL1d87f98d300645e15b7ad2819fcffb19010a060f
8 years ago
59e5cef08c
Allow contacts without an email address ( #5079 )
8 years ago
5101cfc67a
Bump version to 1.4-git
8 years ago
9858c2a294
Merge branch 'master' into dev-elastic
8 years ago
d151afd229
Fix addressbook searching by gender ( #5757 )
8 years ago
5804ef8aa2
Fix folders list sorting on Windows - if php-intl is available ( #5732 )
8 years ago
8f22c3287d
Fix bug where comment notation within style tag would cause the whole style to be ignored ( #5747 )
8 years ago
9ff7b78c7e
Fix conflict with _gid cookie of Google Analytics ( #5748 )
...
TODO: Review the whole code base and don't use INPUT_GPC when it's not really needed,
in most cases we should not read $_COOKIE.
8 years ago
e800fb5a19
Bring back unintentionally removed .SILENT suffix in STORE FLAGS command
8 years ago
d1cf69562f
CS fixes and return values fixes
8 years ago
40b51b9dc9
Add Log to STDOUT Feature ( #5721 )
...
Primarily useful for PHP applications running under PHP-FPM which in
turn is running within a Docker container. But also it is generally
useful in any situation where you want to be able to send the logs
directly to your terminal when debugging &etc.
8 years ago
712875bde1
Fix bug where base_dn setting was ignored inside group_filters ( #5720 )
8 years ago
72f19c079f
Installer: Fix DB schema initialization on MS SQL Server
8 years ago
e160e48069
Fix undesired effects when postgres database uses different timezone than PHP host ( #5708 )
...
Allow passing DateTime variables as query arguments. Their value will
be converted to date/time input string in format specific to the database type
(with timezone on postgres).
8 years ago
19fcc35a55
Fix regression in LDAP fuzzy search where it always used prefix search instead ( #5713 )
8 years ago
89a4134064
Add support for DelSp=Yes messages ( #5702 )
8 years ago
9b554cd3d5
Remove redundant spaces from generated contact names
8 years ago
9a35768c26
spelling fixes ( #5690 )
8 years ago
132a807dff
add .log suffix to all log file names
8 years ago
bf21557873
Better fix for XSS in style tags ( b59ff5ca)
8 years ago
05aae4711c
Replace xss_entity_decode_callback() method with lambda function
8 years ago
b59ff5cafb
Fix XSS issue in handling of a style tag inside of an svg element
8 years ago
fa32c2c471
Plugin API: Call message_part_structure hook for sub-parts of multipart/alternative message ( #5678 )
8 years ago
51dbc2e438
Merge branch 'master' of github.com:roundcube/roundcubemail
8 years ago
9028e77290
Enigma: Set micalg parameter to real hash algorithm used for signing
8 years ago
0b385dc946
Skip iconv for problematic ISO-2022-JP strings ( #5668 )
...
We sometimes get broken character encodings such as:
Subject: =?iso-2022-jp?B?GyRCLWo7M3l1OSk2SBsoQgo=?=
This actually is not a strict ISO-2022-JP string, but a CP50220 string
that is a variant of ISO-2022-JP with extended characters proposed by
Microsoft. Iconv can not handle these encodings well.
8 years ago
adbab9d3e2
Merge branch 'master' into dev-elastic
8 years ago
e2d80479d6
Make possible to set (some) config options from a skin
8 years ago
3c1d951d84
feat(Hook) full message object on message_sent event
8 years ago
81f67a4de2
Don't use each() deprecated in PHP 7.2
8 years ago
dfd19206a4
sizeof() -> count()
8 years ago
8131629c6e
Extended unified searchform object for templates engine
8 years ago
e08f22ef28
Fix bug where external content in src attribute of input/video tags was not secured ( #5583 )
8 years ago
7340360e79
Fix bug where image data URIs in css style were treated as evil/remote in mail preview ( #5580 )
8 years ago
f78e2a4367
Add 1.3-beta milestone + update copyright year
8 years ago
de82576134
Add mime type detection under FreeBSD and Apache 2.4 ( #5560 )
8 years ago
4f5ec65a36
Close SMTP connection ASAP after the message has been sent
...
We should not keep the connection open until the script shuts down.
It may take long time e.g. to save the message in IMAP.
8 years ago
a99e479cb4
Fix variable substitution in ldap host for some use-cases, e.g. new_user_identity ( #5544 )
8 years ago
32b68959b2
Merge branch 'master' of github.com:roundcube/roundcubemail
8 years ago
a1f679adca
Fixed redundancy in sql caching system and compatibility with Galera Cluster ( #5439 )
...
- Removed redundant 'created' column from cache and cache_shared tables
- Removed use of redundant data records
- Added missing primary keys (dictionary, cache, cache_shared tables)
8 years ago
940a27400e
Use GSSAPI only if configured ( #5530 )
8 years ago
5cca1988b6
Fix write_log() return value when using syslog() and it fails
8 years ago
a844db6a27
Merge branch 'dev-layouts'
8 years ago
8a76bf3783
Make sure $prefs property is an array ( #5523 )
8 years ago
e306328340
Fix storing "empty" values in rcube_cache/rcube_cache_shared ( #5519 )
8 years ago
7e90de4ef5
write_record() should return boolean value
8 years ago
68221ed4ae
Improve uppercase/lowercase/ucfirst attrib handling in rcube::gettext()
...
- Make ucfirst mode compatible with UTF-8
- Fix bug which made uppercase=FIRST non-working
- Replace \n with real line-break before converting char case
8 years ago
6e0effa54c
Fix "Illegal string offset" warning in rcube::log_bug() on PHP 7.1 ( #5508 )
8 years ago
e17e8851f1
CS improvements, _xor() method replaced with an anonymous function
8 years ago
556c1725a7
Unify automatic marking as \Seen in preview pane, full-page and extwin views ( #5071 )
...
We now have one 'mail_read_time' option that works for all cases.
Option 'preview_pane_mark_read' has been removed and marked as an alias.
8 years ago
f43f5bf93f
Use JSON_PRETTY_PRINT in devel_mode
...
This effectively makes PHP 5.4 a real requirement
8 years ago
4e0532808d
Fix bug where it wasn't possible to store more that 2MB objects in memcache/apc ( #5452 )
...
Added memcache_max_allowed_packet and apc_max_allowed_packet settings
8 years ago
cf9f0d8829
Fix bug where IMAP password could be exposed via error message ( #5472 )
8 years ago
b8f9ba7d47
Fix bug where deleting folders with subfolders could fail in some cases ( #5466 )
8 years ago
b258b91560
Do not show inline images of unsupported mimetype ( #5463 )
8 years ago
8a51607671
Fix regression where creation of default folders wasn't functioning without prefix ( #5460 )
8 years ago
9e129383a1
Improve randomness of password salts and random hashes ( #5266 )
8 years ago
195dc11855
Support host-specific imap_conn_options/smtp_conn_options/managesieve_conn_options ( #5136 )
8 years ago
8c75dd3aa8
Add convenient method to create new session records
8 years ago
42ddfe5ec9
Simplify mbstring code path in rcube_charset::convert()
8 years ago
c1c0a0d815
Implemented rcube::sleep() method for disconnecting all external connection in long-running/sleeping scripts
8 years ago
f92052fd73
Fix so when moving to Trash we make sure the folder exists ( #5192 )
8 years ago
2999cc38a5
Generate more compact HTML5 code, e.g. use short form of boolean attributes
8 years ago
defdf84bb7
Really fix login form regression
...
Remove 'form' from allowed attributes list of input field. We needed
it only for a moment, now we don't. It's also not supported by IE/Edge
which means there's no way we would need it. Maybe some day...
8 years ago
32e5a6bbcf
Fix bug where folder creation could fail if personal namespace contained more than one entry ( #5403 )
...
+ small code improvements
8 years ago
43f3c5fb2a
Implement "one click" attachment upload ( #5024 )
8 years ago
c65bb121eb
Describe Framework requirements, drop some redundant code (since we require mbstring)
8 years ago
9debc38724
Drop mail_header_delimiter option, since we don't use mail() we don't need it
8 years ago
184de7735c
CS fixes (mostly phpdoc)
8 years ago
2298ecf7f6
Fix E_DEPRECATED warning when using Auth_SASL::factory() ( #5401 )
8 years ago
0836b213db
Removed useless 'created' column from 'session' table ( #5389 )
8 years ago
94f8ce3334
Make html::parse_attrib_string() more robust
...
Fixes PHP Error: Expression parse error on: ($app->config->get('preview_pane',rcube_utils::get_boolean('')) == true ? ' checked=checked' : ')
8 years ago
062d95503e
Fix bug where Message-ID domain part was tied to username instead of current identity ( #5385 )
8 years ago
55cdf1569e
Support contact+group searches in all relevant places (T1360)
...
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.
8 years ago
ee00d949c4
Properly set the memcache debug log file name
...
Properly set the debug log file name ('memcache') as $this->type is undefined
8 years ago
53b5ccfb0c
Fix regression where LDAP results could be counted incorrectly when using VLV
...
... broken by d08bd0a51f
8 years ago
dcabc1d814
Merge remote-tracking branch 'upstream/master'
...
Conflicts:
tests/Framework/Washtml.php
8 years ago
c3fc072d97
Remove code related to magic_quotes_* and register_globals
...
...they do not exist in PHP 5.4 which we now require.
8 years ago
906cf101c3
Better time handling in rcube_utils::clean_datestr()
8 years ago
ec1525a1e6
Remove debug code
8 years ago
ed35267b9b
Managesieve: Fix parsing of vacation date-time with non-default date_format ( #5372 )
...
Added new method rcube_utils::format_datestr() to convert date_format date
into ISO date format.
8 years ago
2f2765ab43
Fix regression in resizing JPEG images with Imagick ( #5376 )
8 years ago
d91bad5975
Fix handling of blockquote tags with mixed case on html2text conversion ( #5363 )
8 years ago
7a7a6795f0
Support WEBP images in mail messages ( #5362 )
8 years ago
6626328e7c
We already require PEAR, so it's not needed to check if PEAR class exists.
...
Sooner or later it will fail if PEAR does not exist, so better to do this sooner.
8 years ago
edfd9da42a
Support MathML in HTML message preview ( #5182 )
8 years ago
ee895a2c96
Remove PHP mail() support, smtp_server is required now ( #5340 )
8 years ago
e13deb2e47
Merge branch 'master' of github.com:roundcube/roundcubemail
8 years ago
930e363e55
Fix handling of 'mailto' and 'error' arguments in message_before_send hook ( #5347 )
8 years ago
d2d4f867e5
Merge pull request #5350 from demis-palma/fix-encoding
...
Fixed wrong encoding in currency symbols
8 years ago
dc6cfe1eec
Merge pull request #5351 from fliespl/patch-1
...
Remove use of deprecated method Imagick::flattenImages
8 years ago
9a2264ba0e
Fix regression where messages with no text part (but e.g. application/zip) were not displayed as an attachment ( #5357 )
8 years ago
10c032165b
Remove deprecated function flattenImages
...
flattenImages in imagick is deprecated since php 5.6.
`PHP Deprecated: Imagick::flattenImages method is deprecated and it's use should be avoided `
Proposed solution works with imagick 3.1.0+.
11 is used as an alternative to `Imagick::ALPHACHANNEL_REMOVE` which was added in imagick 3.2.0.
8 years ago
411bd3fe82
Fixed wrong encoding in currency symbols
8 years ago
997e82d2b2
Merge pull request #5326 from raoulbhatia/autoload
...
Translate PHP namespaces into directories
8 years ago
8e7e22c656
Avoid PHP fatal error
...
After last change to file `rcube_ldap.php`, my roundcube instance was getting this error:
```
PHP Fatal error: Cannot use object of type Net_LDAP3_Result as array in ...
```
In
```php
protected function extended_search($count = false)
```
`$result = $this->ldap->search()` returns a LDAP object (whatever package we use).
If the search returns no results (and if `$is_extended_search` is false), then it gets to line 971 trying to do a `usort()` and then a `count()` on an object, instead of an array.
8 years ago
c08ca018d8
Get rid of rcube_imap_generic::strToTime() in favor of rcube_utils::strtotime()
9 years ago
7122df719d
Translate PHP namespaces into directories
9 years ago
d08bd0a51f
Searching in both contacts and groups when LDAP addressbook with group_filters option is used
9 years ago
22241a5d82
CS fixes
9 years ago
58c036116b
Support type=password in rcube_output::get_edit_field()
9 years ago
f2eafda539
Fix bug where microsecond format in logged date didn't work in some cases
9 years ago
5e1277e971
Trim error message
9 years ago
f840abe6e0
Don't add HTTP response body/headers to the spellchecker error message (it is displayed to the user)
9 years ago
c478536741
Make SQL selects less expensive in memory for some cases where we fetch big data chunks
9 years ago
c76c4ed08b
Workaround PHP issue by calling closelog() on script shutdown when using log_driver=syslog ( #5289 )
9 years ago
d61d33a12a
Fix handling of --delete argument in moduserprefs.sh script ( #5296 )
9 years ago
f466899d8d
Simplified code
9 years ago
7864a98f08
Fix searching by email address in contacts with multiple addresses ( #5291 )
9 years ago
6737e293bb
Wash position:fixed style in HTML mail for better security ( #5264 )
9 years ago
0ce7c493a8
Fix multi-folder search issues in "this and subfolders" scope ( #5282 , #5259 )
...
- Fix bug where multi-folder search could choose a wrong folder
- Fix bug where multi-folder search didn't work for unsubscribed INBOX
9 years ago
930a3ceac0
Fix bug where errors could have been not logged when per_user_logging=true
9 years ago
3a2874c77c
Remove check for multiple dots in local-part
9 years ago
0e809364e7
Support SMTPUTF8, relax email restrictions
...
If the FROM/TO portions of an email use non-ASCII characters,
check that the SMTP server supports the SMTPUTF8 extension.
Additionally, change some rules for parsing email addresses to
allow for more characters. Basically, SMTPUTF8 states that
nearly any printable character is a valid character in an
email address.
9 years ago
3d0d5dbd0f
Performance improvements in format_flowed() and unfold_flowed()
9 years ago
afd090672c
Small performance optimization
9 years ago
6652367d65
Fix XSS issue in href attribute on area tag ( #5240 , #5241 )
9 years ago
4921c21cff
Optimize SELECT response handling
9 years ago
344b0af9c6
Indicate that a collapsed thread has flagged children ( #5013 )
9 years ago
9796cd2063
Merge branch 'dev-rfc822-preview'
...
Conflicts:
CHANGELOG
program/steps/mail/show.inc
9 years ago
9634169647
Bump version number to 1.3-beta
9 years ago
0eece8222b
Fix autoloading of 'html' class and improve autoloader performance
9 years ago
5e406f7b7e
Disable links list when converting html2text for spellchecking
9 years ago
52106ffd39
Fix bug where rcube_contacts::get_record() could return cached result when requested record wasn't found ( #5218 )
9 years ago
e2e56261b9
Fix handling of long script/style tags when converting to text
9 years ago
a0f38f5fd8
Small code style improvements
9 years ago
e8ab3d96bd
Fix converting mail addresses with @www. into mailto links ( #5197 )
9 years ago
d01c06eded
CS fixes
9 years ago
70a8236cd5
mailbox/listing: Make server response for large mailbox listing faster when using threaded view
...
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.
Mailbox index view timing: ~360 ms
Mailbox threaded view timing: ~800 ms
Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.
This optimization is already present in index view handler, but was missing
from threaded view.
Results after optimization
==========================
Both average out around ~360 ms response time.
9 years ago
c72446a8fc
Allow pattern attribute in input
...
"pattern" included in the list of allowed attributes in the input tag
9 years ago
6f2c007d1b
CS fixes: Replace use of "bool ? true : false" with just "bool"
9 years ago
5c253dd59e
Fix so SPECIAL-USE assignments are forced only until user sets special folders ( #4782 )
...
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
9 years ago
7462095f60
Small code improvements
9 years ago
e8b6e726f6
Add message menu with viewsource and edit actions in message/rfc822 preview
9 years ago
ce3105c58f
Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview
9 years ago
323fa20bc8
Message/rfc822 attachment preview ( #5054 )
9 years ago
05972d7b33
Refer to Github issues instead of Trac
9 years ago
791ee65d2e
Fix so contactlist_fields option can be set via config file
9 years ago
348ec70f12
Export vCard PHOTO with "ENCODING=b" (instead of "ENCODING=B") as specified in RFC2426
9 years ago
4a408843b0
Protect download urls against CSRF using unique request tokens ( #1490642 )
...
Send X-Frame-Options headers with every HTTP response
9 years ago
d4df3748cf
Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix)
9 years ago
ca34ba139e
CS fixes
9 years ago
dsoares