Commit Graph

6116 Commits (2a2b04eb2acc156a7812a417d2a03efccd883471)

Author SHA1 Message Date
Aleksander Machniak 2a2b04eb2a Remove redundant spaces from generated contact names 8 years ago
Thomas Bruederli f1483204c7 Bump version to 1.1.8 8 years ago
Thomas Bruederli d6ddd31a1b Better fix for XSS in style tags (9b5eee294) 8 years ago
Aleksander Machniak 9b5eee2946 Fix XSS issue in handling of a style tag inside of an svg element 8 years ago
Aleksander Machniak 11b65a905f Make sure date_create_from_format() exists
Only for Roundcube 1.1 (this function does not exist on PHP < 5.3)
8 years ago
Aleksander Machniak 7536739c7a Fix bug where microsecond format in logged date didn't work in some cases 8 years ago
Aleksander Machniak 6c6b299d2a Fix so microseconds macro (u) in log_date_format works (#1490446) 8 years ago
Aleksander Machniak b7a4257ffb Rename $sql_arr variable to $record as it's not about sql only 8 years ago
Aleksander Machniak 4cd090aa24 Fix regression where groups with email address were resolved to its members' addresses 8 years ago
Aleksander Machniak fca2bb7869 Fix visual glitch when using disabled_actions for items in Settings menu 8 years ago
Aleksander Machniak f8e0e1d4ed Fix bug where signature couldn't be added above the quote in Firefox 51 (#5628) 8 years ago
Aleksander Machniak 72975042a5 Fix bug where mail content frame couldn't be reset in some corner cases (#5608)
Conflicts:
	CHANGELOG
8 years ago
Aleksander Machniak e6132dda95 Fix so group/addressbook selection is retained on page refresh 8 years ago
Aleksander Machniak 28e3da2325 Disable Print button for pdf attachments in Firefox (#5125)
Mozilla's PDF.js viewer does not allow printing from host page.
We try to detect such situation and disable the button to minimize
user confusion.
8 years ago
Thomas Bruederli 4c1394cf2d Bump version to 1.1.7 8 years ago
Aleksander Machniak 45a3e81653 Fix vulnerability in handling of mail()'s 5th argument 8 years ago
Aleksander Machniak aa6bf38843 Fix _from argument validation 8 years ago
Aleksander Machniak 860a3b47e7 Fix recognizing Sent folder on search if current folder has been changed by plugins in meantime 8 years ago
Bostjan Skufca 9b8db4c9e0 Autocomplete refactoring: replace variable name '$id' with '$abook_id'
Reason:
Having genericly named variable $id in nested loops makes code unreadable.
Replacing generic name '$id' with '$ENTITIY_id' format removes all ambiguity.
8 years ago
Aleksander Machniak 1123f39cf4 Fix missing contact ID for contacts from non-sql addressbooks 8 years ago
Bostjan Skufca 6fb8da08f3 Autocomplete search: add id and source (addressbook) into resulting contact data array
Two reasons:
- provide it to plugin backend functions that use 'contacts_autocomplete_after' hook
- provide it to frontend

Why to frontend?
If plugin JS adds an 'autocomplete_insert' hook we need to provide it with exact
autocomplete data. Providing it with name and email address only, without pinpointing
exact origin of this autocomplete result, will severely limit learning capabilities of
potential future autocomplete implementations.
8 years ago
Thomas Bruederli 802d119153 Bump version to 1.1.6 8 years ago
Aleksander Machniak 008f310f3a de_DE: abboniert -> abonniert 8 years ago
Aleksander Machniak 32ddcfd3d0 Fix error causing empty INBOX listing in Firefox when using an URL with user:password specified (#5400) 8 years ago
Aleksander Machniak 8e2fdee671 Fix de_DE translation for 'open' action (T1456) 8 years ago
Aleksander Machniak 93cb7b1fea Support contact+group searches in all relevant places (T1360)
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.

Conflicts:

	program/lib/Roundcube/rcube_addressbook.php
	program/lib/Roundcube/rcube_contacts.php
	program/steps/mail/search_contacts.inc
8 years ago
Aleksander Machniak 3f10f9a2e6 Fix regression where LDAP results could be counted incorrectly when using VLV
... broken by d08bd0a51f where we added searching in users+groups in one request
8 years ago
Aleksander Machniak 425e31dc27 Wash position:fixed style in HTML mail for better security (#5264) 8 years ago
Aleksander Machniak b2781e145e Fix German localization label 9 years ago
Aleksander Machniak 4fa70856b9 Fix handling of blockquote tags with mixed case on html2text conversion (#5363)
Conflicts:
	CHANGELOG
9 years ago
Aleksander Machniak d10c591a61 Merge pull request #5330 from urc/patch-1
Do not mask fatal error when unable to load PEAR class
9 years ago
Aleksander Machniak 25510199be Don't create multipart/alternative messages with empty text/plain part (#5283)
Conflicts:
	CHANGELOG
	program/steps/mail/sendmail.inc
9 years ago
Thomas Bruederli f1d80c649e Avoid sending completely empty text parts for multipart/alternative messages (#5283) 9 years ago
Aleksander Machniak fbf89913a3 Fix missing localization of HTML editor when assets_dir != INSTALL_PATH
Conflicts:
	CHANGELOG
9 years ago
Aleksander Machniak 72a09408e9 Use contact_search_name format in popup on results in compose contacts search
Conflicts:

	CHANGELOG
	program/steps/mail/search_contacts.inc
9 years ago
dsoares f85227358a Avoid PHP fatal error
After last change to file `rcube_ldap.php`, my roundcube instance was getting this error:
```
PHP Fatal error:  Cannot use object of type Net_LDAP3_Result as array in ...
```
In
```php
protected function extended_search($count = false)
```
`$result = $this->ldap->search()` returns a LDAP object (whatever package we use).
If the search returns no results (and if `$is_extended_search` is false), then it gets to line 971 trying to do a `usort()` and then a `count()` on an object, instead of an array.
9 years ago
Aleksander Machniak ac592fd169 Searching in both contacts and groups when LDAP addressbook with group_filters option is used
Conflicts:

	CHANGELOG
	program/steps/addressbook/search.inc
9 years ago
urc 3e508e9587 Do not mask fatal error
A failure to load PEAR consistutes a fatal PHP error, and @-loading it prevents that error from being logged, making debugging problems with loading the PEAR class really difficult. It should therefore be loaded without the @ sign, allowing the fatal error to end up in the logs, if it occurs.
9 years ago
Aleksander Machniak e48f8945b3 Fix bug where message list columns could be in wrong order after column drag-n-drop and list sorting
Conflicts:
	CHANGELOG
9 years ago
Aleksander Machniak 73f411db7d Add missing sigbelow label in german localizations 9 years ago
Aleksander Machniak 7d14065baa Fix XSS issue in href attribute on area tag (#5240, #5241)
Conflicts:

	CHANGELOG
9 years ago
Aleksander Machniak 550143269a Fix message list multi-select/deselect issue (#5219)
Conflicts:

	CHANGELOG
9 years ago
Thomas Bruederli 25bc871ee7 Bump version to 1.1.5 9 years ago
Aleksander Machniak ead0846934 Plugin API: Add html2text hook (backport from master) 9 years ago
Aleksander Machniak 848410042c Fix converting mail addresses with @www. into mailto links (#5197) 9 years ago
Aleksander Machniak c91d4975ff Make sure an email address is valid when replacing it with mailto: link 9 years ago
Aleksander Machniak d54eb6c951 CS fixes 9 years ago
Bostjan Skufca 55d90b2f62 mailbox/listing: Make server response for large mailbox listing faster when using threaded view
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.

Mailbox index view timing:    ~360 ms
Mailbox threaded view timing: ~800 ms

Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.

This optimization is already present in index view handler, but was missing
from threaded view.

Results after optimization
==========================
Both average out around ~360 ms response time.
9 years ago
Aleksander Machniak 473dc0b86d Fix so SPECIAL-USE assignments are forced only until user sets special folders (#4782)
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
9 years ago
Aleksander Machniak 86bc1f95ea Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix)
Conflicts:
	INSTALL
9 years ago