From fe796d4040788ace1291557ff6a18b3ce6c1a37d Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Fri, 31 Jan 2020 09:58:03 +0100 Subject: [PATCH] Remove useless pass-by-reference --- plugins/managesieve/lib/Roundcube/rcube_sieve.php | 2 +- program/lib/Roundcube/rcube_imap.php | 2 +- program/lib/Roundcube/rcube_imap_generic.php | 2 +- program/lib/Roundcube/rcube_smtp.php | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/managesieve/lib/Roundcube/rcube_sieve.php b/plugins/managesieve/lib/Roundcube/rcube_sieve.php index 2ee76615a..fc509c01b 100644 --- a/plugins/managesieve/lib/Roundcube/rcube_sieve.php +++ b/plugins/managesieve/lib/Roundcube/rcube_sieve.php @@ -476,7 +476,7 @@ class rcube_sieve /** * This is our own debug handler for connection */ - public function debug_handler(&$sieve, $message) + public function debug_handler($sieve, $message) { rcube::write_log('sieve', preg_replace('/\r\n$/', '', $message)); } diff --git a/program/lib/Roundcube/rcube_imap.php b/program/lib/Roundcube/rcube_imap.php index ee2d49d26..970231523 100644 --- a/program/lib/Roundcube/rcube_imap.php +++ b/program/lib/Roundcube/rcube_imap.php @@ -4564,7 +4564,7 @@ class rcube_imap extends rcube_storage /** * This is our own debug handler for the IMAP connection */ - public function debug_handler(&$imap, $message) + public function debug_handler($imap, $message) { rcube::write_log('imap', $message); } diff --git a/program/lib/Roundcube/rcube_imap_generic.php b/program/lib/Roundcube/rcube_imap_generic.php index 507fc09b9..37e9ca9bc 100644 --- a/program/lib/Roundcube/rcube_imap_generic.php +++ b/program/lib/Roundcube/rcube_imap_generic.php @@ -4093,7 +4093,7 @@ class rcube_imap_generic } if ($this->debug_handler) { - call_user_func_array($this->debug_handler, array(&$this, $message)); + call_user_func_array($this->debug_handler, array($this, $message)); } else { echo "DEBUG: $message\n"; diff --git a/program/lib/Roundcube/rcube_smtp.php b/program/lib/Roundcube/rcube_smtp.php index f9b28112b..d78ea4a2a 100644 --- a/program/lib/Roundcube/rcube_smtp.php +++ b/program/lib/Roundcube/rcube_smtp.php @@ -377,7 +377,7 @@ class rcube_smtp /** * This is our own debug handler for the SMTP connection */ - public function debug_handler(&$smtp, $message) + public function debug_handler($smtp, $message) { // catch AUTH commands and set anonymization flag for subsequent sends if (preg_match('/^Send: AUTH ([A-Z]+)/', $message, $m)) {