From b8445cdcb9c15f1185db3538229ee23f85f8e084 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Tue, 17 Jun 2014 10:04:28 +0200 Subject: [PATCH 1/2] Small icon alignment fix --- skins/larry/mail.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/skins/larry/mail.css b/skins/larry/mail.css index 6a2e3f440..85da97460 100644 --- a/skins/larry/mail.css +++ b/skins/larry/mail.css @@ -643,7 +643,7 @@ table.messagelist.fixedcopy { } .messagelist thead tr th.attachment span.attachment { - background-position: -24px -997px; + background-position: -24px -996px; } .messagelist tbody tr td.attachment span.report { @@ -651,7 +651,7 @@ table.messagelist.fixedcopy { } .messagelist thead tr th.priority span.priority { - background-position: -24px -1845px; + background-position: -25px -1845px; } .messagelist tr td.priority span.prio5 { @@ -675,7 +675,7 @@ table.messagelist.fixedcopy { } .messagelist thead tr th.flag span.flagged { - background-position: -22px -1036px; + background-position: -22px -1037px; } .messagelist tr:hover td.status span.msgicon { From db7dcf0936069b7d9ac5595c37f6c2aacc5c4ed7 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Tue, 17 Jun 2014 10:17:15 +0200 Subject: [PATCH 2/2] Close "no subject" prompt with Enter key (#1489580) --- CHANGELOG | 1 + program/js/app.js | 26 ++++++++++++++++---------- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index d2fc4faaf..f92f8df5b 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,7 @@ CHANGELOG Roundcube Webmail =========================== +- Close "no subject" prompt with Enter key (#1489580) - Add config option to specify IMAP connection socket parameters - imap_conn_options (#1489948) - Password: Add option to force new users to change their password (#1486884) - Improve support for screen readers and assistive technology using WCAG 2.0 and WAI ARIA standards diff --git a/program/js/app.js b/program/js/app.js index 82b69c4db..2b6adae28 100644 --- a/program/js/app.js +++ b/program/js/app.js @@ -3553,26 +3553,32 @@ function rcube_webmail() myprompt = $('
').html('
' + this.get_label('nosubjectwarning') + '
') .appendTo(document.body), prompt_value = $('').attr({type: 'text', size: 30}).val(this.get_label('nosubject')) - .appendTo(myprompt); - - buttons[this.get_label('cancel')] = function(){ - input_subject.focus(); - $(this).dialog('close'); + .appendTo(myprompt), + save_func = function() { + input_subject.val(prompt_value.val()); + myprompt.dialog('close'); + ref.command(cmd, { nocheck:true }); // repeat command which triggered this + }; + + buttons[this.get_label('sendmessage')] = function() { + save_func($(this)); }; - buttons[this.get_label('sendmessage')] = function(){ - input_subject.val(prompt_value.val()); + buttons[this.get_label('cancel')] = function() { + input_subject.focus(); $(this).dialog('close'); - ref.command(cmd, { nocheck:true }); // repeat command which triggered this }; myprompt.dialog({ modal: true, resizable: false, buttons: buttons, - close: function(event, ui) { $(this).remove() } + close: function(event, ui) { $(this).remove(); } + }); + + prompt_value.select().keydown(function(e) { + if (e.which == 13) save_func(); }); - prompt_value.select(); return false; }