Elastic: Fix buttons (again)

Last change make the button height too small, imo. Also in broke
slightly dialog buttons on mobile. The change also improves some
specific button styles, e.g. dialog Close button.

skins/elastic/styles/widgets/buttons.less

@@ -151,13 +151,13 @@ button.btn {
 
 a.btn,
 button.btn {
+    line-height: 1.8;
+
     &:before {
-        display: inline-block !important;
+        margin-right: .4rem;
-        float: none !important;
+        height: 1.8rem;
-        margin-top: -0.3rem;
+        line-height: 1.8rem;
-        margin-right: 0.4rem;
+        width: 1em;
-        position: relative;
-        top: 0.15rem;
     }
 }
 
@@ -216,6 +216,12 @@ html.touch {
 
 /*** Bootstrap button style overrides ***/
 
+.btn {
+    &:focus {
+        box-shadow: 0 0 0 .2rem fade(@color-btn-primary-background, 30%);
+    }
+}
+
 .btn-secondary {
     color: @color-btn-secondary;
     background: @color-btn-secondary-background;

skins/elastic/styles/widgets/forms.less

@@ -69,6 +69,8 @@ input.smart-upload {
             &:before {
                 &:extend(.font-icon-class);
                 content: @fa-var-plus;
+                line-height: 2.3rem;
+                height: 2.3rem;
 
                 @media screen and (min-width: (@screen-width-bs-phone + 1px)) {
                     margin: 0;

skins/elastic/styles/widgets/jqueryui.less

@@ -84,14 +84,14 @@
         right: 0;
         top: 0;
         position: absolute;
-        height: (@layout-header-height - .7rem);
+        padding: .25rem;
-        margin: .25rem;
+        margin: ((@layout-header-height - 2rem) / 2) .5rem;
-        padding-bottom: .375rem;
-        cursor: pointer;
 
         &:before {
             &:extend(.font-icon-class);
             content: @fa-var-times;
+            line-height: 1.5rem;
+            height: 1.5rem;
         }
     }
 
@@ -214,9 +214,11 @@
                     height: @layout-header-height;
                     box-shadow: none;
                     font-size: 90%;
+                    line-height: 1.5;
 
                     &:before {
                         display: block !important;
+                        float: none;
                         width: auto;
                         height: 1.75rem;
                         line-height: 1.75;