Improve plugin selection in installer; check already selected plugins

pull/244/head
Thomas Bruederli 10 years ago
parent d1bf0feed4
commit b737021a90

@ -680,10 +680,11 @@ echo $select_param_folding->show(strval($RCI->getprop('mime_param_folding')));
$plugins = $RCI->list_plugins();
foreach($plugins as $p)
{
$p_check = new html_checkbox(array('name' => '_plugins_'.$p['name'], 'id' => 'cfgplugin_'.$p['name']));
echo '<dt class="propname">'.$p['name'].'</dt><dd>';
echo $p_check->show(0, array('value' => $p['name']));
echo '<label for="cfgplugin_'.$p['name'].'">'.$p['desc'].'</label><br/></dd>';
$p_check = new html_checkbox(array('name' => '_plugins_'.$p['name'], 'id' => 'cfgplugin_'.$p['name'], 'value' => $p['name']));
echo '<dt class="propname"><label>';
echo $p_check->show($p['enabled'] ? $p['name'] : 0);
echo '&nbsp;' . $p['name'] . '</label></dt><dd>';
echo '<label for="cfgplugin_'.$p['name'].'" class="hint">' . $p['desc'] . '</label><br/></dd>';
}
?>

@ -578,17 +578,18 @@ class rcmail_install
foreach (glob($plugin_dir . '*') as $path)
{
if (is_dir($path) && file_exists($path.'/composer.json'))
if (is_dir($path) && is_readable($path.'/composer.json'))
{
$file_json = json_decode(file_get_contents($path.'/composer.json'));
$plugin_desc = $file_json->description;
$plugin_desc = $file_json->description ?: 'N/A';
}
else
{
$plugin_desc = 'N/A';
}
$plugins[] = array('name' => substr($path, strlen($plugin_dir)), 'desc' => $plugin_desc);
$name = substr($path, strlen($plugin_dir));
$plugins[] = array('name' => $name, 'desc' => $plugin_desc, 'enabled' => in_array($name, $this->config['plugins']));
}
return $plugins;

Loading…
Cancel
Save