Tests: Add Identities tests

tests/Browser/Components/App.php

@@ -96,7 +96,7 @@ class App extends Component
      */
     public function gotoAction($browser, $task = 'mail', $action = null, $login = true)
     {
-        $browser->visit("/?_task={$task}&_action={$action}");
+        $browser->visit("?_task={$task}&_action={$action}");
 
         // check if we have a valid session
         if ($login && $this->getEnv($browser, 'task') == 'login') {

tests/Browser/README.md

@@ -50,6 +50,9 @@ Please, keep the file as simple as possible, i.e. containing only database
 and imap/smtp settings needed for the test user authentication. We would
 want to test default configuration. Especially only Elastic skin is supported.
 
+NOTE: Do not use devel_mode=true (i.e. you should build Elastic styles),
+it makes chrome-driver to behave weird, timing out when using iframes (which we do a lot).
+
 NOTE: See `.ci` directory for sample config and scripts we use for in-browser
 tests on Travis.
 

tests/Browser/Settings/IdentitiesTest.php

@@ -3,9 +3,16 @@
 namespace Tests\Browser\Settings;
 
 use Tests\Browser\Components\App;
+use Tests\Browser\Components\Dialog;
+use Tests\Browser\Components\Popupmenu;
 
 class IdentitiesTest extends \Tests\Browser\TestCase
 {
+    public static function setUpBeforeClass()
+    {
+        \bootstrap::init_db();
+    }
+
     public function testIdentities()
     {
         $this->browse(function ($browser) {
@@ -32,4 +39,225 @@ class IdentitiesTest extends \Tests\Browser\TestCase
             $browser->assertToolbarMenu(['create'], ['delete']);
         });
     }
+
+    /**
+     * Test identity creation
+     */
+    public function testIdentityCreate()
+    {
+        $this->browse(function ($browser) {
+            $browser->go('settings', 'identities');
+
+            if ($browser->isPhone()) {
+                $browser->assertVisible('.floating-action-buttons a.create:not(.disabled)')
+                    ->click('.floating-action-buttons a.create')
+                    ->waitFor('#preferences-frame');
+            }
+            else {
+                $browser->clickToolbarMenuItem('create');
+            }
+
+            $browser->withinFrame('#preferences-frame', function($browser) {
+                $browser->waitFor('form')
+                    ->with('form fieldset:nth-of-type(1)', function ($browser) {
+                        $browser->assertSeeIn('legend', 'Settings')
+                            ->assertVisible('input[name=_name]')
+                            ->assertValue('input[name=_name]', '')
+                            ->assertSeeIn('label[for=rcmfd_name]', 'Display Name')
+                            ->assertVisible('input[name=_email]')
+                            ->assertValue('input[name=_email]', '')
+                            ->assertSeeIn('label[for=rcmfd_email]', 'Email')
+                            ->assertVisible('input[name=_organization]')
+                            ->assertValue('input[name=_organization]', '')
+                            ->assertSeeIn('label[for=rcmfd_organization]', 'Organization')
+                            ->assertVisible('input[name=_reply-to]')
+                            ->assertValue('input[name=_reply-to]', '')
+                            ->assertSeeIn('label[for=rcmfd_reply-to]', 'Reply-To')
+                            ->assertVisible('input[name=_bcc]')
+                            ->assertValue('input[name=_bcc]', '')
+                            ->assertSeeIn('label[for=rcmfd_bcc]', 'Bcc')
+                            ->assertCheckboxState('input[name=_standard]', false)
+                            ->assertSeeIn('label[for=rcmfd_standard]', 'Set default');
+                    })
+                    ->with('form fieldset:nth-of-type(2)', function ($browser) {
+                        $browser->assertSeeIn('legend', 'Signature')
+                            ->assertVisible('textarea[name=_signature]')
+                            ->assertValue('textarea[name=_signature]', '');
+                    })
+                    ->type('_name', 'My Test')
+                    ->type('_email', 'mynew@identity.com')
+                    ->type('_organization', 'My Organization')
+                    ->type('_reply-to', 'replyto@domain.tld')
+                    ->type('_bcc', 'bcc@domain.tld')
+                    ->setCheckboxState('input[name=_standard]', true)
+                    ->type('_signature', 'My signature');
+
+                if (!$browser->isPhone()) {
+                    $browser->click('.formbuttons button.submit');
+                }
+            });
+
+            if ($browser->isPhone()) {
+                $browser->assertVisible('#layout-content .header a.back-list-button')
+                    ->whenAvailable('#layout-content .footer .buttons', function ($browser) {
+                        $browser->click('a.button.submit');
+                    });
+            }
+
+            $browser->waitForMessage('confirmation', 'Successfully saved.')
+                ->closeMessage('confirmation')
+                ->waitFor('#preferences-frame');
+
+            $browser->withinFrame('#preferences-frame', function($browser) {
+                $browser->whenAvailable('form', function ($browser) {
+                    $browser->assertValue('input[name=_name]', 'My Test')
+                        ->assertValue('input[name=_email]', 'mynew@identity.com')
+                        ->assertValue('input[name=_organization]', 'My Organization')
+                        ->assertValue('input[name=_reply-to]', 'replyto@domain.tld')
+                        ->assertValue('input[name=_bcc]', 'bcc@domain.tld')
+                        ->assertValue('textarea[name=_signature]', 'My signature')
+                        ->assertCheckboxState('input[name=_standard]', true);
+                });
+            });
+
+            // Toolbar menu (Delete button is active now)
+            $browser->assertToolbarMenu(['create', 'delete']);
+
+            if ($browser->isPhone()) {
+                $browser->click('#layout-content .header a.back-list-button')
+                    ->waitFor('#identities-table');
+            }
+
+            // Identities list
+            $browser->with('#identities-table', function ($browser) {
+                $browser->assertElementsCount('tbody tr', 2)
+                    ->assertSeeIn('tbody tr:nth-child(2)', 'My Test');
+            });
+        });
+    }
+
+    /**
+     * Test identity deletion
+     *
+     * @depends testIdentityCreate
+     */
+    public function testIdentityDelete()
+    {
+        $this->browse(function ($browser) {
+            $browser->click('#identities-table tbody tr:first-child')
+                ->waitFor('#preferences-frame')
+                ->clickToolbarMenuItem('delete');
+
+            $browser->with(new Dialog(), function ($browser) {
+                $browser->assertDialogTitle('Are you sure...')
+                    ->assertDialogContent('Do you really want to delete this identity?')
+                    ->assertButton('mainaction.delete', 'Delete')
+                    ->assertButton('cancel', 'Cancel')
+                    ->clickButton('mainaction.delete');
+            });
+
+            $browser->waitForMessage('confirmation', 'Successfully deleted.')
+                ->closeMessage('confirmation');
+
+            // Preview frame should reset to the watermark page
+            $browser->withinFrame('#preferences-frame', function($browser) {
+                $browser->waitUntilMissing('> div');
+            });
+
+            $browser->waitFor('#layout-list')
+                ->assertElementsCount('#identities-table tbody tr', 1);
+
+            // Toolbar menu (Delete button is inactive again)
+            $browser->assertToolbarMenu(['create'], ['delete']);
+        });
+    }
+
+    /**
+     * Test identity update
+     *
+     * @depends testIdentityDelete
+     */
+    public function testIdentityUpdate()
+    {
+        $this->browse(function ($browser) {
+            $browser->click('#identities-table tbody tr:last-child')
+                ->waitFor('#preferences-frame')
+                ->waitUntilMissing('#messagestack div.loading');
+
+            $browser->withinFrame('#preferences-frame', function($browser) {
+                $browser->whenAvailable('form', function ($browser) {
+                    $browser->type('[name=_name]', 'Default')
+                        ->type('[name=_organization]', 'Default Org');
+                });
+
+                if (!$browser->isPhone()) {
+                    $browser->click('.formbuttons button.submit');
+                }
+            });
+
+            if ($browser->isPhone()) {
+                $browser->whenAvailable('#layout-content .footer', function ($browser) {
+                    $browser->assertVisible('a.button.prev.disabled')
+                        ->assertVisible('a.button.next.disabled')
+                        ->click('a.button.submit');
+                });
+            }
+
+            $browser->waitForMessage('confirmation', 'Successfully saved.')
+                ->closeMessage('confirmation')
+                ->waitFor('#preferences-frame');
+
+            if ($browser->isPhone()) {
+                $browser->click('#layout-content .header a.back-list-button');
+            }
+
+            $browser->whenAvailable('#identities-table', function ($browser) {
+                $browser->assertSeeIn('tbody tr:last-child', 'Default <mynew@identity.com>');
+            });
+        });
+    }
+
+    /**
+     * Test identities in mail composer
+     *
+     * @depends testIdentityUpdate
+     */
+    public function testIdentitiesInComposer()
+    {
+        // Add one more identity
+        (new \rcube_user(1))->insert_identity([
+            'email' => 'another@domain.tld',
+        ]);
+
+        $this->browse(function ($browser) {
+            if ($browser->isPhone()) {
+                $browser->click('a.back-sidebar-button');
+            }
+
+            // Goto Compose and test the identity selector
+            $browser->clickTaskMenuItem('compose')
+                ->waitFor('#compose-content')
+                ->assertElementsCount('select[name=_from] > option', 2)
+                ->assertSeeIn('select[name=_from] > option[selected]', 'mynew@identity.com');
+
+            $this->assertTrue(trim($browser->value('#_bcc'), ', ') === 'bcc@domain.tld');
+            $this->assertTrue(trim($browser->value('#_replyto'), ', ') === 'replyto@domain.tld');
+            $this->assertTrue(strpos($browser->value('#composebody'), 'My signature') !== false);
+
+            // TODO: Recipient input, HTML mode, identity change
+
+            // Test "unsaved changes" dialog
+            $browser->type('#compose-subject', 'subject')
+                ->click('#compose_from a.edit')
+                ->with(new Dialog(), function ($browser) {
+                    $browser->assertDialogTitle('Are you sure...')
+                        ->assertDialogContent('The message has not been sent and has unsaved changes. Do you want to discard your changes?')
+                        ->assertButton('mainaction.discard', 'Discard')
+                        ->assertButton('cancel', 'Cancel')
+                        ->clickButton('discard');
+                });
+
+            $browser->waitFor('#identities-table');
+        });
+    }
 }

tests/Browser/Settings/ResponsesTest.php

@@ -157,12 +157,12 @@ class ResponsesTest extends \Tests\Browser\TestCase
     public function testResponsesInComposer()
     {
         // Quickly create a set of responses
-        $responses = array(
+        $responses = [
-            array('name' => 'Test 1', 'text' => 'Response 1', 'format' => 'text', 'key' => substr(md5('Test 1'), 0, 16)),
+            ['name' => 'Test 1', 'text' => 'Response 1', 'format' => 'text', 'key' => substr(md5('Test 1'), 0, 16)],
-            array('name' => 'Test 2', 'text' => 'Response 2', 'format' => 'text', 'key' => substr(md5('Test 2'), 0, 16)),
+            ['name' => 'Test 2', 'text' => 'Response 2', 'format' => 'text', 'key' => substr(md5('Test 2'), 0, 16)],
-        );
+        ];
 
-        (new \rcube_user(1))->save_prefs(array('compose_responses' => $responses));
+        (new \rcube_user(1))->save_prefs(['compose_responses' => $responses]);
 
         $this->browse(function ($browser) {
             if ($browser->isPhone()) {

tests/Browser/phpunit.xml

@@ -10,7 +10,6 @@
         </testsuite>
         <testsuite name="Settings">
             <directory suffix="Test.php">Settings</directory>
-            <directory suffix="Test.php">Settings/Preferences</directory>
         </testsuite>
         <testsuite name="Mail">
             <directory suffix="Test.php">Mail</directory>