From 47d9ed6d0c6bd8cb3ba551555ba8995a244cfcd0 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak Date: Sat, 28 Dec 2019 09:37:45 +0100 Subject: [PATCH] Add support for PHPUnit 6 and 7 (#6870) Fixes composer dependencies: Package phpunit/phpunit-mock-objects is abandoned We cannot support v8 yet because of errors like: Declaration of MailFunc::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void It would require dropping PHP < 7.1 support. --- CHANGELOG | 1 + composer.json-dist | 2 +- plugins/acl/tests/Acl.php | 2 +- .../tests/AdditionalMessageHeaders.php | 2 +- plugins/archive/tests/Archive.php | 2 +- plugins/attachment_reminder/tests/AttachmentReminder.php | 2 +- plugins/autologon/tests/Autologon.php | 2 +- plugins/database_attachments/tests/DatabaseAttachments.php | 2 +- plugins/debug_logger/tests/DebugLogger.php | 2 +- plugins/emoticons/tests/Emoticons.php | 2 +- plugins/emoticons/tests/EmoticonsEngine.php | 2 +- plugins/enigma/tests/Enigma.php | 2 +- plugins/example_addressbook/tests/ExampleAddressbook.php | 2 +- plugins/filesystem_attachments/tests/FilesystemAttachments.php | 2 +- plugins/help/tests/Help.php | 2 +- plugins/hide_blockquote/tests/HideBlockquote.php | 2 +- plugins/http_authentication/tests/HttpAuthentication.php | 2 +- plugins/identicon/tests/Identicon.php | 2 +- plugins/identity_select/tests/IdentitySelect.php | 2 +- plugins/jqueryui/tests/Jqueryui.php | 2 +- plugins/krb_authentication/tests/KrbAuthentication.php | 2 +- plugins/managesieve/tests/Managesieve.php | 2 +- plugins/managesieve/tests/Parser.php | 2 +- plugins/managesieve/tests/Tokenizer.php | 2 +- plugins/managesieve/tests/Vacation.php | 2 +- plugins/markasjunk/tests/Markasjunk.php | 2 +- plugins/new_user_dialog/tests/NewUserDialog.php | 2 +- plugins/new_user_identity/tests/NewUserIdentity.php | 2 +- plugins/newmail_notifier/tests/NewmailNotifier.php | 2 +- plugins/password/tests/Password.php | 2 +- plugins/redundant_attachments/tests/RedundantAttachments.php | 2 +- plugins/show_additional_headers/tests/ShowAdditionalHeaders.php | 2 +- plugins/squirrelmail_usercopy/tests/SquirrelmailUsercopy.php | 2 +- plugins/subscriptions_option/tests/SubscriptionsOption.php | 2 +- plugins/userinfo/tests/Userinfo.php | 2 +- plugins/vcard_attachments/tests/VcardAttachments.php | 2 +- plugins/virtuser_file/tests/VirtuserFile.php | 2 +- plugins/virtuser_query/tests/VirtuserQuery.php | 2 +- plugins/zipdownload/tests/Zipdownload.php | 2 +- tests/Framework/BaseReplacer.php | 2 +- tests/Framework/Bootstrap.php | 2 +- tests/Framework/Browser.php | 2 +- tests/Framework/Cache.php | 2 +- tests/Framework/Charset.php | 2 +- tests/Framework/Config.php | 2 +- tests/Framework/Contacts.php | 2 +- tests/Framework/ContentFilter.php | 2 +- tests/Framework/Csv2vcard.php | 2 +- tests/Framework/DB.php | 2 +- tests/Framework/DBMssql.php | 2 +- tests/Framework/DBMysql.php | 2 +- tests/Framework/DBOracle.php | 2 +- tests/Framework/DBPgsql.php | 2 +- tests/Framework/DBSqlite.php | 2 +- tests/Framework/DBSqlsrv.php | 2 +- tests/Framework/Enriched.php | 2 +- tests/Framework/Html.php | 2 +- tests/Framework/Html2text.php | 2 +- tests/Framework/Image.php | 2 +- tests/Framework/Imap.php | 2 +- tests/Framework/ImapCache.php | 2 +- tests/Framework/ImapGeneric.php | 2 +- tests/Framework/ImapSearch.php | 2 +- tests/Framework/Ldap.php | 2 +- tests/Framework/LdapGeneric.php | 2 +- tests/Framework/MessageHeader.php | 2 +- tests/Framework/MessagePart.php | 2 +- tests/Framework/Mime.php | 2 +- tests/Framework/Rcube.php | 2 +- tests/Framework/ResultIndex.php | 2 +- tests/Framework/ResultMultifolder.php | 2 +- tests/Framework/ResultSet.php | 2 +- tests/Framework/ResultThread.php | 2 +- tests/Framework/Smtp.php | 2 +- tests/Framework/Spellchecker.php | 2 +- tests/Framework/SpellcheckerAtd.php | 2 +- tests/Framework/SpellcheckerEnchant.php | 2 +- tests/Framework/SpellcheckerGoogie.php | 2 +- tests/Framework/SpellcheckerPspell.php | 2 +- tests/Framework/StringReplacer.php | 2 +- tests/Framework/Text2Html.php | 2 +- tests/Framework/User.php | 2 +- tests/Framework/Utils.php | 2 +- tests/Framework/VCard.php | 2 +- tests/Framework/Washtml.php | 2 +- tests/MailFunc.php | 2 +- tests/Rcmail/OutputHtml.php | 2 +- tests/Rcmail/Rcmail.php | 2 +- 88 files changed, 88 insertions(+), 87 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 7450c0785..d9f161f87 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,7 @@ CHANGELOG Roundcube Webmail =========================== +- Add support for PHPUnit 6 and 7 (#6870) - Plugin API: Make actionbefore, before, actionafter and after events working with plugin actions (#7106) - Managesieve: Replace "Filter disabled" with "Filter enabled" (#7028) - Managesieve: Fix so modifier type select wasn't hidden after hiding modifier select on header change diff --git a/composer.json-dist b/composer.json-dist index 7655b1e8f..7243f51ec 100644 --- a/composer.json-dist +++ b/composer.json-dist @@ -22,7 +22,7 @@ "endroid/qr-code": "~1.6.5" }, "require-dev": { - "phpunit/phpunit": "^4.8.36 || ^5.7.21" + "phpunit/phpunit": "^4.8.36 || ^5.7.21 || ^6 || ^7" }, "suggest": { "kolab/net_ldap3": "~1.1.1 required for connecting to LDAP", diff --git a/plugins/acl/tests/Acl.php b/plugins/acl/tests/Acl.php index 548fff26a..ec943e9dd 100644 --- a/plugins/acl/tests/Acl.php +++ b/plugins/acl/tests/Acl.php @@ -1,6 +1,6 @@