From dec4b38f3513d87caf9a98c974bd26f481a63f02 Mon Sep 17 00:00:00 2001 From: David Goodwin Date: Wed, 1 Apr 2020 21:29:40 +0100 Subject: [PATCH] improve langauge checks (remove unnecessary is_string check) --- functions.inc.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/functions.inc.php b/functions.inc.php index 48df3c64..6e74f9c3 100644 --- a/functions.inc.php +++ b/functions.inc.php @@ -180,13 +180,9 @@ function check_language($use_post = true) { $lang = Config::read_string('default_language'); // If not, did the browser give us any hint(s)? - if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) { + if (!empty($_SERVER['HTTP_ACCEPT_LANGUAGE'])) { $lang_array = preg_split('/(\s*,\s*)/', $_SERVER['HTTP_ACCEPT_LANGUAGE']); - foreach ($lang_array as $value) { - if (!is_string($value)) { - continue; - } $lang_next = strtolower(trim($value)); $lang_next = preg_replace('/;.*$/', '', $lang_next); # remove things like ";q=0.8" if (array_key_exists($lang_next, $supported_languages)) {