From 53c28990adfb08c7b7167d8bff412684e5d2e07f Mon Sep 17 00:00:00 2001 From: Christian Boltz Date: Sat, 16 Nov 2013 19:10:15 +0000 Subject: [PATCH] PFAHandler: - read_from_db(): convert $limit and $offset with (int) to make sure they contain a sane value git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@1584 a1433add-5e2c-0410-b055-b7f2511e0802 --- model/PFAHandler.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/model/PFAHandler.php b/model/PFAHandler.php index c0515893..3500eaac 100644 --- a/model/PFAHandler.php +++ b/model/PFAHandler.php @@ -460,9 +460,9 @@ abstract class PFAHandler { $query = "SELECT $cols FROM $table $extrafrom $where ORDER BY " . $this->id_field; + $limit = (int) $limit; # make sure $limit and $offset are really integers + $offset = (int) $offset; if ($limit > -1 && $offset > -1) { - # TODO: make sure $limit and $offset are really integers - cast via (int) ? - # TODO: make sure $limit is > 0 (0 doesn't break anything, but guarantees an empty resultset, so it's pointless) $query .= " LIMIT $limit OFFSET $offset "; }