From 48a37090415f3a3664a545bc9a5c079e0ca9063c Mon Sep 17 00:00:00 2001 From: Christian Boltz Date: Sun, 25 Mar 2018 21:34:26 +0200 Subject: [PATCH] postfixadmin-cli: get rid of empty/unused initialize() --- scripts/postfixadmin-cli.php | 4 +--- scripts/shells/shell.php | 9 --------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/scripts/postfixadmin-cli.php b/scripts/postfixadmin-cli.php index 1241758e..be2f0c0b 100644 --- a/scripts/postfixadmin-cli.php +++ b/scripts/postfixadmin-cli.php @@ -210,8 +210,6 @@ class PostfixAdmin { # TODO: add a way to Cli* to signal if the selected handler is supported (for example, not all *Handler support changing the password) if (strtolower(get_parent_class($shell)) == 'shell') { - $shell->initialize(); - $handler = new $shell->handler_to_use; if (in_array($task, $handler->taskNames)) { $this->shiftArgs(); @@ -243,7 +241,7 @@ class PostfixAdmin { } $protectedCommands = array( - 'initialize', 'in', 'out', 'err', 'hr', 'log', + 'in', 'out', 'err', 'hr', 'log', '__construct', 'dispatch', 'stdout', 'stderr' ); diff --git a/scripts/shells/shell.php b/scripts/shells/shell.php index f4d19c37..a3f16bc5 100644 --- a/scripts/shells/shell.php +++ b/scripts/shells/shell.php @@ -110,15 +110,6 @@ class Shell { $this->Dispatch =& $dispatch; } - /** - * Initializes the Shell - * acts as constructor for subclasses - * allows configuration of tasks prior to shell execution - * - * @access public - */ - public function initialize() { - } /** * Starts up the the Shell * allows for checking and configuring prior to command or main execution