Added some TODOs and MARKs

Some lines in the shells are duplicate



git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@917 a1433add-5e2c-0410-b055-b7f2511e0802

scripts/shells/alias.php

@@ -12,28 +12,8 @@ class PostfixAdminAlias extends Shell {
         var $tasks = array('Add', 'Update', 'Delete', 'View');
 
 
-/**
- * Starts up the the Shell
- * allows for checking and configuring prior to command or main execution
- * can be overriden in subclasses
- *
- * @access public
- */
-        function startup() {
-                $this->_welcome();
-                $CONF = Config::read('all');
-        }
-/**
- * Displays a header for the shell
- *
- * @access protected
- */
-        function _welcome() {
-                $this->out("\nWelcome to Postfixadmin-CLI v" . $this->Dispatch->version);
-                $this->out("---------------------------------------------------------------");
-                $this->out('Path: '. PATH);
-                $this->hr();
-        }
+
+
 
 /**
  * Show help for this shell.

scripts/shells/domain.php

@@ -12,28 +12,8 @@ class PostfixAdminDomain extends Shell {
         var $tasks = array('Add', 'Update', 'Delete', 'View');
 
 
-/**
- * Starts up the the Shell
- * allows for checking and configuring prior to command or main execution
- * can be overriden in subclasses
- *
- * @access public
- */
-        function startup() {
-                $this->_welcome();
-                $CONF = Config::read('all');
-        }
-/**
- * Displays a header for the shell
- *
- * @access protected
- */
-        function _welcome() {
-                $this->out("\nWelcome to Postfixadmin-CLI v" . $this->Dispatch->version);
-                $this->out("---------------------------------------------------------------");
-                $this->out('Path: '. PATH);
-                $this->hr();
-        }
+
+
 
 /**
  * Show help for this shell.

scripts/shells/shell.php

@@ -167,6 +167,7 @@ class Shell {
  */
         function startup() {
                 $this->_welcome();
+                $CONF = Config::read('all');
         }
 /**
  * Displays a header for the shell

scripts/shells/user.php

@@ -12,28 +12,7 @@ class PostfixAdminUser extends Shell {
         var $tasks = array('Add', 'Update', 'Delete', 'Password', 'View');
 
 
-/**
- * Starts up the the Shell
- * allows for checking and configuring prior to command or main execution
- * can be overriden in subclasses
- *
- * @access public
- */
-        function startup() {
-                $this->_welcome();
-                $CONF = Config::read('all');
-        }
-/**
- * Displays a header for the shell
- *
- * @access protected
- */
-        function _welcome() {
-                $this->out("\nWelcome to Postfixadmin-CLI v" . $this->Dispatch->version);
-                $this->out("---------------------------------------------------------------");
-                $this->out('Path: '. PATH);
-                $this->hr();
-        }
+
 
 /**
  * Show help for this shell.
@@ -157,7 +136,7 @@ class AddTask extends Shell {
                 $handler =  new UserHandler($address);
                 $return = $handler->add($pw,  $name, $quota, true, true  );
 
-                if( ! $return) {
+                if( $return == false ) {
                         $this->err(join("\n", $handler->errormsg));
                 } else {
                         $this->out("");