From 3bc9c9360d01dbd8cd5c0bb5bbf3a9b63f2bfb5f Mon Sep 17 00:00:00 2001
From: Felix Stupp <felix.stupp@outlook.com>
Date: Sat, 18 Jul 2020 14:55:21 +0200
Subject: [PATCH] common: backup_autoremove: Improved script quality

---
 roles/common/templates/backup_autoremove.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/roles/common/templates/backup_autoremove.sh b/roles/common/templates/backup_autoremove.sh
index 86908cf..845013a 100644
--- a/roles/common/templates/backup_autoremove.sh
+++ b/roles/common/templates/backup_autoremove.sh
@@ -2,7 +2,7 @@
 
 set -euxo pipefail;
 
-backupsToKeep={{ backups_to_keep }};
+backupsToKeep={{ backups_to_keep | quote }};
 
 function onlyDatedFiles() {
   grep --perl-regexp '/\d+(-\d+)*(\.[^/]+)*$';
@@ -16,6 +16,6 @@ find {{ backups_directory | quote }} -type f |
   onlyDatedFiles |
   getDirName |
   sort --unique |
-  while read dir; do
+  while read -r dir; do
   find "$dir" -type f | onlyDatedFiles | sort --reverse | tail --lines=+$((backupsToKeep + 1)) | xargs rm --force;
 done