343 Commits (d83b0ad8095a5d63b22edf1d29ab9390e79fd921)

Author	SHA1	Message	Date
pukkandan	d49f8db39f	[utils] Validate `DateRange` input ... Closes #2641	3 years ago
Justin Keogh	a3125791c7	[utils] Use `locked_file` for `sanitize_open` (#1066) ... Authored by: jakeogh	3 years ago
pukkandan	455a15e2dc	[cleanup,docs] Minor fixes ... Closes #2541, #2484	3 years ago
pukkandan	4918522735	[utils] Strip double spaces in `clean_html` ... Closes #2497 Authored by: dirkf	3 years ago
pukkandan	65662dffb1	Make nested --config-locations relative to parent file ... * and allow environment variables in it so that you can use `$PWD`/`%cd%` to specify paths relative to current directory	3 years ago
pukkandan	d16df59db5	Fix `--compat-options list-formats` ... Closes #2481	3 years ago
pukkandan	d37707bda4	Fix/improve `InAdvancePagedList`	3 years ago
pukkandan	e0ddbd02bd	[cleanup] Use format_field where applicable	3 years ago
xtkoba	f81c62a6a4	Add option --legacy-server-connect (#778) ... to allow HTTPS connection to servers that do not support RFC 5746 secure renegotiation Authored by: xtkoba	3 years ago
pukkandan	b1156c1e59	Fix d14cbdd92d	3 years ago
coletdjnz	396a76f7bf	[youtube] Enforce UTC (#2402) ... and [utils] use `utcnow` in `datetime_from_str` Related: #2223 Authored by: coletdjnz	3 years ago
pukkandan	d14cbdd92d	[utils] Add `Sec-Fetch-Mode` to `std_headers` ... Closes #2187	3 years ago
pukkandan	19b4c74d40	Revert d6579d532b ... Closes #2396, Reopens #2187	3 years ago
pukkandan	8bd1c00bf3	[utils] Handle `ss:xxx` in `parse_duration` ... Closes #2388	3 years ago
pukkandan	3b603dbdf1	Add option `--concat-playlist` ... Closes #1855, related: #382	3 years ago
pukkandan	d6579d532b	[utils] Partially revert d76d15a669 ... Closes #2187	3 years ago
Zenon Mousmoulas	0254f16274	[utils] Improve `get_elements_text_and_html_by_attribute` regex (#2280) ... Authored by: zmousm, pukkandan	3 years ago
Zenon Mousmoulas	6f32a0b5b7	[utils] Improve parsing for nested HTML elements (#2129) ... and add functions to return the HTML of elements Authored by: zmousm	3 years ago
pukkandan	9e907ebddf	[cleanup] Misc cleanup	3 years ago
pukkandan	06e57990f7	Allow multiple and nested configuration files	3 years ago
pukkandan	ebed8b3732	Add more post-processing stages ... playlist = After entire playlist after_video = After downloading all formats of a video	3 years ago
pukkandan	1e43a6f733	Allow `--exec` to be run at any post-processing stage ... Deprecates `--exec-before-download`	3 years ago
pukkandan	1797b073ed	[utils] Use key `None` in `traverse_obj` to return as-is	3 years ago
Felix S	4afa3ec4b6	[extractor] Detect more subtitle codecs in MPD manifests (#2174) ... Authored by: fstirlitz	3 years ago
pukkandan	abbeeebc4c	[outtmpl] Alternate form for `D` and fix suffix's case ... Fixes: https://github.com/yt-dlp/yt-dlp/issues/2085#issuecomment-1002247689, https://github.com/yt-dlp/yt-dlp/pull/2132/files#r775729811	3 years ago
pukkandan	45d86abeb4	Allow unicode characters in `info.json` ... Closes #2139	3 years ago
Pierre Mdawar	f02d24d8d2	[utils] Fix `format_bytes` output for Bytes (#2132) ... Authored by: pukkandan, mdawar	3 years ago
pukkandan	352d5da812	[utils] Improve `parse_count`	3 years ago
Benedikt Wildenhain	4b4b7f746c	[OpenCast] Add extractors (#1905) ... Original PR: https://github.com/ytdl-org/youtube-dl/pull/26934 Authored by: bwildenhain, C0D3D3V	3 years ago
Luc Ritchie	4f3fa23e5a	[utils] Fix parsing `YYYYMMDD` dates in Nov/Dec (#2094) ... The date format `%Y%m%d%H%M` will successfully match against one-digit month, day, hour, and minute strings, even though %m et al. are documented as being zero-padded. So dates without time in Nov/Dec may be wrongly parsed as dates in January with time. This commit adds a format string of `%Y%m%d` to our supported date format strings directly below (higher priority) its problematic relatives. Closes #2076 Authored by: wlritchi	3 years ago
pukkandan	b69fd25c25	[cleanup] Misc cleanup ... Closes #1942 #1976 #2020 #2058 #1984	3 years ago
pukkandan	e0fd95737d	[outtmpl] Add alternate forms `F`, `D` ... and improve `id` detection F = sanitize as filename (# = restricted) D = add Decimal suffixes Closes #2085, 2081	3 years ago
The Hatsune Daishi	adbc4ec4bb	[dash,youtube] Download live from start to end (#888) ... * Add option `--live-from-start` to enable downloading live videos from start * Add key `is_from_start` in formats to identify formats (of live videos) that downloads from start * [dash] Create protocol `http_dash_segments_generator` that allows a function to be passed instead of fragments * [fragment] Allow multiple live dash formats to download simultaneously * [youtube] Implement fragment re-fetching for the live dash formats * [youtube] Re-extract dash manifest every 5 hours (manifest expires in 6hrs) * [postprocessor/ffmpeg] Add `FFmpegFixupDuplicateMoovPP` to fixup duplicated moov atoms Known issue: Ctrl+C doesn't work on Windows when downloading multiple formats Closes #1521 Authored by: nao20010128nao, pukkandan	3 years ago
Felix S	d76d15a669	[utils] Update `std_headers` (#2023) ... * Update our chrome versions used for `User-Agent`s * Drop the `Accept-Charset` header that no browser emits any more Authored by: kikuyan, fstirlitz	3 years ago
The Hatsune Daishi	2814f12ba4	[skeb] Add extractor (#1916) ... Fixes: https://github.com/ytdl-org/youtube-dl/issues/30287 Authored by: nao20010128nao	3 years ago
pukkandan	e3c7d49571	[compat] Suppress errors in enabling VT mode ... Closes #1932	3 years ago
pukkandan	38d79fd16c	Use `parse_duration` for `--wait-for-video` ... and some minor fix	3 years ago
pukkandan	43b2290658	Fix `--throttled-rate`	3 years ago
pukkandan	ee8dd27a73	[cleanup] Add deprecation warnings	3 years ago
pukkandan	f304da8a29	[cleanup] Misc cleanup ... Closes #1805, closes #1800	3 years ago
pukkandan	f2ebc5c7be	Option `--wait-for-video` to wait for scheduled streams	3 years ago
pukkandan	282f570918	[utils] Fix error when copying `LazyList`	3 years ago
pukkandan	c07a39ae8e	[utils] Fix `PagedList` ... Bug in d8cf8d97a8	3 years ago
pukkandan	c5e3f84972	[utils] Allow alignment in `render_table` ... and add tests	3 years ago
pukkandan	d8cf8d97a8	[utils] Fix `PagedList`	3 years ago
pukkandan	c586f9e8de	[cleanup] minor fixes	3 years ago
pukkandan	aa9369a2d8	[cleanup] Minor improvements to error and debug messages	3 years ago
pukkandan	582fad70f5	[outtmpl] Do not traverse `None` ... Closes #1585	3 years ago
pukkandan	34921b4345	[utils] Add `join_nonempty`	3 years ago
Francesco Frassinelli	73673ccff3	[RaiplayRadio] Add extractors (#780) ... Original PR: https://github.com/ytdl-org/youtube-dl/pull/21837 Authored by: frafra	3 years ago
pukkandan	9af98e17bd	[ffmpeg] Framework for feature detection ... Related: #1502, #1237, https://github.com/ytdl-org/youtube-dl/pull/29581	3 years ago
pukkandan	31c49255bf	[ExtractAudio] Rescale --audio-quality correctly ... Authored by: CrypticSignal, pukkandan	3 years ago
pukkandan	9bd979ca40	[utils] Parse `vp09` as vp9	3 years ago
pukkandan	16b0d7e621	[utils] Add `jwt_decode_hs256` ... Code from #1340 Authored by: Ashish0804	3 years ago
pukkandan	0db3bae879	[extractor] Fix some errors being converted to `ExtractorError`	3 years ago
pukkandan	48f796874d	[utils] Create `DownloadCancelled` exception ... as super-class of ExistingVideoReached, RejectedVideoReached, MaxDownloadsReached Third parties can also sub-class this to cancel the download queue from a hook	3 years ago
pukkandan	08438d2ca5	[outtmpl] Add type `link` for internet shortcut files ... and refactor related code Closes #1405	3 years ago
pukkandan	7de837a5e3	[utils] Sanitize URL when determining protocol ... Closes #1406	3 years ago
pukkandan	9f1a1c36e6	Separate `--check-all-formats` from `--check-formats` ... Previously, `--check-formats` tested only the selected video formats, but ALL thumbnails	3 years ago
pukkandan	ec11a9f4a2	[minicurses] Add more colors	3 years ago
Damiano Amatruda	17ec8bcfa9	[microsoftstream] Add extractor (#1201) ... Based on: https://github.com/ytdl-org/youtube-dl/pull/24649 Fixes: https://github.com/ytdl-org/youtube-dl/issues/24440 Authored by: damianoamatruda, nixklai	3 years ago
pukkandan	d3c93ec2b7	Don't create console for subprocesses on Windows (#1261) ... Closes #1251	3 years ago
pukkandan	aa7785f860	[utils] Standardize timestamp formatting code ... Closes #1285	3 years ago
pukkandan	176f1866cb	Add HDR information to formats	3 years ago
Ákos Sülyi	019a94f7d6	[utils] Use `importlib` to load plugins (#1277) ... Authored by: sulyi	3 years ago
pukkandan	18f96d129b	[utils] Allow duration strings in filter ... Closes #1309	3 years ago
pukkandan	6993f78d1b	[extractor,utils] Detect more codecs/mimetypes ... Fixes: https://github.com/ytdl-org/youtube-dl/issues/29943	3 years ago
pukkandan	d1d5c08f29	[minicurses] Fix when printing to file ... Closes #1215	3 years ago
pukkandan	2614f64600	[utils] Let traverse_obj accept functions as keys	3 years ago
pukkandan	819e05319b	Improved progress reporting (See desc) (#1125) ... * Separate `--console-title` and `--no-progress` * Add option `--progress` to show progress-bar even in quiet mode * Fix and refactor `minicurses` * Use `minicurses` for all progress reporting * Standardize use of terminal sequences and enable color support for windows 10 * Add option `--progress-template` to customize progress-bar and console-title * Add postprocessor hooks and progress reporting Closes: #906, #901, #1085, #1170	3 years ago
pukkandan	4e3d1898a8	Workaround ssl errors in mingw python ... Closes #1151	3 years ago
pukkandan	5d535b4a55	[build] Allow building with py2exe (and misc fixes) ... py2exe config is copied from youtube-dl Closes #1160	3 years ago
Felix S	9359f3d4f0	[extractor] Extract storyboards from SMIL manifests (#1128) ... Authored by: fstirlitz	3 years ago
pukkandan	3ae5e79774	[postprocessor] Add plugin support ... Adds option `--use-postprocessor` to enable them	3 years ago
pukkandan	7756277882	Workaround for bug in `ssl.SSLContext.load_default_certs` (#1118) ... * Remove old compat code * Load certificates only when not using nocheckcertificate * Load each certificate individually Closes #1060 Related bugs.python.org/issue35665, bugs.python.org/issue4531	3 years ago
pukkandan	91dd88b90f	[outtmpl] Alternate form of format type `l` for `\n` delimited list	3 years ago
pukkandan	524e2e4fda	[outtmpl] Format type `U` for unicode normalization	3 years ago
NeroBurner	49fa4d9af7	[atv.at] Use jwt for API (#1012) ... The jwt token is implemented according to RFC7519 Closes #988 Authored by: NeroBurner	3 years ago
The Hatsune Daishi	bd50a52b0d	Basic framework for simultaneous download of multiple formats (#1036) ... Authored by: nao20010128nao	3 years ago
Yuan Chao	a63d9bd0b0	[CGTN] Add extractor (#981) ... Authored by: chao813	3 years ago
pukkandan	f137e4c27c	[utils] Improve `extract_timezone` ... Code taken from: https://github.com/ytdl-org/youtube-dl/pull/29845 Fixes: https://github.com/ytdl-org/youtube-dl/issues/29948 Authored by: dirkf	3 years ago
coletdjnz	bccdbd22d5	[Mediaklikk] Add Extractor (#867) ... Original PR: https://github.com/ytdl-org/youtube-dl/pull/17453, https://github.com/ytdl-org/youtube-dl/pull/25098 Fixes: https://github.com/ytdl-org/youtube-dl/issues/21431 Authored-by: tmarki, mrx23dot, coletdjnz	3 years ago
pukkandan	526d74ec5a	[cleanup] Misc	3 years ago
ChillingPepper	421ddcb8b4	[SovietsCloset] Add extractor (#884) ... Authored by: ChillingPepper	3 years ago
pukkandan	8e5fecc88c	Handle more playlist errors with `-i`	3 years ago
The Hatsune Daishi	1931a55ee8	[radiko] Add extractors (#731) ... https://github.com/ytdl-org/youtube-dl/issues/29840 Authored by: nao20010128nao	3 years ago
pukkandan	6251555f1c	[downloader/ffmpeg] Support for DASH manifests (experimental) ... Closes #159	3 years ago
pukkandan	330690a214	[downloader/ffmpeg] Allow passing custom arguments before -i ... Closes #686	3 years ago
pukkandan	1151c4079a	[extractor] Show video id in error messages if possible	3 years ago
pukkandan	4dfbf8696b	[utils] Add `parse_qs`	3 years ago
pukkandan	8f18aca871	Let `--match-filter` reject entries early ... Makes redundant: `--match-title`, `--reject-title`, `--min-views`, `--max-views`	3 years ago
pukkandan	7be9ccff0b	[utils] Fix `InAdvancePagedList.__getitem__` ... Since it didn't have any cache, the page was re-fetched for each video. * Also generalized the cache code	3 years ago
pukkandan	b868936cd6	[cleanup] Misc	3 years ago
pukkandan	6e84b21559	Fix bugs related to `sanitize_info` ... Related: 8012d892bd (r54555230)	3 years ago
pukkandan	575e17a1b9	[utils] Fix `traverse_obj` depth when is_user_input	3 years ago
pukkandan	a047eeb6d2	Add regex to `--match-filter` ... This does not fully deprecate `--match-title`/`--reject-title` since `--match-filter` is only checked after the extraction is complete, while `--match-title` can often be checked from the flat playlist. Fixes: https://github.com/ytdl-org/youtube-dl/issues/9092, https://github.com/ytdl-org/youtube-dl/issues/23035	3 years ago
Max Teegen	77b87f0519	Add all format filtering operators also to `--match-filter` ... PR: https://github.com/ytdl-org/youtube-dl/pull/27361 Authored by: max-te	3 years ago
pukkandan	dbf5416a20	[cleanup] Refactor some code	3 years ago
pukkandan	e0f2b4b47d	[utils] Fix slicing of reversed `LazyList` ... Closes #589	3 years ago
pukkandan	7d1eb38af1	Add format types `j`, `l`, `q` for outtmpl ... Closes #345	3 years ago
pukkandan	901130bbcf	Expand and escape environment variables correctly in outtmpl ... Fixes: https://www.reddit.com/r/youtubedl/comments/otfmq3/ytdlp_same_parameters_different_results	3 years ago
xtkoba	cb89cfc14b	[test] Add Python 3.10 (#480) ... Authored-by: pukkandan, xtkoba	3 years ago
pukkandan	352d63fdb5	[utils] Improve `traverse_obj`	3 years ago
pukkandan	6586bca9b9	[utils] Fix LazyList for Falsey values	3 years ago
pukkandan	c634ad2a3c	[compat] Remove unnecessary code	3 years ago
pukkandan	8f3343809e	[utils] Improve `traverse_obj` ... * Allow skipping a level: `traverse_obj([{k:v1}, {k:v2}], (None, k))` => `[v1, v2]` * Make keys variadic: `traverse_obj(obj, k1: str, k2: str)` => `traverse_obj(obj, (k1,), (k2,))` * Fetch from multiple keys: `traverse_obj([{k1:[1], k2:[2], k3:[3]}], (0, (k1, k2), 0))` => `[1, 2]` TODO: Add tests	3 years ago
felix	c843e68588	[utils] Improve `js_to_json` comment regex ... Capture the newline character as part of a single-line comment From #497, Authored by: fstirlitz	3 years ago
pukkandan	325ebc1703	Improve `traverse_obj`	3 years ago
pukkandan	6606817a86	[utils] Add `variadic`	3 years ago
pukkandan	981052c9c6	Some minor fixes and refactoring (see desc) ... * [utils] Fix issues with reversal * check_formats should catch `DownloadError`, not `ExtractorError` * Simplify format selectors with `LazyList` and `yield from`	3 years ago
pukkandan	51d9739f80	Add option `--throttled-rate` below which video data is re-extracted ... Currently only for HTTP downloads Closes #430, workaround for https://github.com/ytdl-org/youtube-dl/issues/29326	3 years ago
pukkandan	9fea350f0d	Fix id sanitization in filenames ... Closes #415	4 years ago
felix	cdb19aa4c2	[downloader/mhtml] Add new downloader (#343) ... This downloader is intended to be used for streams that consist of a timed sequence of stand-alone images, such as slideshows or thumbnail streams This can be used for implementing: https://github.com/ytdl-org/youtube-dl/issues/4974#issue-58006762 https://github.com/ytdl-org/youtube-dl/issues/4540#issuecomment-69574231 https://github.com/ytdl-org/youtube-dl/pull/11185#issuecomment-335554239 https://github.com/ytdl-org/youtube-dl/issues/9868 https://github.com/ytdl-org/youtube-dl/pull/14951 Authored by: fstirlitz	4 years ago
pukkandan	28419ca2c8	[utils] Improve `LazyList` ... * Add `repr` and `str` that mimics `list` * Add `reversed`. Unlike `[::-1]`, reversed does not exhaust the iterable and modifies the `LazyList` in-place * Add tests	4 years ago
pukkandan	639f1cea92	Fix `%d` and empty default in outtmpl ... Closes #388	4 years ago
pukkandan	324ad82006	[utils] Generalize `traverse_dict` to `traverse_obj`	4 years ago
pukkandan	752cda3880	Fix and refactor `prepare_outtmpl` ... The following tests would have failed previously: %(id)d %(id)r %(ext)s-%(ext|def)d %(width|)d %(id)r %(height)r %(formats.0)r %s	4 years ago
felix	cc52de4356	[cleanup] Point all shebang to `python3` (#372) ... Authored by: fstirlitz	4 years ago
pukkandan	bc6b9bcd65	[utils] Escape URLs in `sanitized_Request`, not `sanitize_url` ... d2558234cf added escaping of URLs while sanitizing. However, `sanitize_url` may not always receive an actual URL. Eg: When using `yt-dlp "search query" --default-search ytsearch`, `search query` gets escaped to `search%20query` before being prefixed with `ytsearch:` which is not the intended behavior. So the escaping is moved to `sanitized_Request` instead.	4 years ago
pukkandan	55575225b4	[utils] Add `__getitem__` for `PagedList`	4 years ago
pukkandan	483336e79e	[utils] Add `LazyList`	4 years ago
Hubert Hirtz	5435dcf96e	Handle Basic Auth `user:pass` in URLs ... Fixes https://github.com/ytdl-org/youtube-dl/issues/20258, https://github.com/ytdl-org/youtube-dl/issues/26211 Authored by: hhirtz, pukkandan	4 years ago
pukkandan	81a23040eb	[cleanup] Refactor ffmpeg convertors	4 years ago
king-millez	5014558ab9	[parlview] Add extractor (#322) ... Authored by: king-millez	4 years ago
pukkandan	5112f26a60	Add `pl_thumbnail` outtmpl key for playlist thumbnails ... This should have been implemented in 681de68e9d, but I forgot	4 years ago
pukkandan	2f567473c6	[Plugins] Prioritize plugins over standard extractors ... and prevent plugins from overwriting the standard extractor classes Closes #304	4 years ago
pukkandan	e625be0d10	Improve output template internal formatting ... * Allow slicing lists/strings using `field.start🔚step` * A field can also be used as offset like `field1+num+field2` * A default value can be given using `field|default` * Capture all format strings and set it to `None` if invalid. This prevents invalid fields from causing errors	4 years ago
pukkandan	3158150cb7	[utils] Add `network_exceptions`	4 years ago
pukkandan	d2558234cf	[utils] Escape URL while sanitizing ... Closes #263 While this fixes the issue in question, it does not try to address the root-cause of the problem Refer: 915f911e36, f5fa042c82	4 years ago
pukkandan	f5fa042c82	Revert "[utils] Encode URLs in `YoutubeDLCookieProcessor`" ... This reverts commit 915f911e36. When the request is copied, `unredirected_hdrs` are not copied, which causes issues elsewhere Reopens #263	4 years ago
Felix S	5873d4ccdd	[utils] Improve bug_report_message ... Add an optional argument specifying the text that should go before the message.	4 years ago
pukkandan	915f911e36	[utils] Encode URLs in `YoutubeDLCookieProcessor` ... Closes #263	4 years ago
pukkandan	a439a3a45c	Improve output template (see desc) ... * Objects can be traversed like `%(field.key1.key2)s` * A number can be added to the field as `%(field+n)s` * Deprecates `--autonumber-start`	4 years ago
pukkandan	201c145953	Update to ytdl-commit-9f6c03 ... [cbsnews] Fix extraction for python <3.6 9f6c03a006	4 years ago
colethedj	9e62f283ff	[utils] Add `datetime_from_str` to parse relative time (#221) ... and `datetime_add_months` to accurately add/subtract months Authored by: colethedj	4 years ago
pukkandan	143db31d48	Parse metadata from multiple fields ... Closes #196	4 years ago
pukkandan	498f560638	Ability to load playlist infojson ... * If `--no-clean-infojson` is given, the video ids are saved/loaded from in the infojson along with their playlist index * If a video entry that was not saved is requested, we fallback to using `webpage_url` to re-extract the entries Related: https://github.com/yt-dlp/yt-dlp/issues/190#issuecomment-804921024	4 years ago
2ShedsJackson	5c5fae6d2f	[amcnetworks] Fix extractor (#179) ... * Prefer use of manifest based on `releasePid` since the one based on `videoPid` may have Fairplay * Additional thumbnail images were added * Don't add `season_number` and `series` to `title` * `series` is now set to `None` rather than "_" when empty * fix bug with age limit Authored by: 2ShedsJackson	4 years ago
pukkandan	75d43ca080	Option to keep private keys in the infojson ... Options: --clean-infojson, --no-clean-infojson Related: https://github.com/yt-dlp/yt-dlp/issues/42#issuecomment-800778391	4 years ago
pukkandan	7275535116	Split video by chapters (#158) ... * New options `--split-chapters` and `--no-split-chapters` * The output/path of the split files can be given using the key `chapter` * Additional keys `section_title`, `section_number`, `section_start`, `section_end` are available in the output template * Alias `--split-tracks` for parity with animelover/youtube-dl * `--sponskrub-cut` and `--split-chapter` cannot work together Closes: https://github.com/blackjack4494/yt-dlc/issues/277 https://github.com/ytdl-org/youtube-dl/issues/28438 https://github.com/ytdl-org/youtube-dl/issues/12907 https://github.com/ytdl-org/youtube-dl/issues/6480 https://github.com/ytdl-org/youtube-dl/pull/25005 Rewritten from the implementation by: femaref and Wattux https://github.com/Wattux/youtube-dl/tree/split-at-timestamps https://github.com/ytdl-org/youtube-dl/pull/25005 https://github.com/femaref/youtube-dl/tree/split-track	4 years ago
pukkandan	e92caff5d5	Refactor (See desc) ... * Create `FFmpegPostProcessor.real_run_ffmpeg` that can accept multiple input/output files along with switches for each * Rewrite `cli_configuration_args` and related functions * Create `YoutubeDL._ensure_dir_exists` - this was previously defined in multiple places	4 years ago
shirt-dev	c552ae8838	Fix `get_executable_path` (#117) ... Authored-by: shirtjs <2660574+shirtjs@users.noreply.github.com>	4 years ago
Pccode66	7a5c1cfe93	Completely change project name to yt-dlp (#85) ... * All modules and binary names are changed * All documentation references changed * yt-dlp no longer loads youtube-dlc config files * All URLs changed to point to organization account Co-authored-by: Pccode66 Co-authored-by: pukkandan	4 years ago