Commit Graph

13 Commits (cc9ca3ba6e0ba24b318ef191fdf84927e773008d)

Author SHA1 Message Date
Philipp Hagemeister 385f8ae468 [eighttracks] PEP8 10 years ago
Philipp Hagemeister f71fdb0acc [eighttracks] Improve waiting (#3954) 10 years ago
Philipp Hagemeister c24dfef63c Merge remote-tracking branch 'lenaten/8tracks' 10 years ago
Philipp Hagemeister 1cc79574fc Fix imports and general cleanup
· Import from compat what comes from compat. Yes, some names are available in utils too, but that's an implementation detail.
· Use _match_id consistently whenever possible
· Fix some outdated tests
· Use consistent valid URL (always match the whole protocol, no ^ at start required)
· Use modern test definitions
10 years ago
netanel 754f0008ec fix increment operator 10 years ago
Philipp Hagemeister 8865bdeb37 Remove useless u prefixes 10 years ago
net 7b61ac3ddf Fix #2310. Play by the 8tracks rules 10 years ago
Philipp Hagemeister 0963f92f23 [eighttracks] modernize 10 years ago
dst c0ade33e16 Correct some extractor _VALID_URL regexes 11 years ago
Philipp Hagemeister f3682997d7 Clean up unused imports and other minor mistakes 11 years ago
Philipp Hagemeister 49a25557b0 [8tracks] Use track count instead of looking at at_last_track property
This fixes the error:

$ youtube-dl http://8tracks.com/vladmc/counting-stars
[8tracks] counting-stars: Downloading webpage
[8tracks] counting-stars: Downloading song information 1/4
[8tracks] counting-stars: Downloading song information 2/4
[8tracks] counting-stars: Downloading song information 3/4
[8tracks] counting-stars: Downloading song information 4/4
[8tracks] counting-stars: Downloading song information 5/4
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/phihag/projects/youtube-dl/youtube_dl/__main__.py", line 18, in <module>
    youtube_dl.main()
  File "/home/phihag/projects/youtube-dl/youtube_dl/__init__.py", line 761, in main
    _real_main(argv)
  File "/home/phihag/projects/youtube-dl/youtube_dl/__init__.py", line 714, in _real_main
    retcode = ydl.download(all_urls)
  File "/home/phihag/projects/youtube-dl/youtube_dl/YoutubeDL.py", line 701, in download
    videos = self.extract_info(url)
  File "/home/phihag/projects/youtube-dl/youtube_dl/YoutubeDL.py", line 342, in extract_info
    ie_result = ie.extract(url)
  File "/home/phihag/projects/youtube-dl/youtube_dl/extractor/common.py", line 121, in extract
    return self._real_extract(url)
  File "/home/phihag/projects/youtube-dl/youtube_dl/extractor/eighttracks.py", line 111, in _real_extract
    'id': track_data['id'],
KeyError: 'id'
11 years ago
Philipp Hagemeister 5c5de1c79a [eighttracks] move test 12 years ago
Philipp Hagemeister 828400422a [8tracks] Move into own file 12 years ago