Filippo Valsorda
4d318be195
[update] fix (unexploitable) BB'06 vulnerability in rsa_verify
...
The rsa_verify code was vulnerable to a BB'06 attack, allowing to forge
signatures for arbitrary messages if and only if the public key exponent is
3. Since the updates key is hardcoded to 65537, there is no risk for
youtube-dl, but I don't want vulnerable code in the wild.
The new function adopts a way safer approach of encoding-and-comparing to
replace the dangerous parsing code.
9 years ago
Jaime Marquínez Ferrándiz
e37afbe0b8
[YoutubeDL] urlopen: disable the 'file:' protocol ( #8227 )
...
If someone is running youtube-dl on a server to deliver files, the user could input 'file:///some/important/file' and youtube-dl would save that file as a video giving access to sensitive information to the user.
'file:' urls can be filtered, but the user can use an URL to a crafted m3u8 manifest like:
#EXTM3U
#EXT-X-MEDIA-SEQUENCE:0
#EXTINF:10.0
file:///etc/passwd
#EXT-X-ENDLIST
With this patch 'file:' URLs raise URLError like for unknown protocols.
9 years ago
Jakub Wilk
dfb1b1468c
Fix typos
...
Closes #8200 .
9 years ago
remitamine
f11d00fa41
[test_subtitles] remove BlipTV test
9 years ago
Sergey M․
6b77d52b1f
[test_utils] Add tests for encode_compat_str
9 years ago
Yen Chi Hsuan
db2fe38b55
[utils] Support alternative timestamp format in TTML
...
Fixes #7608
9 years ago
Yen Chi Hsuan
d631d5f9f2
[utils] Fix TTML conversion
...
Tolerate invalid timestamps (closes #7909 )
9 years ago
Sergey M․
31b2051e21
[utils] Add remove_quotes
9 years ago
Jaime Marquínez Ferrándiz
47f48f5d85
[test/test_all_urls] Update pbs extractor name
...
It's in lowercase now (since e15e2ef7a0
).
9 years ago
Sergey M․
9cb9a5df77
[utils] Check ext with trailing slash against the list of known extensions
9 years ago
Sergey M․
5035536e3f
[test_utils] Add tests for determine_ext
9 years ago
Sergey M․
7aefc49c40
[utils] Skip invalid/non HTML entities ( Closes #7518 )
9 years ago
Yen Chi Hsuan
ff29bf81f8
[jsinterp] Support alternative function definition form
9 years ago
Yen Chi Hsuan
66d041f250
[test/subtitles] Add test for DemocracynowIE
9 years ago
Jaime Marquínez Ferrándiz
6a75040278
[utils] unified_strdate: Return None if the date format can't be recognized ( fixes #7340 )
...
This issue was introduced with ae12bc3ebb
, it returned 'None'.
9 years ago
Sergey M
30eecc6a04
Merge pull request #7296 from jaimeMF/xml_attrib_unicode
...
Use a wrapper around xml.etree.ElementTree.fromstring in python 2.x (…
9 years ago
Sergey M․
578c074575
[utils] Support list of xpath in xpath_element
9 years ago
Sergey M․
52c3a6e49d
[utils] Improve parse_iso8601
9 years ago
Jaime Marquínez Ferrándiz
f78546272c
[compat] compat_etree_fromstring: also decode the text attribute
...
Deletes parse_xml from utils, because it also does it.
9 years ago
Jaime Marquínez Ferrándiz
387db16a78
[compat] compat_etree_fromstring: only decode bytes objects
9 years ago
Jaime Marquínez Ferrándiz
36e6f62cd0
Use a wrapper around xml.etree.ElementTree.fromstring in python 2.x ( #7178 )
...
Attributes aren't unicode objects, so they couldn't be directly used in info_dict fields (for example '--write-description' doesn't work with bytes).
9 years ago
Jaime Marquínez Ferrándiz
65d49afa48
[test/test_download] Use extract_flat = 'in_playlist' for playlist items
...
Some playlist extractors return a 'url' result, which wouldn't be resolved.
9 years ago
Sergey M․
d01949dc89
[utils:js_to_json] Fix bad escape in double quoted strings
9 years ago
Sergey M․
448ef1f31c
[extractor/common] Allow angle brackets in attributes in _og_regexes ( #7215 )
9 years ago
Sergey M․
8e5b121948
[test_youtube_lists] Add test flat playlist entries' titles
9 years ago
Sergey M․
db0a8ad979
[test_InfoExtractor] Add test for unquoted attribute
9 years ago
Sergey M․
1c29e81e62
[test_InfoExtractor] Add test for 7a6d76a64d
9 years ago
Jaime Marquínez Ferrándiz
7d0ada5ff9
[test/helper] Fix style
...
Use the correct indentation to please flake8
9 years ago
Sergey M․
f88f1b40ce
[test/helper] Clarify field for list length mismatch
9 years ago
Sergey M․
386a7b52d5
[test/helper] Spelling
9 years ago
Sergey M․
2e885de796
[test/helper] Formatting
9 years ago
Qijiang Fan
687c04cbb8
[test] use descriptive variable name
9 years ago
Qijiang Fan
40c931de4b
[test] split expect_dict to two functions
9 years ago
Qijiang Fan
93bc7ef165
[test] recursively check dict and list in expect_info_dict
...
This allows to use md5:, re:, etc within the str inside a list
or dict.
9 years ago
Sergey M․
c6aa838b51
[youtube:history] Enable exractor
9 years ago
Jaime Marquínez Ferrándiz
f005f96ea5
[youtube:history] Explain why it has disabled and skip test
9 years ago
remitamine
c67a055d16
[test/test_write_annotations] fix test filename
...
Closes #6781
9 years ago
Sergey M․
3513d41436
[test_compat] Fix typo
9 years ago
Sergey M․
ee087c79ad
[test_compat] Add test for compat_shlex_split
9 years ago
Sergey M․
f71264490c
[test_utils] Add tests for cli option converters
9 years ago
Sergey M․
87f70ab39d
[test_utils] Add more tests for xpath
9 years ago
Yen Chi Hsuan
f908b74fa3
[test/subtitles] Add test for ThePlatformFeedIE
9 years ago
Sergey M․
8e2b1be127
[test/helper] Make age_limit checkable field
9 years ago
Sergey M.
d5d7bdaeb5
Merge pull request #6428 from dstftw/improve-generic-smil-support
...
Improve generic SMIL support
9 years ago
Jaime Marquínez Ferrándiz
232541df44
[YoutubeDL] format spec: correctly handle dashes and other unused operators
...
'mp4-baseline-16x9' must be handled as a single string, but the '-' was treated as an operator.
9 years ago
Jaime Marquínez Ferrándiz
d96d604e53
YoutubeDL: format spec: don't accept a bare '/' ( #6124 )
9 years ago
Jaime Marquínez Ferrándiz
03950c90f7
Merge remote-tracking branch 'jaimemf/format_spec_groups' ( closes #6124 )
9 years ago
Sergey M․
645f814544
[test/helper] Allow dicts for mincount
9 years ago
Sergey M․
308cfe0ab3
[test_downloader] Respect --force-generic-extractor
9 years ago
Sergey M․
ee114368ad
[utils] Make value optional for find_xpath_attr
...
This allows selecting particular attributes by name but without specifying the value and similar to xpath syntax `[@attrib]`
9 years ago
Yen Chi Hsuan
9c29bc69f7
[utils] Improve parse_duration
...
Now dots are parsed. For example '87 Min.'
9 years ago
Sergey M․
8954e48140
[test_compat] Add tests for compat_urllib_parse_unquote_plus
9 years ago
Sergey M․
d79febcd06
[test_compat] Remove redundant test
9 years ago
Sergey M․
14309e1ddc
[test_compat] Make tests more idiomatic
9 years ago
fnord
4a63291144
Add tests for compat_urllib_parse_unquote
9 years ago
Jaime Marquínez Ferrándiz
0a31a35098
[YoutubeDL] format spec: add additional checks for invalid syntax
9 years ago
Jaime Marquínez Ferrándiz
bb8e553662
[YoutubeDL] format spec: Do not fail when a filter gives an empty result
...
For example with 'best[height<40]' we ended getting a 'IndexError: list index out of range'.
9 years ago
Jaime Marquínez Ferrándiz
f5f4a27a96
[YoutubeDL] format spec: fix handling of '/' with ','
...
When using 'bestvideo/best,bestaudio', 'bestvideo/best' must be set as the current_selector (instead of appending it to the selectors), otherwise when it gets the ',' it would append 'None' to the selectors.
9 years ago
Jaime Marquínez Ferrándiz
cf2ac6df68
[YoutubeDL] format spec: Fix handling of '+' with '/'
...
'bestvideo+bestaudio/best' was incorrectly interpreted as 'bestvideo+(bestaudio/best)', so it would fail if 'bestaudio' doesn't exist instead of falling back to 'best'.
9 years ago
Jaime Marquínez Ferrándiz
0130afb76e
[YoutubeDL] format spec: allow grouping specifiers with parentheses
9 years ago
Jaime Marquínez Ferrándiz
5acfa126c8
[YoutubeDL] format spec: treat 'all' like a normal specifier
...
So you can use filters with it, for example 'all[width>=400][width<=600]'.
9 years ago
Jaime Marquínez Ferrándiz
67134eaba1
[YoutubeDL] rework how the format spec is processed
...
The spec string is processed using 'tokenize.tokenize' to split it in words and operators, the filters are still processed using regular expressions.
This should make easier to allow grouping operators with parens.
9 years ago
Jaime Marquínez Ferrándiz
4c8fea92f3
[test/aes] Fix on python 3.3 and higher
...
Since 878563c847
the aes functions only accepts the base64 data as a unicode string.
10 years ago
Yen Chi Hsuan
f0bfaa2d7d
[nrk] Update subtitles test
...
Subtitle conversion routine is removed, so the subtitles are TTML now. See
1c7e2e64f6
10 years ago
Yen Chi Hsuan
1b0427e6c4
[utils] Support TTML without default namespace
...
In a strict sense such TTML is invalid, but Yahoo uses it.
10 years ago
Jaime Marquínez Ferrándiz
e9eaf3fbcf
[test/YoutubeDL] Add tests for 'playliststart', 'playlistend' and 'playlist_items'
10 years ago
Yen Chi Hsuan
7dff03636a
[utils] Support 'dur' field in TTML
10 years ago
Yen Chi Hsuan
d39e0f05db
[utils] Remove sanitize_url_path_consecutive_slashes()
...
This function is used only in SohuIE, which is updated to use a new
extraction logic.
10 years ago
Yen Chi Hsuan
0fe2ff78e6
[NBC] Enhance embedURL extraction ( closes #2549 )
10 years ago
Sergey M․
b3ed15b760
[utils] Add replace_extension
10 years ago
Sergey M․
a4bcaad773
[test_utils] Add tests for prepend_extension
10 years ago
Jaime Marquínez Ferrándiz
8dd5418803
Make 'best' format only match non-DASH formats ( closes #5554 )
...
Otherwise it's impossible to only download non-DASH formats, for example `best[height=?480]/best` would download a DASH video if it's the only one with height=480, instead for falling back to the second format specifier.
For audio only urls (soundcloud, bandcamp ...), the best audio will be downloaded as before.
10 years ago
Sergey M.
40b96352c9
Merge pull request #5523 from jaimeMF/remove-format-limit
...
Remove the --max-quality option
10 years ago
Yen Chi Hsuan
bf6427d2fb
[ffmpeg] Add dfxp (TTML) subtitles support ( #3432 , #5146 )
10 years ago
Jaime Marquínez Ferrándiz
9f3fa89f7c
Remove the --max-quality option
...
It doesn't work well with 'bestvideo' and 'bestaudio' because they are usually before the max quality.
Format filters should be used instead, they are more flexible and don't require the requested quality to exist for each video.
10 years ago
Sergey M․
70947ea7b1
[parameters.json] Set default `format` parameter to `best`
10 years ago
Yen Chi Hsuan
880ee801cf
[tests] Allow multi_video to be tested as playlists
10 years ago
Jaime Marquínez Ferrándiz
592e97e855
Postprocessors: use a list for the files that can be deleted
...
We could only know if we had to delete the original file, but this system allows to specify us more files (like subtitles).
10 years ago
Yen Chi Hsuan
0a1603634b
[utils] Remove url_infer_protocol
10 years ago
Yen Chi Hsuan
418c5cc3fc
[udn] Add new extractor
10 years ago
Sergey M․
ff02a228e3
[test_execution] Fix test under python 2 @ windows
10 years ago
Sergey M․
8cf70de428
[test_utils] Add test for unified_strdate
10 years ago
Sergey M․
ba9e68f402
[utils] Drop trailing comma before closing brace
10 years ago
Jaime Marquínez Ferrándiz
157e9e5aa5
[youtube:watchlater] Remove unused properties and fix tests
10 years ago
Naglis Jonaitis
91757b0f37
[utils] Escape all HTML entities written in hexadecimal form
10 years ago
Philipp Hagemeister
f5e2efbbf0
[options] Handle special characters in argv ( Fixes #5157 )
10 years ago
Jaime Marquínez Ferrándiz
f9544f6e8f
[test/aes] Test aes_decrypt_text with 256 bit
10 years ago
Jaime Marquínez Ferrándiz
5379a2d40d
[test/utils] Test xpath_text
10 years ago
Jaime Marquínez Ferrándiz
a7d9ded45d
[test] Add tests for aes
10 years ago
Jaime Marquínez Ferrándiz
531980d89c
[test/YoutubeDL] test match_filter
10 years ago
Jaime Marquínez Ferrándiz
f20bf146e2
[test/YoutubeDL] split in two classes
...
The name was misleading
10 years ago
Jaime Marquínez Ferrándiz
01218f919b
[test/http] Add test for proxy support
10 years ago
Sergey M․
92a4793b3c
[utils] Place sanitize url function near other sanitizing functions
10 years ago
Sergey M․
dc03a42537
Merge branch 'sohu_fix' of https://github.com/yan12125/youtube-dl into yan12125-sohu_fix
10 years ago
Jaime Marquínez Ferrándiz
8508557e77
[test/YoutubeDL] Use valid urls
...
It failed on python 3.4 when building the http_headers field
10 years ago
Jaime Marquínez Ferrándiz
4d1652484f
[test/unicode_literals] Don't look into the .git and .tox directories
...
The .tox directory contains python code that we can't control
10 years ago
Jaime Marquínez Ferrándiz
88cf6fb368
[metadatafromtitle] Some improvements and cleanup
...
* Remove the 'songtitle' field, 'title' can be used instead.
* Remove newlines in the help text, for consistency with other options.
* Add 'from __future__ import unicode_literals'.
* Call '__init__' from the parent class.
* Add test for the format_to_regex method
10 years ago
Jaime Marquínez Ferrándiz
3946864c8a
[vimeo] Use https for all vimeo.com urls
...
Unfortunately vimeopro.com doesn't support it yet.
10 years ago
Sergey M․
7e195d0e92
[funnyordie] Add subtitles test
10 years ago
Sergey M․
2ebfeacabc
[utils] Keep dot and dotdot unmodified ( Closes #5171 )
10 years ago
Sergey M․
f18ef2d144
[utils] Disallow trailing dot in sanitize_path for a path part
10 years ago
Sergey M․
a2aaf4dbc6
[utils] Add sanitize_path
10 years ago
Yen Chi Hsuan
55969016e9
[utils] Add a function to sanitize consecutive slashes in URLs
10 years ago
Philipp Hagemeister
499bfcbfd0
Make sure netrc works for all extractors with login support
...
Fixes #5112
10 years ago
Philipp Hagemeister
a7440261c5
[utils] Streap leading dots
...
Fixes #2865 , closes #5087
10 years ago
Philipp Hagemeister
3e675fabe0
[airmozilla] Be more tolerant when nonessential items are missing ( #5030 )
10 years ago
Philipp Hagemeister
5a42414b9c
[utils] Prevent hyphen at beginning of filename ( Fixes #5035 )
10 years ago
Jaime Marquínez Ferrándiz
25ac63ed71
[rtve] Extract subtitles
10 years ago
Jaime Marquínez Ferrándiz
bfc993cc91
Merge branch 'subtitles-rework'
...
(Closes PR #4964 )
10 years ago
Jaime Marquínez Ferrándiz
80970e531b
[test/subtitles] Update checksum for Viki
10 years ago
Jaime Marquínez Ferrándiz
b7bb76df05
[test/subtitles] Remove some tests
...
Test only with 'allsubtitles', the language selection is already tested in test_YoutubeDL.py
10 years ago
Jaime Marquínez Ferrándiz
98c70d6fc7
[YoutubeDL] only add normal subtitles to the 'requested_subtitles' field if 'writesubtitles' is True
10 years ago
Jaime Marquínez Ferrándiz
ab84349b16
[test/YoutubeDL] Add test for subtitles
...
Updated the offlinetest make target to not skip it
10 years ago
Jaime Marquínez Ferrándiz
4d17184817
[YoutubeDL] don't set the 'requested_subtitles' without writesubtitles or writeautomaticsub
10 years ago
Philipp Hagemeister
8fb3ac3649
PEP8: W503
10 years ago
Jaime Marquínez Ferrándiz
8807f1277f
[theplatform] Convert to new subtitles system
10 years ago
Philipp Hagemeister
d305dd73a3
[utils] Fix js_to_json
...
Previously, the runtime could be atrocious for longer inputs.
10 years ago
Jaime Marquínez Ferrándiz
4f7cea6c53
[viki] Convert to new subtitles system
10 years ago
Jaime Marquínez Ferrándiz
afbdd3acc3
[rai] Convert to new subtitles system
10 years ago
Philipp Hagemeister
9789d7535d
[xtube] Fix test case
10 years ago
Jaime Marquínez Ferrándiz
01561da142
[nrk] Convert to new subtitles system
10 years ago
Jaime Marquínez Ferrándiz
0af25f784b
[mtv] Convert to new subtitles system
10 years ago
Jaime Marquínez Ferrándiz
b9b42f2ea0
[npo] Convert to new subtitles system
10 years ago
Jaime Marquínez Ferrándiz
311c393838
[lynda] Convert to new subtitles system
10 years ago
Philipp Hagemeister
3eff81fbf7
[jsinterp] Disable comment support
...
We need a proper lexer to be able to understand YouTube's code, which contains /* inside of strings.
For now it's sufficient to just disable comment support altogether.
Fixes #4976 , fixes #4979 , fixes #4980 , fixes #4981 , fixes #4982 .
Closes #4977 .
10 years ago
Philipp Hagemeister
f21e915fb9
[test/helper] Render info_dict with a final comma
10 years ago
Philipp Hagemeister
6f53c63df6
[test/helper] Only output a newline for forgotten keys if keys are really missing
10 years ago
Jaime Marquínez Ferrándiz
85920dd01d
[bliptv] Convert to new subtitles system
10 years ago
Jaime Marquínez Ferrándiz
360e1ca5cc
[youtube] Convert to new subtitles system
...
The automatic captions are stored in the 'automactic_captions' field, which is used if no normal subtitles are found for an specific language.
10 years ago
Jaime Marquínez Ferrándiz
a1f2a06b34
[dailymotion] Convert to new subtitles system
10 years ago
Jaime Marquínez Ferrándiz
c84dd8a90d
[YoutubeDL] store the subtitles to download in the 'requested_subtitles' field
...
We need to keep the orginal subtitles information, so that the '--load-info' option can be used to list or select the subtitles again.
We'll also be able to have a separate field for storing the automatic captions info.
10 years ago
Jaime Marquínez Ferrándiz
65469a7f8b
[vimeo] Convert to new subtitles system
...
Removed some tests, the behaviour should be checked in a test for the YoutubeDL class
10 years ago
Jaime Marquínez Ferrándiz
a504ced097
Improve subtitles support
...
For each language the extractor builds a list with the available formats sorted (like for video formats), then YoutubeDL selects one of them using the '--sub-format' option which now allows giving the format preferences (for example 'ass/srt/best').
For each format the 'url' field can be set so that we only download the contents if needed, or if the contents needs to be processed (like in crunchyroll) the 'data' field can be used.
The reasons for this change are:
* We weren't checking that the format given with '--sub-format' was available, checking it in each extractor would be repetitive.
* It allows to easily support giving a format preference.
* The subtitles were automatically downloaded in the extractor, but I think that if you use for example the '--dump-json' option you want to finish as fast as possible.
Currently only the ted extractor has been updated, but the old system still works.
10 years ago
Jaime Marquínez Ferrándiz
8fb474fb17
[test/subtitles] Fix some tests
...
The checksym for the CeskaTelevize subtitles has changed again, so we just test that it has a reasonable length.
10 years ago
Jaime Marquínez Ferrándiz
36e7a4ca2e
[test/subtitles] Update checksums
10 years ago
Jaime Marquínez Ferrándiz
d304209a85
[test/parameters.json] Set 'fixup' to 'never'
...
The fixed audio files for Youtube have a size lower that the minimum required.
10 years ago
Philipp Hagemeister
6a78740211
[test/test_youtube_signature] Use fake YDL
10 years ago
Philipp Hagemeister
347de4931c
[YoutubeDL] Add generic video filtering ( Fixes #4916 )
...
This functionality is intended to eventually encompass the current format filtering.
10 years ago
Jaime Marquínez Ferrándiz
0161353d7d
[test/test_YoutubeDL] Remove debug print call
10 years ago
Jaime Marquínez Ferrándiz
2b4ecde2c8
[test/YoutubeDL] Add a simple test for postprocesors
...
Just checks that the 'keepvideo' option works as intended.
10 years ago
Philipp Hagemeister
9bb8e0a3f9
[wsj] Add new extractor ( Fixes #4854 )
10 years ago
Philipp Hagemeister
23d9ded655
[franceculture] Rewrite for new HTML scheme ( Fixes #4853 )
10 years ago
Philipp Hagemeister
8f4b58d70e
[ntvde] Add new extractor ( Fixes #4850 )
10 years ago
Philipp Hagemeister
9e3f19919a
[jsinterp] Beef up and add tests
...
In preparation for #4822 , extend jsinterp by a lot. (We may even have to/want to write a proper interpreter with actual parsing)
10 years ago
Philipp Hagemeister
4e980275b5
[test_download] Remove references to "file" in test definitions
10 years ago
Philipp Hagemeister
dc35bfd2d5
[test/helper] Clarify which keys have to be added
10 years ago
Philipp Hagemeister
03d8d4df38
[test_http] PEP8
10 years ago
Philipp Hagemeister
83fda3c000
Add a test for --no-check-certificate
10 years ago
Philipp Hagemeister
7d346331b5
[audiomack:album] Update testcase
10 years ago
Philipp Hagemeister
cfb56d1af3
Add --list-thumbnails
10 years ago