From bb9ec9a24d9c3527854a963ecc97611972ad1ca0 Mon Sep 17 00:00:00 2001 From: danilovsergei Date: Mon, 16 Oct 2023 22:35:04 -0700 Subject: [PATCH] Fix https://github.com/yt-dlp/yt-dlp/issues/8363 by manually adding metadata during ffmpeg split chapters execution --- yt_dlp/postprocessor/ffmpeg.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/yt_dlp/postprocessor/ffmpeg.py b/yt_dlp/postprocessor/ffmpeg.py index 323f4303c..800c14def 100644 --- a/yt_dlp/postprocessor/ffmpeg.py +++ b/yt_dlp/postprocessor/ffmpeg.py @@ -1046,6 +1046,20 @@ class FFmpegSplitChaptersPP(FFmpegPostProcessor): destination, ['-ss', str(chapter['start_time']), '-t', str(chapter['end_time'] - chapter['start_time'])]) + # FFmpeg adds metadata about all chapters from parent file to all split m4a files. + # This is incorrect since there must be only single chapter in each file after split. + # Such behavior confuses players who think multiple chapters present + def _set_out_opts(self, ext, chapter_title): + if ext == 'm4a': + return [ + *self.stream_copy_opts(), + # For m4a ffmpeg copies all available parent track chapters to split tracks metadata + # And such behavior confuses players + # Wipe parent track metadata from split tracks and fill out only title + '-metadata', 'title={}'.format(chapter_title), + '-map_metadata','-1'] + else: + return self.stream_copy_opts() @PostProcessor._restrict_to(images=False) def run(self, info): @@ -1061,7 +1075,8 @@ class FFmpegSplitChaptersPP(FFmpegPostProcessor): self.to_screen('Splitting video by chapters; %d chapters found' % len(chapters)) for idx, chapter in enumerate(chapters): destination, opts = self._ffmpeg_args_for_chapter(idx + 1, chapter, info) - self.real_run_ffmpeg([(in_file, opts)], [(destination, self.stream_copy_opts())]) + out_file_opts = self._set_out_opts(info['ext'], chapter['title']) + self.real_run_ffmpeg([(in_file, opts)], [(destination, out_file_opts)]) if in_file != info['filepath']: self._delete_downloaded_files(in_file, msg=None) return [], info