renames the container.Stale field to what it's actually used for, as staleness
is not the only factor used to decide whether a container should be updated anymore
also hides the private field along with linkedToRestarting
- removes unwieldy SkipUpdate return value in favor of errors.Is
- generalizes the code for all four phases
- allows timeout to be defined for all phases
- enables explicit unit in timeout label values (in addition to implicit minutes)
* feat(http): optional query parameter to update only containers of a specified image
* fix style issues
* comma separated image parameter
* Support comma-separated query parameter as well as specifying it multiple times
Co-authored-by: nils måsén <nils@piksel.se>
* fixed compile error
* fixed FilterByImageTag
Not sure what changed in my testing setup, but Docker reports image names including the tag name now.
* consistent use of image/tag (use image)
* fixed multiple image queries
* assuming I'm right here, only block on lock when any images are specified.
* add unit tests for image filter. didn't add tests for update api because they didn't already exist
* whoops.
* use ImageName instead, add unit test for empty ImageName filter.
Co-authored-by: nils måsén <nils@piksel.se>
should not be explicitly telling what they are testing and the requirements
fixed the test data so that it doesn't contain discrepancies
fully reset the mock client (no shared state) and only support the calls that is expected
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code
#649
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code
#649
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code
#649
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code
#649
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code #649
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code #649
* Make watchtower skip update if pre-update lifecycle hook exits with a non-zero exit code #649
* Prevent starting new container if old one is not stopped because of lifecycle hook.
* Add null check for c.containerInfo.State in IsRunning
* Fixed that the container would not start
* Added test for preupdate
* EX_TEMPFAIL -> ExTempFail
* Added missing fuction ouput names
* Skip preupdate when container is restarting.
* feat: check container config before restart
* fix: only skip when hostconfig and config differ
* fix: update test mocks to not fail tests
* test: add verify config tests
* feat: make head pull failure warning toggleable
* expect prometheus tests to go through EVENTUALLY
* wait for queue to be empty before checking test conditions
* clean up new head failure toggle
* fixup! clean up new head failure toggle
* test: add registry tests
* test: add warn on head failure tests
* fix client interface and make tests hit more lines
* make all tests use NewClient instead of creating a struct pointer
* fix lint issues
Co-authored-by: Simon Aronsson <simme@arcticbit.se>
Log based on registry known-poor support of HEAD in checking container
manifest.
Some private registries do not support HEAD (E.G. GitLab Container Registry).
With the current config, this log message is causing a notification to be
sent for each container hosted in a registry lacking HEAD support.
log.Debug or log.Warning for failed HTTP HEAD-check based on registry hostname
where HEAD-check is known to fail.
For Docker Hub, a failed HEAD leading to a "regular pull" may count against a
user's call-quota whereas other registry implementations do not support HEAD,
or whose container manifest may be in a different location.
* Add monitor-only label
* Add tests for monitor-only
* Treat missing monitor-only label as if the option was set to false
* Add docs for container-based monitor-only
* Add function doc
* Fix monitor-only logic
* Adds scopeUID config to enable multiple instances of Watchtower
* Adds tests for multiple instance support with scopeuid
* Adds docs on scope monitoring and multiple instance support
* Adds multiple instances docs to mkdocs config file
* Changes multiple instances check and refactors naming for scope feature
* Applies linter suggestions
* Fixes documentation on Watchtower monitoring scope
* Revert "Image of running container no longer needed locally (#571)"
This reverts commit 6da66fb312.
* Update client.go
* fix: skip updating when no image info can be retrieved
This will allow watchtower to continue even though the image info for a
container cannot be retrieved. If this happens one warning will be emitted
and the container will be skipped, unless NoRestart or OnlyMonitor is supplied
nils måsén