From f50bf703f45f45a7aa6dfd36762bb69889cb5660 Mon Sep 17 00:00:00 2001
From: Tim Su <tim@todoroo.com>
Date: Wed, 8 Feb 2012 17:33:04 -0800
Subject: [PATCH] Fix for row heights, minor appearance tweaks

---
 astrid/res/layout/web_service_row.xml                | 12 ++++++------
 .../todoroo/astrid/activity/TaskEditFragment.java    |  3 ++-
 .../src/com/todoroo/astrid/ui/WebServicesView.java   |  2 +-
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/astrid/res/layout/web_service_row.xml b/astrid/res/layout/web_service_row.xml
index 08334a007..a5ed6ae4e 100644
--- a/astrid/res/layout/web_service_row.xml
+++ b/astrid/res/layout/web_service_row.xml
@@ -17,13 +17,13 @@
     <!-- title -->
     <TextView android:id="@+id/title"
         android:layout_width="fill_parent"
-        android:layout_height="70dip"
+        android:layout_height="wrap_content"
         android:layout_marginLeft="5dip"
         android:layout_toRightOf="@id/image"
         android:paddingRight="30dp"
-        android:lines="2"
+        android:lines="3"
         android:singleLine="false"
-        android:textSize="20sp"
+        android:textSize="16sp"
         android:textStyle="bold"
         android:gravity="center_vertical"
         android:text="Probiotic - Wikepedia, the free encyclopedia"
@@ -32,13 +32,13 @@
     <!-- url -->
     <TextView android:id="@+id/subtitle"
         android:layout_width="fill_parent"
-        android:layout_height="35dip"
-        android:layout_alignParentBottom="true"
+        android:layout_height="wrap_content"
+        android:layout_below="@id/title"
         android:layout_toRightOf="@id/image"
         android:layout_marginLeft="5dip"
         android:paddingRight="30dp"
         android:singleLine="true"
-        android:textSize="16sp"
+        android:textSize="14sp"
         android:text="en.wikipedia.org"
         android:gravity="center_vertical" />
         
diff --git a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java
index 262c6741f..100f86df6 100755
--- a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java
+++ b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java
@@ -1179,7 +1179,6 @@ public final class TaskEditFragment extends Fragment implements
         case TAB_VIEW_UPDATES:
             return editNotes;
         case TAB_VIEW_WEB_SERVICES:
-            setViewHeightBasedOnChildren(webServices);
             return webServices;
         }
 
@@ -1193,8 +1192,10 @@ public final class TaskEditFragment extends Fragment implements
         switch(getTabForPosition(position)) {
         case TAB_VIEW_MORE:
             view = moreControls;
+            break;
         case TAB_VIEW_UPDATES:
             view = editNotes;
+            break;
         case TAB_VIEW_WEB_SERVICES:
             view = webServices;
         }
diff --git a/astrid/src/com/todoroo/astrid/ui/WebServicesView.java b/astrid/src/com/todoroo/astrid/ui/WebServicesView.java
index 0a3b769e4..8fe5d9200 100644
--- a/astrid/src/com/todoroo/astrid/ui/WebServicesView.java
+++ b/astrid/src/com/todoroo/astrid/ui/WebServicesView.java
@@ -101,7 +101,7 @@ public class WebServicesView extends LinearLayout {
                 Context.LAYOUT_INFLATER_SERVICE);
 
         rowParams = new LinearLayout.LayoutParams(
-                Math.round(metrics.widthPixels * 0.8f),
+                Math.round(metrics.widthPixels * 0.75f),
                 Math.round(ROW_HEIGHT * metrics.density));
         rowParams.rightMargin = Math.round(10 * metrics.density);