Let user turn Google Drive backup off

6 years ago · ee1c20c61a
parent d74f6d457a
commit ee1c20c61a
1 changed files with 11 additions and 5 deletions
--- a/app/src/main/java/org/tasks/preferences/BasicPreferences.java
+++ b/app/src/main/java/org/tasks/preferences/BasicPreferences.java
@ -177,14 +177,20 @@ public class BasicPreferences extends InjectingPreferenceActivity
    googleDriveBackup
        .setOnPreferenceChangeListener(
            (preference, newValue) -> {
-              if (newValue != null && (Boolean) newValue) {
-                if (!playServices.refreshAndCheck()) {
-                  playServices.resolve(this);
-                } else {
+              if (newValue == null) {
+                return false;
+              }
+
+              if ((Boolean) newValue) {
+                if (playServices.refreshAndCheck()) {
                  requestLogin();
+                } else {
+                  playServices.resolve(this);
                }
+                return false;
+              } else {
+                return true;
              }
-              return false;
            });

    requires(