From ead531e0be8b638f292a221514f0fc1215716a3f Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Tue, 26 Jun 2012 18:04:03 -0700 Subject: [PATCH] A bunch of Toast calls were missing calls to show() --- .../com/todoroo/astrid/files/AACRecordingActivity.java | 2 +- .../com/todoroo/astrid/files/FilesControlSet.java | 6 +++--- .../plugin-src/com/todoroo/astrid/gcal/GCalControlSet.java | 2 +- .../src/com/todoroo/astrid/activity/TaskEditFragment.java | 6 +++--- astrid/src/com/todoroo/astrid/ui/QuickAddBar.java | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/astrid/plugin-src/com/todoroo/astrid/files/AACRecordingActivity.java b/astrid/plugin-src/com/todoroo/astrid/files/AACRecordingActivity.java index 664dd60b6..c3b26a321 100644 --- a/astrid/plugin-src/com/todoroo/astrid/files/AACRecordingActivity.java +++ b/astrid/plugin-src/com/todoroo/astrid/files/AACRecordingActivity.java @@ -93,7 +93,7 @@ public class AACRecordingActivity extends Activity implements AACRecorderCallbac finish(); } catch (IOException e) { e.printStackTrace(); - Toast.makeText(this, R.string.audio_err_encoding, Toast.LENGTH_LONG); + Toast.makeText(this, R.string.audio_err_encoding, Toast.LENGTH_LONG).show(); } if (pd != null) pd.dismiss(); diff --git a/astrid/plugin-src/com/todoroo/astrid/files/FilesControlSet.java b/astrid/plugin-src/com/todoroo/astrid/files/FilesControlSet.java index 0663282d4..ecc71bdd5 100644 --- a/astrid/plugin-src/com/todoroo/astrid/files/FilesControlSet.java +++ b/astrid/plugin-src/com/todoroo/astrid/files/FilesControlSet.java @@ -231,7 +231,7 @@ public class FilesControlSet extends PopupControlSet { Bitmap bitmap = AndroidUtilities.readScaledBitmap(filePath); if (bitmap == null) { - Toast.makeText(activity, R.string.file_err_memory, Toast.LENGTH_LONG); + Toast.makeText(activity, R.string.file_err_memory, Toast.LENGTH_LONG).show(); return; } @@ -326,7 +326,7 @@ public class FilesControlSet extends PopupControlSet { activity.runOnUiThread(new Runnable() { @Override public void run() { - Toast.makeText(activity, R.string.file_err_download, Toast.LENGTH_LONG); + Toast.makeText(activity, R.string.file_err_download, Toast.LENGTH_LONG).show(); } }); return; @@ -380,7 +380,7 @@ public class FilesControlSet extends PopupControlSet { activity.runOnUiThread(new Runnable() { @Override public void run() { - Toast.makeText(activity, R.string.file_err_download, Toast.LENGTH_LONG); + Toast.makeText(activity, R.string.file_err_download, Toast.LENGTH_LONG).show(); } }); } finally { diff --git a/astrid/plugin-src/com/todoroo/astrid/gcal/GCalControlSet.java b/astrid/plugin-src/com/todoroo/astrid/gcal/GCalControlSet.java index c1e84dcd4..f3f925b54 100644 --- a/astrid/plugin-src/com/todoroo/astrid/gcal/GCalControlSet.java +++ b/astrid/plugin-src/com/todoroo/astrid/gcal/GCalControlSet.java @@ -199,7 +199,7 @@ public class GCalControlSet extends PopupControlSet { } catch (Exception e) { Log.e("gcal-error", "Error opening calendar", e); //$NON-NLS-1$ //$NON-NLS-2$ - Toast.makeText(activity, R.string.gcal_TEA_error, Toast.LENGTH_LONG); + Toast.makeText(activity, R.string.gcal_TEA_error, Toast.LENGTH_LONG).show(); } finally { cursor.close(); } diff --git a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java index 5a6488222..86600a520 100755 --- a/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java +++ b/astrid/src/com/todoroo/astrid/activity/TaskEditFragment.java @@ -1044,7 +1044,7 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { private void attachFile(String file) { File src = new File(file); if (!src.exists()) { - Toast.makeText(getActivity(), R.string.file_err_copy, Toast.LENGTH_LONG); + Toast.makeText(getActivity(), R.string.file_err_copy, Toast.LENGTH_LONG).show(); return; } @@ -1052,7 +1052,7 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { try { AndroidUtilities.copyFile(src, dst); } catch (Exception e) { - Toast.makeText(getActivity(), R.string.file_err_copy, Toast.LENGTH_LONG); + Toast.makeText(getActivity(), R.string.file_err_copy, Toast.LENGTH_LONG).show(); return; } @@ -1085,7 +1085,7 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener { createNewFileAttachment(path, nameRef.get(), FileMetadata.FILE_TYPE_IMAGE + "png"); } catch (Exception e) { - Toast.makeText(getActivity(), R.string.file_err_copy, Toast.LENGTH_LONG); + Toast.makeText(getActivity(), R.string.file_err_copy, Toast.LENGTH_LONG).show(); } } diff --git a/astrid/src/com/todoroo/astrid/ui/QuickAddBar.java b/astrid/src/com/todoroo/astrid/ui/QuickAddBar.java index 7d2177a17..63bff48ba 100644 --- a/astrid/src/com/todoroo/astrid/ui/QuickAddBar.java +++ b/astrid/src/com/todoroo/astrid/ui/QuickAddBar.java @@ -465,7 +465,7 @@ public class QuickAddBar extends LinearLayout implements RecognizerApiListener { errorStr = R.string.speech_err_network; break; case SpeechRecognizer.ERROR_NO_MATCH: - Toast.makeText(activity, R.string.speech_err_no_match, Toast.LENGTH_LONG); + Toast.makeText(activity, R.string.speech_err_no_match, Toast.LENGTH_LONG).show(); break; default: errorStr = R.string.speech_err_default;