diff --git a/src/main/java/com/todoroo/astrid/adapter/TaskAdapter.java b/src/main/java/com/todoroo/astrid/adapter/TaskAdapter.java index 7e0f687d0..e14139acc 100644 --- a/src/main/java/com/todoroo/astrid/adapter/TaskAdapter.java +++ b/src/main/java/com/todoroo/astrid/adapter/TaskAdapter.java @@ -141,7 +141,6 @@ public class TaskAdapter extends CursorAdapter implements Filterable { private final Map tagMap = new HashMap<>(); - private final int textColorPrimary; private final int textColorSecondary; private final int textColorHint; private final int textColorOverdue; @@ -173,7 +172,6 @@ public class TaskAdapter extends CursorAdapter implements Filterable { displayMetrics = new DisplayMetrics(); fragment.getActivity().getWindowManager().getDefaultDisplay().getMetrics(displayMetrics); - textColorPrimary = getData(context, android.R.attr.textColorPrimary); textColorSecondary = getData(context, android.R.attr.textColorSecondary); textColorHint = getData(context, android.R.attr.textColorTertiary); textColorOverdue = resources.getColor(R.color.overdue); @@ -474,14 +472,14 @@ public class TaskAdapter extends CursorAdapter implements Filterable { * uncompleted. */ protected void setTaskAppearance(ViewHolder viewHolder, Task task) { - boolean state = task.isCompleted(); + boolean completed = task.isCompleted(); TextView name = viewHolder.nameView; - if(state) { - name.setTextColor(textColorHint); + if (completed) { + name.setEnabled(false); name.setPaintFlags(name.getPaintFlags() | Paint.STRIKE_THRU_TEXT_FLAG); } else { - name.setTextColor(textColorPrimary); + name.setEnabled(true); name.setPaintFlags(name.getPaintFlags() & ~Paint.STRIKE_THRU_TEXT_FLAG); } name.setTextSize(fontSize); diff --git a/src/main/res/color-night/text_primary.xml b/src/main/res/color-night/text_primary.xml new file mode 100644 index 000000000..9ed021e68 --- /dev/null +++ b/src/main/res/color-night/text_primary.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/src/main/res/color/task_edit_toggle_button_text.xml b/src/main/res/color/task_edit_toggle_button_text.xml deleted file mode 100644 index 378c4af3e..000000000 --- a/src/main/res/color/task_edit_toggle_button_text.xml +++ /dev/null @@ -1,12 +0,0 @@ - - - - - - diff --git a/src/main/res/color/text_primary.xml b/src/main/res/color/text_primary.xml new file mode 100644 index 000000000..003b2be28 --- /dev/null +++ b/src/main/res/color/text_primary.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/src/main/res/layout/task_adapter_row_simple.xml b/src/main/res/layout/task_adapter_row_simple.xml index c7a257f4f..25300962a 100644 --- a/src/main/res/layout/task_adapter_row_simple.xml +++ b/src/main/res/layout/task_adapter_row_simple.xml @@ -51,6 +51,7 @@ android:layout_height="wrap_content" android:layout_weight="100" android:ellipsize="end" + android:textColor="?android:attr/textColorPrimary" android:gravity="start|center_vertical" android:textAlignment="viewStart" android:maxLines="1" diff --git a/src/main/res/values-night/colors.xml b/src/main/res/values-night/colors.xml index 6aaf111bc..c37bb8e88 100644 --- a/src/main/res/values-night/colors.xml +++ b/src/main/res/values-night/colors.xml @@ -5,7 +5,6 @@ @color/icon_tint_dark @color/drawer_background_dark @color/drawer_background_dark_selected - @color/white_100 @color/white_70 @color/white_50 @color/white_12 diff --git a/src/main/res/values-notnight/colors.xml b/src/main/res/values-notnight/colors.xml index 5836559e7..f03e50dd3 100644 --- a/src/main/res/values-notnight/colors.xml +++ b/src/main/res/values-notnight/colors.xml @@ -5,7 +5,6 @@ @color/icon_tint_light @color/drawer_background_light @color/drawer_background_light_selected - @color/black_87 @color/black_54 @color/black_38 @color/black_12