From e55a4e187425f21c47cad0fdad2601a9ae0cb7fa Mon Sep 17 00:00:00 2001 From: Sam Bosley Date: Wed, 26 Sep 2012 10:16:51 -0700 Subject: [PATCH] Record statistics on the social sharing activity --- .../com/todoroo/astrid/activity/ShareActivity.java | 13 ++++++++----- .../todoroo/astrid/service/StatisticsConstants.java | 2 ++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/astrid/src/com/todoroo/astrid/activity/ShareActivity.java b/astrid/src/com/todoroo/astrid/activity/ShareActivity.java index 2c8bc8952..c55257b20 100644 --- a/astrid/src/com/todoroo/astrid/activity/ShareActivity.java +++ b/astrid/src/com/todoroo/astrid/activity/ShareActivity.java @@ -15,6 +15,8 @@ import android.widget.LinearLayout; import android.widget.TextView; import com.timsu.astrid.R; +import com.todoroo.astrid.service.StatisticsConstants; +import com.todoroo.astrid.service.StatisticsService; import com.todoroo.astrid.service.ThemeService; public class ShareActivity extends FragmentActivity { @@ -34,23 +36,24 @@ public class ShareActivity extends FragmentActivity { setContentView(R.layout.share_activity); TextView fb = (TextView) findViewById(R.id.share_facebook); - setUpTextView(fb, getString(R.string.share_with_facebook), "http://facebook.com/weloveastrid"); //$NON-NLS-1$ + setUpTextView(fb, getString(R.string.share_with_facebook), "http://facebook.com/weloveastrid", "facebook"); //$NON-NLS-1$ //$NON-NLS-2$ TextView twitter = (TextView) findViewById(R.id.share_twitter); - setUpTextView(twitter, getString(R.string.share_with_twitter), "http://twitter.com/#!/weloveastrid"); //$NON-NLS-1$ + setUpTextView(twitter, getString(R.string.share_with_twitter), "http://twitter.com/#!/weloveastrid", "twitter"); //$NON-NLS-1$ //$NON-NLS-2$ TextView google = (TextView) findViewById(R.id.share_google); - setUpTextView(google, getString(R.string.share_with_google), "https://plus.google.com/116404018347675245869"); //$NON-NLS-1$ + setUpTextView(google, getString(R.string.share_with_google), "https://plus.google.com/116404018347675245869", "google"); //$NON-NLS-1$ //$NON-NLS-2$ setupText(); - + StatisticsService.reportEvent(StatisticsConstants.SHARE_PAGE_VIEWED); } - private void setUpTextView(TextView tv, String text, final String url) { + private void setUpTextView(TextView tv, String text, final String url, final String buttonId) { tv.setText(text); ((View) tv.getParent()).setOnClickListener(new OnClickListener() { @Override public void onClick(View v) { + StatisticsService.reportEvent(StatisticsConstants.SHARE_BUTTON_CLICKED, "button", buttonId); //$NON-NLS-1$ Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url)); startActivity(intent); } diff --git a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java index ddb42b4c4..6fdbf325e 100644 --- a/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java +++ b/astrid/src/com/todoroo/astrid/service/StatisticsConstants.java @@ -71,6 +71,8 @@ public class StatisticsConstants { public static final String TASK_RABBIT_VIEW = "task-rabbit-view"; public static final String TASK_RABBIT_POST = "task-rabbit-post"; public static final String TASK_RABBIT_LOGIN = "task-rabbit-login"; + public static final String SHARE_PAGE_VIEWED = "share-page-viewed"; + public static final String SHARE_BUTTON_CLICKED = "share-button-clicked"; public static final String PREF_THIRD_PARTY_ADDONS = "pref-third-party-addons"; public static final String PREF_SHOW_NOTES_IN_ROW = "pref-show-notes";